I am trying to help contributing into openHAB the org.openhab.binding.broadlink binding, by themillhousegroup (https://github.com/themillhousegroup/openhab2-addons/openhab-3.2-broadlink-binding)
I am currently doing somoe basic cleanup of the binding and going through the output of the maven clean install report. I was able to clean up most of the issues, but i am still left with 2 level 3 issues of the same type, on lines 29 and 30 of each file, respectively:
### Details by Class org.openhab.binding.broadlink.internal.BroadlinkProtocolTest.java tool priority line category rule message pmd 3 29 error prone MoreThanOneLogger Class contains more than one logger. org.openhab.binding.broadlink.internal.ModelMapperTest.java tool priority line category rule message pmd 3 30 error prone MoreThanOneLogger Class contains more than one logger.
(I do not think the line where the issue is detected, that is reported by pmd is meaningful, as it is just the class declaration)
However, in both instances of the issue, i fail to see where there is two loggers used, or even defined. I am wondering if these two instances are false positives, or if i am missing something. It would be great if someone could give me their opinion so i can either look for a solution before contributing, or leave it as is. The two issues are in the following files:
I appreciate any comments or suggestions the community could have.