Add-on Contribution

ricardol · July 9, 2022, 2:45pm

Hello,

I am trying to help contributing into openHAB the org.openhab.binding.broadlink binding, by themillhousegroup (https://github.com/themillhousegroup/openhab2-addons/openhab-3.2-broadlink-binding)

I am currently doing somoe basic cleanup of the binding and going through the output of the maven clean install report. I was able to clean up most of the issues, but i am still left with 2 level 3 issues of the same type, on lines 29 and 30 of each file, respectively:

### Details by Class

org.openhab.binding.broadlink.internal.BroadlinkProtocolTest.java
tool priority line category rule message
pmd 3 29 error prone MoreThanOneLogger Class contains more than one logger.

org.openhab.binding.broadlink.internal.ModelMapperTest.java
tool priority line category rule message
pmd 3 30 error prone MoreThanOneLogger Class contains more than one logger.

(I do not think the line where the issue is detected, that is reported by pmd is meaningful, as it is just the class declaration)

However, in both instances of the issue, i fail to see where there is two loggers used, or even defined. I am wondering if these two instances are false positives, or if i am missing something. It would be great if someone could give me their opinion so i can either look for a solution before contributing, or leave it as is. The two issues are in the following files:

github.com

themillhousegroup/openhab2-addons/blob/openhab-3.2-broadlink-binding/bundles/org.openhab.binding.broadlink/src/test/java/org/openhab/binding/broadlink/internal/BroadlinkProtocolTest.java

/**
 * Copyright (c) 2010-2021 Contributors to the openHAB project
 *
 * See the NOTICE file(s) distributed with this work for additional
 * information.
 *
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
 *
 * SPDX-License-Identifier: EPL-2.0
 */
package org.openhab.binding.broadlink.internal;

import static org.junit.Assert.assertEquals;

import org.eclipse.jdt.annotation.NonNullByDefault;
import org.junit.Test;
import org.mockito.Mockito;
import org.openhab.core.util.HexUtils;

This file has been truncated. show original

and

github.com

themillhousegroup/openhab2-addons/blob/openhab-3.2-broadlink-binding/bundles/org.openhab.binding.broadlink/src/test/java/org/openhab/binding/broadlink/internal/ModelMapperTest.java

/**
 * Copyright (c) 2010-2021 Contributors to the openHAB project
 *
 * See the NOTICE file(s) distributed with this work for additional
 * information.
 *
 * This program and the accompanying materials are made available under the
 * terms of the Eclipse Public License 2.0 which is available at
 * http://www.eclipse.org/legal/epl-2.0
 *
 * SPDX-License-Identifier: EPL-2.0
 */
package org.openhab.binding.broadlink.internal;

import static org.junit.Assert.assertEquals;

import org.eclipse.jdt.annotation.NonNullByDefault;
import org.junit.Assert;
import org.junit.Test;
import org.mockito.Mockito;

This file has been truncated. show original

I appreciate any comments or suggestions the community could have.

Thanks!

wborn · July 9, 2022, 3:35pm

It seems to be a known PMD issue, see:

github.com/pmd/pmd

[java] MoreThanOneLogger is reported on mocked Logger field

opened 11:41AM - 18 Mar 22 UTC

magwas

a:false-positive

**Affects PMD Version:** 6.42.0 **Rule:** MoreThanOneLogger https://pmd.g…ithub.io/pmd-6.42.0/pmd_rules_java_errorprone.html#morethanonelogger **Description:** Rule Violation Line [MoreThanOneLogger](https://pmd.github.io/pmd-6.42.0/pmd_rules_java_errorprone.html#morethanonelogger) Class contains more than one logger. 6–10 **Code Sample demonstrating the issue:** ``` package com.kodekonveyor.authentication; import org.mockito.Mockito; import org.slf4j.Logger; class PMDErrorDemonstrationTestBase { Logger loggerService = Mockito.mock(Logger.class); } ``` **Expected outcome:** PMD reports a violation at line 6-10, but that's wrong. That's a false positive. **Running PMD through:** Maven

ricardol · July 9, 2022, 3:57pm

Thanks @wborn , I missed that report.

Sounds like we will start working on merging the code.

Regards