Am I following process correctly for new binding PR approval?

theiding · January 10, 2020, 9:29pm

I submitted my first PR for a new binding on 12/8 (https://github.com/openhab/openhab-addons/pull/6553). This being my first submission I hope I correctly followed all steps (as laid out in https://www.openhab.org/docs/developer/contributing.html), but I am not sure. One mistake was pointed out to me re. JavaDocs and that should be corrected now. Is there anything else I need to do on my side or do I simply await a review at this point?

Thank you!

Mark

rlkoshak · January 10, 2020, 9:53pm

I think you respond to any requests for changes asked for by the maintainers and wait for review. They do them as fast as they can but it’s a lot of work and there is quite a backlog.

theiding · January 10, 2020, 9:59pm

Thank you for the feedback! Fully understand the backlog challenge - just wanted to make sure I am not holding anything up from my side.

J-N-K · January 10, 2020, 10:52pm

I have done an initial review right now.

theiding · January 11, 2020, 4:21am

Fantastic! I’ll check it out right away.