(Check) Rule transition help

[rlkoshak (Rich Koshak)]

@binderth

if your Goal is to have as few lines and characters as possible:

Not only is this version of the rule shorter but it has one other very important quality. It only calls WDim01_Dim.sendCommand once. I really like this approach and try to implement it in all my code as well, even if it makes the Rule a little bit longer.

The reason I like it is that it is a great application of Don’t Repeat Yourself (DRY). Even if it is just one line, it is better to only call the function on one line if the only difference is the arguments passed to that function. It will also make it a lot easier on down the road when you need to do some extra checking or calculations before calling sendCommand. By only having one place where sendCommand is called you can add the checking or testing there.

@binderth

of course you could shorten dimValue to dV and get rid of the case 1.0, since dimValue has already the default value of 0…

I also really like this sort of approach as well. I will often default the value and only test to see if I need to change the default.

@binderth

If you’d like to have as little Zwave traffic as possible, you could also Change your trigger to Item FibBut01_Scene changed

Or check to see if dimValue is different from the current state and only sendCommand if they are different. Hey, look at that, we are already benefiting from putting the call to sendCommand at the end.

if(WDim01_Dim.state != dimBValue) WDim01_Dim.sendCommand(dimValue)

@Dim

maybe I can find a way to “map” the Button states (1.0 to 1.6 = 7 options) that the Fib_Button provides to percentage values and use this mapping to send the dimming level in the command… I will try to find a way to do this and let you know.

I’ll leave Design Pattern: Human Readable Names in Messages here for you.

scene.map

1.0=0
1.1=10
1.2=50
1.3=100
1.4=3
1.5=2
1.6=1
NULL=0
UNDEF=0

Don’t forget NULL and UNDEF.

Then the Rule becomes:

rule	"Fibaro Button 01 Pushing"
when
	Item FibBut01_Scene received update
then
	var dimValue = transform("MAP", "scene.map", FibBut01_Scene.state.toString)
	if(WDim01_Dim.state.toString != dimValue) WDim01_Dim.sendCommand(dimValue)
end

It is kind of a false efficiency. The switch statement will run a whole lot faster, and in some ways it becomes a little harder to understand what the rule does because you have to look in two places to see what it does. But now you can change the map file without touching your Rule to change the dimming values and add new scenes.