Contribution - LG ThinQ Binding

csi_oh · September 6, 2024, 8:01pm

Hi there, thanks, I’m aware of that → not possible for this particular binding (e.g. the “astro” binding has that blue gear icon you mentioned).

hmerk · September 6, 2024, 8:35pm

Why not ?
Marketplace Bindings are shown in the UI and have that icon.

csi_oh · September 7, 2024, 5:30am

Can’t tell …

hmerk · September 7, 2024, 6:06am

Thats strange.
Tried it yesterday with a different Marketplace Binding and saw the little gear icon. Today, it is gone…
Third Party Marketplace Bindings like Smathome/J Tuya Binding still have this icon…
We will have to check……

@florian-h05 Do you have an idea what’s wrong here ???

florian-h05 · September 10, 2024, 4:04pm

The UI decides in openhab-webui/bundles/org.openhab.ui/web/src/pages/addons/addon-details.vue at 8e357f40df7200cf7b87e3fe79a1d5ef1b912938 · openhab/openhab-webui · GitHub whether to show the config gear based on the addon info that is loaded in openhab-webui/bundles/org.openhab.ui/web/src/pages/addons/addon-details.vue at 8e357f40df7200cf7b87e3fe79a1d5ef1b912938 · openhab/openhab-webui · GitHub.

Can you please check the browser network tab (browser dev tools) for a request to

/rest/addons/someAddonId?serviceId=someOptionalServiceId

and share the response here?

And probably ping me in the answer so I notice it.

hmerk · September 10, 2024, 4:37pm

@florian-h05
A query of /rest/addons to get all bindings does not list any Marketplace Bindings.
Even trying

/rest/addons/marketplace%3A158233

for the LGThinQ Binding lead to a 404…

florian-h05 · September 12, 2024, 8:36am

Is that what the UI does when opening the add-on detail page for this binding?

hmerk · September 12, 2024, 9:10am

@florian-h05

This is what I see in network console:

Anforderungs-URL:
http://192.168.1.22:8080/rest/addons/marketplace:158233?serviceId=marketplace
Anforderungsmethode:
GET
Statuscode:
200 OK
Remoteadresse:
192.168.1.22:8080
Referrer-Richtlinie:
strict-origin-when-cross-origin
content-encoding:
gzip
content-type:
application/json
date:
Thu, 12 Sep 2024 09:08:36 GMT
server:
Jetty(9.4.54.v20240208)
transfer-encoding:
chunked
vary:
Accept-Encoding, User-Agent
accept:
application/json
accept-encoding:
gzip, deflate
accept-language:
de,de-DE;q=0.9,en;q=0.8,en-GB;q=0.7,en-US;q=0.6
authorization:
Bearer eyJraWQiOm51bGwsImFsZyI6IlJTMjU2In0.eyJpc3MiOiJvcGVuaGFiIiwiYXVkIjoib3BlbmhhYiIsImV4cCI6MTcyNjEzNTM1MywianRpIjoiUXdWMmZUaFVVOXZZemdpTXZfSVlEZyIsImlhdCI6MTcyNjEzMTc1MywibmJmIjoxNzI2MTMxNjMzLCJzdWIiOiJhZG1pbiIsImNsaWVudF9pZCI6Imh0dHA6Ly8xOTIuMTY4LjEuMjI6ODA4MCIsInNjb3BlIjoiYWRtaW4iLCJyb2xlIjpbImFkbWluaXN0cmF0b3IiXX0.MQtos1YVNeeh8q1XljAvGFWz4Q_TCxRv1UlDk3Wp3Vhl9NDBw-8umcfpUlwf89X8MkY7Hk38Ox3IXWyLzjCoV0nC-qG6QYBcyxe3ZxQIx0k4wzvwQYvqoT67jaw42SQoNyM9wtWgMQH0vf4qSC6gVis64dD1f_hJTZIHP2sAbdWWztS8y4AG94dV9JQf4lL3mXb5Gv3BrhUvGBQkaheGQs4R7jJpJhJNn2guR2ZRfUtF2FcNShNklGSEPlDJF9ACKA5K_kw8Hbo5-WSv8a2LZWVjYF4QD3YqR3WqVO_SoPtuyNa-ZzkW8ugmgmqAJ6_ECbR1vuw0bjV4KK2rf8vuFA
connection:
keep-alive
cookie:
csm-hit=tb:YE3PNYVT9BR2GWNSJGKA+s-YE3PNYVT9BR2GWNSJGKA|1709027478073&t:1709027478073&adb:adblk_no; X-OPENHAB-SESSIONID=9196558f-67c7-4e34-84ec-836354f9640e
dnt:
1
host:
192.168.1.22:8080
referer:
http://192.168.1.22:8080/addons/binding/marketplace:158233
user-agent:
Mozilla/5.0 (iPhone; CPU iPhone OS 16_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Mobile/15E148 Safari/604.1 Edg/128.0.0.0
x-requested-with:
XMLHttpRequest

florian-h05 · September 12, 2024, 9:49am

Thanks, no 404 this time.
What’s the response?

hmerk · September 12, 2024, 1:43pm

@florian-h05

I hope this is what you are looking for

{
    "uid": "marketplace:158233",
    "id": "lgthinq",
    "label": "LG Thinq Binding",
    "version": "",
    "maturity": "beta",
    "compatible": true,
    "contentType": "application/vnd.openhab.bundle",
    "link": "https://community.openhab.org/t/158233",
    "author": "Nemer Daud",
    "verifiedAuthor": false,
    "installed": true,
    "type": "binding",
    "detailedDescription": "\u003cp\u003e\u003cimg src\u003d\"https://raw.githubusercontent.com/nemerdaud/openhab-thinq-stuff/main/lgthinq.png\" alt\u003d\"LG Thinq Binding\" width\u003d\"153\" height\u003d\"131\"\u003e\u003c/p\u003e\n\u003cp\u003eThis binding was developed to integrate the LG ThinQ API with openHAB.\u003cbr\u003e\nThe ThinQ Thinq Binding works as a hub/bridge to discovery and first configure the LG ThinQ devices related with the LG’s user account.\u003cbr\u003e\nThus, the first thing is to create the LG ThinQ Bridge and then, it will discover all Things you have related in your LG Account.\u003cbr\u003e\nPlease, read the \u003ca href\u003d\"https://github.com/nemerdaud/openhab-addons/raw/feature/lgthinq-binding/bundles/org.openhab.binding.lgthinq/README.md\" rel\u003d\"noopener nofollow ugc\"\u003eREADME\u003c/a\u003e for more details.\u003c/p\u003e\n\u003ch2\u003e\u003ca name\u003d\"p-903500-changelog-1\" class\u003d\"anchor\" href\u003d\"#p-903500-changelog-1\"\u003e\u003c/a\u003eChangelog\u003c/h2\u003e\n\u003ch3\u003e\u003ca name\u003d\"p-903500-version-01-2\" class\u003d\"anchor\" href\u003d\"#p-903500-version-01-2\"\u003e\u003c/a\u003eVersion 0.1\u003c/h3\u003e\n\u003cul\u003e\n\u003cli\u003einitial release\u003c/li\u003e\n\u003c/ul\u003e\n\u003ch2\u003e\u003ca name\u003d\"p-903500-resources-3\" class\u003d\"anchor\" href\u003d\"#p-903500-resources-3\"\u003e\u003c/a\u003eResources\u003c/h2\u003e\n\u003cul\u003e\n\u003cli\u003eBundle: \u003ca href\u003d\"https://github.com/nemerdaud/openhab-thinq-stuff/raw/main/org.openhab.binding.lgthinq-4.3.0-SNAPSHOT.jar\" rel\u003d\"noopener nofollow ugc\"\u003ehttps://github.com/nemerdaud/openhab-thinq-stuff/raw/main/org.openhab.binding.lgthinq-4.3.0-SNAPSHOT.jar\u003c/a\u003e\u003c/li\u003e\n\u003cli\u003eSource code: \u003ca href\u003d\"https://github.com/nemerdaud/openhab-addons/tree/feature/lgthinq-binding/bundles/org.openhab.binding.lgthinq\" class\u003d\"inline-onebox\" rel\u003d\"noopener nofollow ugc\"\u003eopenhab-addons/bundles/org.openhab.binding.lgthinq at feature/lgthinq-binding · nemerdaud/openhab-addons · GitHub\u003c/a\u003e\u003c/li\u003e\n\u003c/ul\u003e",
    "configDescriptionURI": "",
    "keywords": "",
    "countries": [],
    "connection": "",
    "properties": {
        "jar_download_url": "https://github.com/nemerdaud/openhab-thinq-stuff/raw/main/org.openhab.binding.lgthinq-4.3.0-SNAPSHOT.jar",
        "like_count": 3.0,
        "updated_at": "2024-09-06T10:40:38.178Z",
        "created_at": "2024-09-06T10:39:56.074Z",
        "views": 38.0,
        "posts_count": 1.0,
        "tags": [
            "binding",
            "published",
            "beta"
        ]
    },
    "loggerPackages": []
}

florian-h05 · September 12, 2024, 3:49pm

This is exactly what I was looking for, thanks … it confirms my assumption that this is no UI problem but a core problem.
Both configDescriptionURI and loggerPackages are empty, so for the UI there is nothing to show.

I have no experience with the core part of the add-on store, probably consider to ping Jan if there is an issue.

hmerk · September 12, 2024, 4:03pm

@florian-h05 Thanks, will do…