Denon binding for DRA-100 - amend exisitng or make a new binding?

laursen · April 8, 2023, 8:16am

If you mean that the options listed here:

openhab/openhab-addons/blob/70a9f463edb24e7520cc88eba959a8f73845b54f/bundles/org.openhab.binding.denonmarantz/src/main/resources/OH-INF/thing/thing-types.xml#L154-L202


      
          	<channel-type id="input">
          		<item-type>String</item-type>
          		<label>Input Source</label>
          		<description>Select the input source for this zone of the AVR</description>
          		<state>
          			<options>
          				<option value="DVD">DVD</option>
          				<option value="BD">BD</option>
          				<option value="TV">TV</option>
          				<option value="SAT/CBL">SAT/CBL</option>
          				<option value="SAT">SAT</option>
          				<option value="MPLAY">MPLAY</option>
          				<option value="VCR">VCR</option>
          				<option value="GAME">GAME</option>
          				<option value="V.AUX">V.AUX</option>
          				<option value="TUNER">TUNER</option>
          				<option value="HDRADIO">HDRADIO</option>
          				<option value="SIRIUS">SIRIUS</option>
          				<option value="SPOTIFY">SPOTIFY</option>
          				<option value="SIRIUSXM">SIRIUSXM</option>

This file has been truncated. show original

lacks BLUETOOTH, COAXIAL, DIGITALIN1, DIGITALIN2, ANALOGIN, ANALOGIN2 - then I think you should just add it to this list, which is already a list of all possible input sources across all models (and evens brands).

Filtering this list should be done outside the binding, at least with the current design. I have not read the source code, so there is a chance I’m missing something, for example if the binding would dynamically manipulate this list based on detected model from the MAC address, but I wouldn’t think so.