Group switch not updating

rossko57 · December 17, 2019, 5:11pm

Off the wall suggestion, based on assumed iterative calculation of Group state (maybe only for OR function even)
When a member changes, it fires a process to step through all candidate members, first setting the group state to the default. If there’s no match to the OR condition, it stays default. If there is match, it changes again.

Seems mad but this behaviour can be deduced from rule trigger firings.

I’d guess the first change event i.e. from NULL to X, is suppressed.

ysc · December 17, 2019, 5:28pm

You might be onto something.

Fun fact, there seems to be some test cases for this scenario here:

github.com

openhab/openhab-core/blob/12e8edc03931ded800af688b04d826d2fda0bd2c/itests/org.openhab.core.tests/src/main/java/org/eclipse/smarthome/core/items/GroupItemOSGiTest.java#L418


    assertTrue(change.getOldItemState().equals(oldGroupState));


    events.clear();


    // State doesn't change -> no events are fired
    member.setState(member.getState());
    assertThat(events.size(), is(0));
}


@Test
public void assertThatGroupItemChangesRespectGroupFunctionOR() {
    events.clear();
    GroupItem groupItem = new GroupItem("root", new SwitchItem("mySwitch"),
            new ArithmeticGroupFunction.Or(OnOffType.ON, OnOffType.OFF));
    groupItem.setItemStateConverter(itemStateConverter);


    SwitchItem sw1 = new SwitchItem("switch1");
    SwitchItem sw2 = new SwitchItem("switch2");
    groupItem.addMember(sw1);
    groupItem.addMember(sw2);

github.com

openhab/openhab-core/blob/12e8edc03931ded800af688b04d826d2fda0bd2c/itests/org.openhab.core.tests/src/main/java/org/eclipse/smarthome/core/items/GroupItemOSGiTest.java#L450


    GroupItemStateChangedEvent change = (GroupItemStateChangedEvent) changes.get(0);
    assertTrue(change.getItemName().equals(groupItem.getName()));


    assertTrue(change.getOldItemState().equals(UnDefType.NULL));
    assertTrue(change.getItemState().equals(OnOffType.ON));


    assertTrue(groupItem.getState().equals(OnOffType.ON));
}


@Test
public void assertThatGroupItemChangesRespectGroupFunctionORwithUNDEF() throws InterruptedException {
    events.clear();
    GroupItem groupItem = new GroupItem("root", new SwitchItem("mySwitch"),
            new ArithmeticGroupFunction.Or(OnOffType.ON, OnOffType.OFF));
    groupItem.setItemStateConverter(itemStateConverter);


    SwitchItem sw1 = new SwitchItem("switch1");
    SwitchItem sw2 = new SwitchItem("switch2");
    groupItem.addMember(sw1);
    groupItem.addMember(sw2);

cweitkamp · December 18, 2019, 11:11am

That is correct.

@ysc I can confirm your observations. Did it myself in a test setup. This leaded me to another question I wanted to test: Which event will we see when we have a group containing only one member:

Group:Switch:OR(ON,OFF) gTESTSWITCHES1 "Test Switches 1"
Switch testSwitch1 "Test Switch 1" (gTESTSWITCHES1)

Initial situation: state of Switch and Group are both ON.

1st try: Sending OFF to Switch:

openhab> smarthome:send testSwitch1 OFF
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES1/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"GroupItemStateChangedEvent"}

working

2nd try: Sending ON to Switch:

openhab> smarthome:send testSwitch1 ON
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES1/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"GroupItemStateChangedEvent"}

again working

3rd try: Sending OFF to Group:

openhab> smarthome:send gTESTSWITCHES1 OFF
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

Outch, failing - GroupItemStateChangedEvent is missing.

4th try: Sending ON to Group:

openhab> smarthome:send gTESTSWITCHES1 ON
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

Outch, again failing - GroupItemStateChangedEvent is missing.

I did the same tests with a group containing two members. ~~Ping me if you ate interested in the results.~~ // EDIT: I added them below. They reflect your findings.

Summary

Group:Switch:OR(ON,OFF) gTESTSWITCHES2 "Test Switches 2"
Switch testSwitch1 "Test Switch 1" (gTESTSWITCHES2)
Switch testSwitch2 "Test Switch 2" (gTESTSWITCHES2)

Initial situation: state of both Switches and Group are ON.

1st try: Sending OFF to Switch 1 and Switch 2:

openhab> smarthome:send testSwitch1 OFF
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

openhab> smarthome:send testSwitch2 OFF
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch2/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES2/testSwitch2/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"GroupItemStateChangedEvent"}

working

2nd try: Sending ON to Switch 1 and Switch 2:

openhab> smarthome:send testSwitch1 ON
Command has been sent successfully.

data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES2/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"GroupItemStateChangedEvent"}

openhab> smarthome:send testSwitch2 ON
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch2/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

working

3rd try: Sending OFF to Group:

openhab> smarthome:send gTESTSWITCHES2 OFF
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES2/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"GroupItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES2/testSwitch2/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"GroupItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/testSwitch2/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

Outch - two GroupItemStateChangedEvents, one seem to be absolutely wrong - conurrency issue???

4th try: Sending ON to Group:

openhab> smarthome:send gTESTSWITCHES2 ON
Command has been sent successfully.

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/testSwitch2/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

Outch - no GroupItemStateChangedEvent at all

IIRC the unit tests only handle updateState() on items. sendCommand() on groups is NOT covered!

Conclusion: First of all forget about my suggestion to trigger an ItemStateChangedEvent. We do not need it. There is something wrong with the calculation at which time a GroupItemStateChangedEvent will be emitted. Lets open an issue on Issues · openhab/openhab-core · GitHub.

mjcumming · December 19, 2019, 1:41pm

I have noticed a similar problem -> items changing not generating a group event. I can fix it by editing the .items file and saving it which reloads the items. I haven’t had time to dive into this to definitely understand the problem. But, something has changed and events have gone missing…

rossko57 · December 29, 2019, 5:36pm

Revisiting this topic, that we never really never got to the bottom of.

On the face of it, that is a “dumb” thing to do. This Group’s state is calculated by an aggregation function. Sending a direct postUpdate to a Group is an abnormal usage. Having said that, it’s a meaningful test …

If we interpret
ItemStateChangedEvent
as meaning “I have been changed by a postUpdate”
(and I guess an update by binding should do this too)
and
GroupItemStateChangedEvent
as meaning “I have been changed by group member aggregation function only”
In other words, this is a “group” calculated event not an ordinary “real” event

Then Cristoph’s results look to be the intended behaviour ??

If we can establish what expected behaviour is, then we can pick out the unexpected “missing” events.

StevenVerburg · January 2, 2020, 11:52am

After upgrading to OH 2.5.0 I’m also experiencing the same behavior in HABPanel as stated in the initial post in this thread. After pressing on a group switch, the status in not updated until a page reload has been done. It worked flawlessly before on 2.4.0. Is there a workaround available? And did someone open an issue for this? I could not find any on GitHub (openhab/openhab-core). Thanks!

michalp · January 2, 2020, 6:06pm

Hi,

I just updated from 2.4 to 2.5 and have exactly this same problem.
I had no issues with this before upgrade to 2.5.
Would it be possible to revert only habpanel binding to 2.4? Or any other workaround?
Thanks!

PePe · January 7, 2020, 10:10pm

Hi,

same here on 2.5.
Without manual refresh group item sticks to one state and keeps posting same every time I toggle group switch.

Testing scenario:

Group ‘garaz_zew’ containing 3 items (bulbs)
starting state OFF

Test1
Test1 expected result:
When group swith toggled: Group item command = ON
Habpanel switch widget representing status ON
Test1 end result:
Group item received command ON - success
Habpanel item status not changed - fail

Test2
Test2 expected result:
When group swith toggled: Group item command = OFF
Habpanel switch widget representing status OFF
Test2 end result:
Group item received command OFF - fail
Habpanel item status not changed - fail

All of the next tryouts gives the same result. ItemCommandEvent keeps sending ON state every time the group swich toggle:

[ome.event.ItemCommandEvent] - Item ‘garaz_zew’ received command ON
[ome.event.ItemCommandEvent] - Item ‘Garaz_zew_S’ received command ON
[ome.event.ItemCommandEvent] - Item ‘Garaz_zew_P’ received command ON
[ome.event.ItemCommandEvent] - Item ‘Garaz_zew_L’ received command ON
[vent.ItemStateChangedEvent] - Garaz_zew_S changed from 0 to 100
[vent.ItemStateChangedEvent] - Garaz_zew_P changed from 0 to 100
[vent.ItemStateChangedEvent] - Garaz_zew_L changed from 0 to 100
[ome.event.ItemCommandEvent] - Item ‘garaz_zew’ received command ON
[ome.event.ItemCommandEvent] - Item ‘Garaz_zew_S’ received command ON
[ome.event.ItemCommandEvent] - Item ‘Garaz_zew_P’ received command ON
[ome.event.ItemCommandEvent] - Item ‘Garaz_zew_L’ received command ON

For non group items all works fine.

Any solution or workaround?

StevenVerburg · January 17, 2020, 1:45pm

Related reported issue can be found here on openhab/openhab-core:
Group switch update in HABPanel doesn’t work correct

ysc · January 17, 2020, 2:48pm

If you really need this fixed, you can do this as a workaround:

cd conf/html (or wherever the html folder of your configuration is)
git clone --depth 1 -b 2.5.x https://github.com/openhab/openhab-webui
edit openhab-webui/bundles/org.openhab.ui.habpanel/web/app/services/openhab.service.js and on line 168, change:
.../rest/events?topics=smarthome/items/*/statechanged,...
to
.../rest/events?topics=smarthome/items/*/state*,... (i.e. statechanged => state*)
This will make HABPanel react to “normally useless” ItemStateEvent (like it used to)
Access your custom version of HABPanel at
http://openhabip:8080/static/openhab-webui/bundles/org.openhab.ui.habpanel/web/
It should update the group states reliably because of the change made in 3.

StevenVerburg · January 18, 2020, 8:06pm

Great, this works!

cweitkamp · February 24, 2020, 5:04pm

I have some news on this topic. I guess I found something - at least a workaround. The trick seems to be the AutoUpdatePolicy (Thanks to #1330 (comment)). When I add autoupdate="false" to the Group the events will be emitted probably:

Group:Switch:OR(ON,OFF) gTESTSWITCHES1 "Test Switches 1" { autoupdate="false" }

Switch testSwitch1 "Test Switch 1" (gTESTSWITCHES1)

Initial situation: state of Switch and Group are both ON.

1st try: Sending OFF to Switch:

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES1/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"GroupItemStateChangedEvent"}

working

2nd try: Sending ON to Switch:

data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES1/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"GroupItemStateChangedEvent"}

working

3rd try: Sending OFF to Group:

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES1/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"OFF\",\"oldType\":\"OnOff\",\"oldValue\":\"ON\"}","type":"GroupItemStateChangedEvent"}

working

4th try: Sending ON to Group:

event: message
data: {"topic":"smarthome/items/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"ItemStateChangedEvent"}

event: message
data: {"topic":"smarthome/items/gTESTSWITCHES1/testSwitch1/statechanged","payload":"{\"type\":\"OnOff\",\"value\":\"ON\",\"oldType\":\"OnOff\",\"oldValue\":\"OFF\"}","type":"GroupItemStateChangedEvent"}

working

That is the good news. Now we have to discuss how we can archive the same behavior without adding autoupdate="false" to the Group.

rossko57 · February 24, 2020, 6:03pm

Wow. What is autoupdate even trying to do with a Group? It ought to ignore commands to Group types.

eikowagenknecht · April 9, 2020, 12:17pm

This apperently presents a agreat workaround, thank you very much for spending the time to figure that out. I just wasted some hours wondering what was going on with my HABPanel groups, but thanks to you they now update again. Should be properly fixed, though

Andrea_Viscovich · April 28, 2020, 1:58pm

I confirm, it was working on OH 2.4, with 2.5 the workaround is to set autoupdate=false in the group item. I lost more than a couple of hours to get it!
Andrea

Falk · June 6, 2020, 9:47am

I tried this with a “Sum” group but the item in habpanel does not update itself unless there is a reload. Group definition is

Group:Number:SUM				gFensterOffen	"offene Fenster [%d]"					<openwindow>	(B17)	{autoupdate="false"}

Version is OH2.5.5.

Any ideas?

Falk · June 6, 2020, 10:10am

Well, works with the workaround described by @ysc.

BigGeorgeTx · August 5, 2020, 1:02am

I am experiencing that problem where group switches are not updating.

I had presence detection with the network binding working for at least a month on 2.5.4. I noticed the detection had stopped working (don’t know if it coincided with implementing 2.5.5 because I didn’t check it at the time). I had also upgraded to 2.5.6, before I observed the problem with the group switch not updating.

I tried adding the autoupdate parameter described above, but it still doesn’t work.

Group:Switch:AND(OFF,ON) Presence_Sensors <present> { autoupdate="false" }

Today I updated to 2.5.7-1. I am running Openhabian on a Pi 4 B.

I am not using HABPanel.

Tuny · October 3, 2020, 7:03pm

I do also have the same problem running openHAB 2.5.9 on a raspberry 3. I think the autoupdate =“false” parameter is not the solution and I am not sure if the is a “offical” solution for the problem.

Did you try already workaroud described from @ysk already:

Not sure if this is still valid.

tombert · November 6, 2020, 11:04pm

Running into the same issue with openHAB 2.5.10-1

Need to reload the HabPanel page to get the group switch status correctly displayed.