I don’t think these kinds of accusations are helpful for anybody here. Again, as already stated above, I guess there must have been some misunderstandings and at least I am sorry, if this was the case. Again, for me the PR was work in progress and I didn’t see any progress since my last comment in July. Likewise, your RfC seemed stale since July as the raised concerns where never answered in any way. Why creating an RfC, but then ignoring the comments?
it is unfortunate that you would wait until now to offer your assistance.
I don’t know why you blame me although I was more or less the only one actively discussing your PRs and issues and suggesting solutions?
The only reason that there is not a Jython add-on in 2.5.9 is that you chose to put no effort into helping, but rather prevented it from being merged by not approving a simple naming convention
It seems we are going in circles here. I suggested a bundle name of org.openhab.automation.jythonscripting
and said that I am fine with any other speaking id instead of jythonscripting
, you mentioned org.openhab.automation.scriptenginefactoryjython
, but also said that you’d be fine to adopt any other id. So why is the bundle name in that PR today still org.openhab.automation.scriptenginefactory.jython
, which is not a valid one? All it takes is to refactor it to comply with the add-on naming convention of org.openhab.<addontype>.<id>
.
@wborn submitted a PR for a Groovy add-on just yesterday. Three hours later, it was approved
Well, it applied exactly what had been discussed on the Jython PR and it looked exactly how I expected the Jython PR to look like. And yes, it should be that easy: Just rename the bundle to org.openhab.automation.jythonscripting
(which imho now makes most sense to be inline with the JS and Groovy add-ons) and we should be good to merge.
I thought the reason OH was open source was so people were free to extend its functionality without the requirement it be included in the official repos.
Anybody is free to fork, modify and extend, but what is part of the official distro and is covered by the documentation also clearly resides in the official repositories.
So can we count on you to update https://github.com/openhab/openhab-addons/pull/7208 and get it merged for 3.0.0.M2?