In which packages should OH2 "actions" go?

action
binding
pushbullet
Tags: #<Tag:0x00007f51deccc220> #<Tag:0x00007f51deccc090> #<Tag:0x00007f51e4b5f7b0>

(Hakan Tandogan) #1

I’m porting my pushbullet binding to OH2, using the example provided by the mqtt binding.

So, which package should I choose ?

addons/actions/org.openhab.action.pushbullet 

or

addons/binding/org.openhab.binding.pushbullet

For the first package, one could argue that it is an “action”, and actions were also seperated in OH1. Also, actions differed from bindings inasmuch they were basically write-only with no feedback way to the core.

For the second package, one could argue that it might (additionally to the action) become a proper client of the Pushbullet service, thus providing input the the core.

I’m torn between the two choices, leaning towards the second one. The third option would be, of course, having both an “action” and a “binding” later on, but I believe this would confuse users…


(Rich Koshak) #2

I would vote for the latter. I believe the “actions are a part of the binding instead of something separate” style that is illustrated by the MQTT action is the preferred OH 2 approach. The old separate Action add-ons I think are going to go away.

But I’m not positive on all of this. @David_Graeff, @5iver, do either of you have opinions? IIRC the two of you were the ones discussing in another thread about moving the existing core Actions over to the new style.


(Scott Rushworth) #3

Core Actions are a bit different, but will be made accessible in the same way. David would be best for this, as he has the binding experience. There are a number of bindings using them though, so I suggest taking a look at where they have put them.


(David Graeff) #4

I would put them into the “bindings” directory, as at some point that artifact may become a full binding (i.e. gain a Thing handler factory).

Separating actions and bindings is not OH2 style as it looks like at the moment.


(Hakan Tandogan) #5

That’s the way I’ll go then.