Max binding: is temperature is set to 0 for a short while when updating set temperature

dominicdesu · May 28, 2016, 2:34pm

When I change the set temperature of a max! thermostat, the “is temperature” is set to 0 for a short while, after which it is set again to the actual value:

2016-05-28 16:24:54.489 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - Command queued id 7 (KEQ0911327-set_temp:16.5).
2016-05-28 16:24:54.494 [INFO ] [smarthome.event.ItemCommandEvent    ] - Item 'Thermostat_WZ_SetTemp' received command 16.5
2016-05-28 16:24:54.513 [INFO ] [ome.event.GroupItemStateChangedEvent] - Heating changed from 17 to 16.5 through ThermostatSetTemp
2016-05-28 16:24:54.517 [INFO ] [ome.event.GroupItemStateChangedEvent] - ThermostatSetTemp changed from 17 to 16.5 through Thermostat_WZ_SetTemp
2016-05-28 16:24:54.521 [INFO ] [marthome.event.ItemStateChangedEvent] - Thermostat_WZ_SetTemp changed from 17 to 16.5
2016-05-28 16:24:54.768 [WARN ] [.core.transform.TransformationHelper] - Cannot get service reference for transformation service of type MAP
2016-05-28 16:24:54.771 [WARN ] [ui.internal.items.ItemUIRegistryImpl] - couldn't transform value in label because transformationService of type 'MAP' is unavailable
2016-05-28 16:24:54.779 [WARN ] [.core.transform.TransformationHelper] - Cannot get service reference for transformation service of type MAP
2016-05-28 16:24:54.782 [WARN ] [ui.internal.items.ItemUIRegistryImpl] - couldn't transform value in label because transformationService of type 'MAP' is unavailable
2016-05-28 16:24:58.818 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - Command 7 (KEQ0911327-set_temp:16.5) sent to MAX! Cube at IP: 192.168.178.44
2016-05-28 16:24:58.820 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - Sending request #52 to MAX! Cube
2016-05-28 16:24:58.994 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - S message. Duty Cycle: 20, Free Memory Slots: 49
2016-05-28 16:25:18.135 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - Sending request #53 to MAX! Cube
2016-05-28 16:25:18.195 [DEBUG] [b.binding.max.internal.device.Device] - Device 0c6e44 (Thermostat): Actual Temperature : 22.8
2016-05-28 16:25:18.201 [DEBUG] [b.binding.max.internal.device.Device] - Device 054f9e (Shutter Contact): Status: Closed
2016-05-28 16:25:18.207 [DEBUG] [b.binding.max.internal.device.Device] - Device 0455a7 (Shutter Contact): Status: Closed
2016-05-28 16:25:18.212 [DEBUG] [b.binding.max.internal.device.Device] - Device 0b8419 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:25:18.217 [DEBUG] [b.binding.max.internal.device.Device] - Device 0b870c (Thermostat): Actual Temperature : 22.8
2016-05-28 16:25:18.221 [DEBUG] [b.binding.max.internal.device.Device] - Device 0ef192 (Shutter Contact): Status: Closed
2016-05-28 16:25:18.224 [DEBUG] [b.binding.max.internal.device.Device] - Device 054fa4 (Shutter Contact): Status: Closed
2016-05-28 16:25:18.228 [DEBUG] [b.binding.max.internal.device.Device] - Device 0c6e43 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:25:18.231 [DEBUG] [b.binding.max.internal.device.Device] - Device 041de6 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:25:18.238 [DEBUG] [x.internal.handler.MaxDevicesHandler] - MAX! Thermostat KEQ0911327 configuration update
2016-05-28 16:25:18.242 [WARN ] [mon.registry.AbstractManagedProvider] - Could not update element with key max:thermostat:KEQ0565677:WZThermostat in ManagedThingProvider, because it does not exists.
2016-05-28 16:25:18.246 [WARN ] [.core.thing.binding.BaseThingHandler] - Error while applying configuration changes: 'IllegalStateException: Could not update thing max:thermostat:KEQ0565677:WZThermostat. Most likely because it is read-only.' - reverting configuration changes on thing 'max:thermostat:KEQ0565677:WZThermostat'.
2016-05-28 16:25:18.255 [DEBUG] [x.internal.handler.MaxDevicesHandler] - Updating states of Thermostat  (KEQ0911327) id: max:thermostat:KEQ0565677:WZThermostat
2016-05-28 16:25:18.321 [INFO ] [marthome.event.ItemStateChangedEvent] - Thermostat_WZ_IsTemp changed from 22.8 to 0.0
2016-05-28 16:25:18.464 [WARN ] [.core.transform.TransformationHelper] - Cannot get service reference for transformation service of type MAP
2016-05-28 16:25:18.466 [WARN ] [ui.internal.items.ItemUIRegistryImpl] - couldn't transform value in label because transformationService of type 'MAP' is unavailable
2016-05-28 16:25:18.472 [WARN ] [.core.transform.TransformationHelper] - Cannot get service reference for transformation service of type MAP
2016-05-28 16:25:18.479 [WARN ] [ui.internal.items.ItemUIRegistryImpl] - couldn't transform value in label because transformationService of type 'MAP' is unavailable
2016-05-28 16:25:48.277 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - Sending request #54 to MAX! Cube
2016-05-28 16:25:48.296 [DEBUG] [b.binding.max.internal.device.Device] - Device 0c6e44 (Thermostat): Actual Temperature : 22.8
2016-05-28 16:25:48.299 [DEBUG] [b.binding.max.internal.device.Device] - Device 054f9e (Shutter Contact): Status: Closed
2016-05-28 16:25:48.303 [DEBUG] [b.binding.max.internal.device.Device] - Device 0455a7 (Shutter Contact): Status: Closed
2016-05-28 16:25:48.307 [DEBUG] [b.binding.max.internal.device.Device] - Device 0b8419 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:25:48.312 [DEBUG] [b.binding.max.internal.device.Device] - Device 0b870c (Thermostat): Actual Temperature : 22.8
2016-05-28 16:25:48.317 [DEBUG] [b.binding.max.internal.device.Device] - Device 0ef192 (Shutter Contact): Status: Closed
2016-05-28 16:25:48.321 [DEBUG] [b.binding.max.internal.device.Device] - Device 054fa4 (Shutter Contact): Status: Closed
2016-05-28 16:25:48.325 [DEBUG] [b.binding.max.internal.device.Device] - Device 0c6e43 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:25:48.329 [DEBUG] [b.binding.max.internal.device.Device] - Device 041de6 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:25:48.337 [DEBUG] [x.internal.handler.MaxDevicesHandler] - MAX! Thermostat KEQ0911327 configuration update
2016-05-28 16:25:48.341 [WARN ] [mon.registry.AbstractManagedProvider] - Could not update element with key max:thermostat:KEQ0565677:WZThermostat in ManagedThingProvider, because it does not exists.
2016-05-28 16:25:48.344 [WARN ] [.core.thing.binding.BaseThingHandler] - Error while applying configuration changes: 'IllegalStateException: Could not update thing max:thermostat:KEQ0565677:WZThermostat. Most likely because it is read-only.' - reverting configuration changes on thing 'max:thermostat:KEQ0565677:WZThermostat'.
2016-05-28 16:25:48.354 [DEBUG] [x.internal.handler.MaxDevicesHandler] - No changes for Thermostat  (KEQ0911327) id: max:thermostat:KEQ0565677:WZThermostat
2016-05-28 16:26:18.356 [DEBUG] [nternal.handler.MaxCubeBridgeHandler] - Sending request #55 to MAX! Cube
2016-05-28 16:26:18.397 [DEBUG] [b.binding.max.internal.device.Device] - Device 0c6e44 (Thermostat): Actual Temperature : 22.8
2016-05-28 16:26:18.401 [DEBUG] [b.binding.max.internal.device.Device] - Device 054f9e (Shutter Contact): Status: Closed
2016-05-28 16:26:18.403 [DEBUG] [b.binding.max.internal.device.Device] - Device 0455a7 (Shutter Contact): Status: Closed
2016-05-28 16:26:18.407 [DEBUG] [b.binding.max.internal.device.Device] - Device 0b8419 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:26:18.412 [DEBUG] [b.binding.max.internal.device.Device] - Device 0b870c (Thermostat): Actual Temperature : 22.8
2016-05-28 16:26:18.416 [DEBUG] [b.binding.max.internal.device.Device] - Device 0ef192 (Shutter Contact): Status: Closed
2016-05-28 16:26:18.419 [DEBUG] [b.binding.max.internal.device.Device] - Device 054fa4 (Shutter Contact): Status: Closed
2016-05-28 16:26:18.423 [DEBUG] [b.binding.max.internal.device.Device] - Device 0c6e43 (Thermostat): Actual Temperature : 22.8
2016-05-28 16:26:18.428 [DEBUG] [b.binding.max.internal.device.Device] - Device 041de6 (Thermostat): Actual Temperature : 0.0
2016-05-28 16:26:18.437 [DEBUG] [x.internal.handler.MaxDevicesHandler] - MAX! Thermostat KEQ0911327 configuration update
2016-05-28 16:26:18.440 [WARN ] [mon.registry.AbstractManagedProvider] - Could not update element with key max:thermostat:KEQ0565677:WZThermostat in ManagedThingProvider, because it does not exists.
2016-05-28 16:26:18.444 [WARN ] [.core.thing.binding.BaseThingHandler] - Error while applying configuration changes: 'IllegalStateException: Could not update thing max:thermostat:KEQ0565677:WZThermostat. Most likely because it is read-only.' - reverting configuration changes on thing 'max:thermostat:KEQ0565677:WZThermostat'.
2016-05-28 16:26:18.455 [DEBUG] [x.internal.handler.MaxDevicesHandler] - Updating states of Thermostat  (KEQ0911327) id: max:thermostat:KEQ0565677:WZThermostat
2016-05-28 16:26:18.536 [INFO ] [marthome.event.ItemStateChangedEvent] - Thermostat_WZ_IsTemp changed from 0.0 to 22.8

I don’t think it should be set to 0, even for a short while…
@marcel_verpaalen, any idea?

marcel_verpaalen · May 28, 2016, 10:51pm

No, not directly. Do you see actually the state being updated? As that should not happen…

github.com

openhab/openhab2-addons/blob/master/addons/binding/org.openhab.binding.max/src/main/java/org/openhab/binding/max/internal/handler/MaxDevicesHandler.java#L334


    return this.bridgeHandler;
}


@Override
public void handleCommand(ChannelUID channelUID, Command command) {
    MaxCubeBridgeHandler maxCubeBridge = getMaxCubeBridgeHandler();
    if (maxCubeBridge == null) {
        logger.warn("MAX! Cube LAN gateway bridge handler not found. Cannot handle command without bridge.");
        return;
    }
    if (command instanceof RefreshType) {
        forceRefresh = true;
        maxCubeBridge.handleCommand(channelUID, command);
        return;
    }
    if (maxDeviceSerial == null) {
        logger.warn("Serial number missing. Can't send command to device '{}'", getThing());
        return;
    }


    if (channelUID.getId().equals(CHANNEL_SETTEMP) || channelUID.getId().equals(CHANNEL_MODE)) {

For the rest… from the cube we get occasionally suing actual temp… indeed should not bappen but if it’s

marcel_verpaalen · May 29, 2016, 4:12am

Looking at your log once more… indeed seems like it sends the update. This should not happen, it is a bug.
Can you raise a issue in github for this.

dominicdesu · May 29, 2016, 1:27pm

Somebody beat me to it: https://github.com/openhab/openhab2-addons/issues/976
And yes, I can see changing the state in the UI to 0.0 before it changes back again to the actual value.

marcel_verpaalen · May 30, 2016, 3:25pm

Great… I already thought you had 2 usernames in github.
Cool, I’ll take a look and find out why it does the update while it shouldn’t do it

marcel_verpaalen · June 1, 2016, 3:36pm

@dominicdesu, the fix for this has been merged this afternoon.