My new binding PR was stucked

Tags: #<Tag:0x00007f61739ca410>

I am developing a new binding and created a PR for it.

but it stucked for long time waiting review.

should I do something or just wait for result ?

thanks a lot!

There is a large backlog so 16 days is not a long time before a review is done.

What you can do is make sure all files that are required to be modified are ok (like CODEOWNERS, bom/openhab-addons/pom.xml bundle/pom.xml). Make sure your code is clean (all demo code/text/dead code removed). Run maven on your project to see if it reports any warnings. Run spotless:apply. The better your code is the faster it can be reviewed.

1 Like