OH2 binding: accessing via HTTP - which library should be used?

Development Misc
1

Hello together,

is there a prefered way of HTTP based communication?

Whereas the org.apache.http.client.methods works fine within the eclipse IDE there seems to be trouble in the real life (on pi3) which can be avoided by using org.apache.commons.httpclient.methods combined with the appropriate lib included in the binding.

Any pointers appreciated & regards,
Guenther

2

what about using eclipse smarthome httputil in

org.eclipse.smarthome.io.net.http
3

Thx. This one looks good to me.

4

It’s still valid ? Referring to smarthome docs seems must use jetty client… Which to use at this moment ?

5

It is using jetty, just giving you a simplified interface.

6

so better it or apache http util or what else ?

7

Use it, as it uses jetty. Please don’t use any other http util.

8

ok .thanks !

9

Like @hmerk mentioned the preferred method is to use org.eclipse.smarthome.io.net.http.HttpUtil.

If for some reason you really need a HttpClient for advanced usage you can get a HttpClient by injecting the HttpClientFactory in your service class:

    private @NonNullByDefault({}) HttpClient httpClient;

    ...

    @Reference
    protected void setHttpClientFactory(HttpClientFactory httpClientFactory) {
        this.httpClient = httpClientFactory.getCommonHttpClient();
    }

    protected void unsetHttpClientFactory(HttpClientFactory httpClientFactory) {
        this.httpClient = null;
    }
10

@hilbrand
I was tying to use the above snipped, but Eclipse is (obviously) not liking the unset logic due to the notNullbydefault… Should we just ignore this unsetHttpClientFactory one
**Bug** : Store of null value into field MiIoHandlerFactory.httpClient annotated @Nonnull in org.openhab.binding.miio.internal.MiIoHandlerFactory.unsetHttpClientFactory(HttpClientFactory)

11

@marcel_verpaalen I tried this and didn’t see any errors.

12

Developing my first binding and my device needs a PATCH, but it seems that org.eclipse.smarthome.io.net.http (or at least my version of it??) doesn’t support PATCH.

I searched through the currently being developed HTTP binding 2.x and it also uses org.eclipse.jetty.http.HttpMethod which doesn’t support PATCH. It’s also indicated in the description in the config:

            <parameter name="commandMethod" type="text">
				<label>Command Method</label>
				<description>HTTP method (GET,POST, PUT) for sending commands.</description>
				<options>
					<option value="GET">GET</option>
					<option value="POST">POST</option>
					<option value="PUT">PUT</option>
				</options>
				<limitToOptions>true</limitToOptions>
				<default>GET</default>
				<advanced>true</advanced>
			</parameter>

Is the current state of PATCH that it’s still unavailable?

Thanks,
Mike