OH2 Z-Wave refactoring and testing... and SECURITY

[aradoorolesen (Anders Olesen)]

As a quick local work around I have changed to versionMax and versionMin in fibaro_fgsd002_00_000 and fgsd002_3_2.xml so that version 3.3 will use the original file. Then it works.

I would like to know if anybody has tried to add a fgsd002 version 3.3 with the latest development version (24th of July).

[chris (Chris Jackson)]

Please provide the XML file for your device - or some information on it. From a quick look at the database, I don’t see anything obviously wrong with the database that would cause this, and my suspicion is it’s something specific to your system with respect to the change in thing uid.

[aradoorolesen (Anders Olesen)]

These files are taken from the current org.openhab.binding.zwave-2.4.0-SNAPSHOT.jar (24th July)

fgsd002_3_2.xml (16.9 KB) Not working

fgsd002_0_0.xml (15.5 KB) Working

By the way, is org.openhab.binding.zwave-2.4.0-SNAPSHOT.jar (24th July) now build of the master branch? I guess it must be because the change adding fgsd002_3_2.xml has not been committed to the developement branch.

[Mihai_Badea]

@aradoorolesen

when I try to add them from the inbox using PaperUI, I get an "Error: 404 - Not found, and the smoke detectors just remains in the inbox. Nothing in the log files! Even when logging zwave debug.

I’m seeing this, but with some WALLC-S switches - running OH #1318 and zwave binding 2.4.0.201807242215.
I think these also got updated recently in the zwave database.
Here is the xml file:
network_f1e8718f__node_29.xml (14.2 KB)

EDIT:
Found some warning message in the log:

19:33:38.645 [WARN ] [ig.discovery.internal.PersistentInbox] - Cannot create thing. No binding found that supports creating a thing of type zwave:zwaveme_wallcs_00_000.

[sihui]

@Mihai_Badea

I think these also got updated recently in the zwave database.

Nope, three month ago:

https://www.cd-jackson.com/index.php/zwave/zwave-device-database/zwave-device-list/devicesummary/145

[chris (Chris Jackson)]

@aradoorolesen

These files are taken from the current org.openhab.binding.zwave-2.4.0-SNAPSHOT.jar (24th July)

These files are generated by the database - I can easily get them directly from the database, and I did a comparison on them earlier.

What I was after is the XML that OH generated for your device.

[aradoorolesen (Anders Olesen)]

If its the xml file in the zwave folder you want, then its not generated.

Here’s the DiscoveryResult:

org.eclipse.smarthome.config.discovery.DiscoveryResult.json (1.1 KB)

[T.H.S (Thomas)]

any changes with the Fibaro Door/Window Sensor 2 (FGDW-002) ?
I actually try the DevBinding 2.4.0 from 24th July - The Sensor give me a:

2018-07-26 21:38:41.464 [WARN ] [wave.discovery.ZWaveDiscoveryService] - NODE 4: Device discovery could not resolve to a thingType! Manufacturer data not known.

… now with 2.4.0 - Manufactrer data not known ?! … hm…

[chris (Chris Jackson)]

@T.H.S

Manufactrer data not known

This means that the binding hasn’t downloaded the manufacturer data from the device. You need to wake it up so it can initialise, or wait for it to wake up by itself (may take a few hours or a day or so - depending on how your system is configured).

[T.H.S (Thomas)]

okay - I´ll try. The FGDW-002 are battery powered, so this can be a reason.
Now with the 2.4.0 dev. binding - my zwave USB Stick are new named : “ZWave Plus USB Dongle”.
Is that correct ?

[chris (Chris Jackson)]

You don’t need to change the stick name - you can just ignore the autodetected version. It’s up to you.

[T.H.S (Thomas)]

thanks a lot !

[chris (Chris Jackson)]

@aradoorolesen

If its the xml file in the zwave folder you want, then its not generated.

Even stranger - you mean it creates the XML if you change the version in the XML, and it doesn’t otherwise? Except in special cases, the thing definition in the database will not impact the protocol layers.

You need to find out why it’s not creating the XML - use the debug logs.

[T.H.S (Thomas)]

okay, I wake up the device many times … no success.
You know this : (I get this every time I click on an thing in habmin)

2018-07-26 22:31:30.615 [ERROR] [e.internal.WriterInterceptorExecutor] - MessageBodyWriter not found for media type=text/plain, type=class java.util.Collections$UnmodifiableCollection, genericType=class java.util.Collections$UnmodifiableCollection.

[chris (Chris Jackson)]

This is a bug in ESH - it was fixed a month or two back - please ensure you have the latest runtime.

[T.H.S (Thomas)]

thx. I will search how to update this.

[chris (Chris Jackson)]

You just need to use the latest snapshot of openhab. I forget if this issue was fixed in 2.3 or if you need 2.4. I’ll see if I can find the PR.

[T.H.S (Thomas)]

i´m using 2.3 - so as you said this must be fixed with 2.4

[chris (Chris Jackson)]

It’s this PR -:

use media type json for thing's config status REST response

[aradoorolesen (Anders Olesen)]

@chris

@aradoorolesen

If its the xml file in the zwave folder you want, then its not generated.

Even stranger - you mean it creates the XML if you change the version in the XML, and it doesn’t otherwise? Except in special cases, the thing definition in the database will not impact the protocol layers.

You need to find out why it’s not creating the XML - use the debug logs.

Yes if I change the versionMax and versionMin in the two definition files so the original will be used, then it works just fine.

As mentioned earlier, I dont get anything in the logs even if I set debug log level on zwave. Is there anything else I need to set log level on?