OutOfMemoryError (Java heap space) after a few days of running openHAB2

wborn · September 29, 2018, 4:01pm

Looks like all your memory is being eaten by SSE Sitemap subscriptions. I suggest updating to the latest 2.4.0 Milestone or SNAPSHOT build.

It has a fix for releasing sitemap subscriptions:

Do you think your fix will also fix this memory leak @Lolodomo?

There’s also another ESH issue about this:

github.com/eclipse-archived/smarthome

Leak (or excessive memory usage) in SitemapResource

opened 01:34AM - 31 Jan 18 UTC

closed 06:38AM - 12 Jun 18 UTC

sebmarchand

bug UI

(This is a continuation of the discussion on this OpenHab issue: https://communi…ty.openhab.org/t/sitemap-causing-oom/38936/10) **Summary**: It looks like there's no restriction on how many objects [SitemapResource::eventOutputs](https://github.com/eclipse/smarthome/blob/dcef6131b70c231a604b4beec5dc9e1769fbb88f/bundles/io/org.eclipse.smarthome.io.rest.sitemap/src/main/java/org/eclipse/smarthome/io/rest/sitemap/internal/SitemapResource.java#L130) can contain and this can easily lead to an OOM. **Details**: If I keep OpenHab2's BasicUI open in my browser for a long period of time (e.g. overnight) this will likely lead to an OOM crash, I've investigated a bit on this and the heap dump I got seem to point to [SitemapResource::eventOutputs](https://github.com/eclipse/smarthome/blob/dcef6131b70c231a604b4beec5dc9e1769fbb88f/bundles/io/org.eclipse.smarthome.io.rest.sitemap/src/main/java/org/eclipse/smarthome/io/rest/sitemap/internal/SitemapResource.java#L130). Here's some information from the heap dump analysis: Problem Suspect (as provided by Memory Analyzer): > One instance of "org.eclipse.smarthome.io.rest.sitemap.internal.SitemapResource" loaded by "org.eclipse.smarthome.io.rest.sitemap" occupies 893,758,768 (89.71%) bytes. The memory is accumulated in one instance of "org.eclipse.smarthome.io.rest.sitemap.internal.SitemapResource" loaded by "org.eclipse.smarthome.io.rest.sitemap". And here's the "Path to GC root" for this SitemapResource object: ``` Class Name | Shallow Heap | Retained Heap --------------------------------------------------------------------------------------------------------------------------------------------------- org.eclipse.smarthome.io.rest.sitemap.internal.SitemapResource @ 0xc45e1a88 | 48 | 893,758,768 '- m_implementationObject org.apache.felix.scr.impl.manager.ComponentContextImpl @ 0xc45e18a0 | 56 | 720 '- m_componentContext org.apache.felix.scr.impl.manager.SingleComponentManager @ 0xc45e0680 | 104 | 1,816 |- service org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl @ 0xc45e16d0 | 64 | 408 | '- [232] java.lang.Object[567] @ 0xc5fa49e8 | 2,288 | 2,288 | '- elementData java.util.ArrayList @ 0xc48317c0 | 24 | 2,312 | '- allPublishedServices org.eclipse.osgi.internal.serviceregistry.ServiceRegistry @ 0xc482d9b8 | 48 | 107,192 | |- serviceRegistry org.eclipse.osgi.internal.framework.EquinoxContainer @ 0xc43feec8 | 72 | 4,544 | | |- container org.eclipse.osgi.internal.url.URLStreamHandlerFactoryImpl @ 0xc44ced18 | 40 | 200 | | | '- factory class java.net.URL @ 0xc4306878 System Class | 32 | 864 | | |- equinoxContainer org.eclipse.osgi.internal.framework.EquinoxBundle$SystemBundle @ 0xc464bd88| 40 | 80 | | |- container org.eclipse.osgi.internal.url.ContentHandlerFactoryImpl @ 0xc48329c8 | 40 | 128 | | |- container org.eclipse.osgi.internal.framework.BundleContextImpl @ 0xc4ca9718 | 40 | 424 | | |- threadFactory java.util.concurrent.ScheduledThreadPoolExecutor @ 0xc464bcf8 | 80 | 528 | | |- equinoxContainer org.eclipse.osgi.internal.framework.EquinoxBundle @ 0xc4796458 | 32 | 48 | | |- equinoxContainer org.eclipse.osgi.internal.framework.EquinoxBundle @ 0xc47eef80 | 32 | 48 | | |- container org.eclipse.osgi.internal.framework.BundleContextImpl @ 0xc4f919d8 | 40 | 904 | | |- container org.eclipse.osgi.internal.loader.BundleLoader @ 0xd6457650 | 72 | 1,040 | | '- Total: 9 entries | | | |- registry org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl @ 0xc4cb3480 | 64 | 360 | |- registry org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl @ 0xc94d6988 | 64 | 376 | '- Total: 3 entries | | |- value java.util.HashMap$Node @ 0xc5c61730 | 32 | 56 '- Total: 2 entries | | --------------------------------------------------------------------------------------------------------------------------------------------------- ``` I think that the root cause of my problem has nothing to do with the SitemapResource , there shouldn't be so many event sent to it in the first place and I'll investigate on this separately, but it'd be nice if there was a way to make sure that this class can't cause this excessive memory usage. Thanks! Please let me know if there's anything I can share here to make it easier to debug this issue. I've tried looking at it but it's beyond my Java skills :)

With its own community thread: