PR for better error handling at device initialization

zwave
Tags: #<Tag:0x00007f51ddab3a70>

(Joan Pujol) #1

After turning me crazy repeating to infinity adding/removing/resetting in Fibaro Switch 2 FGS223 Not recognized I had gone to the source :slight_smile:

And I found the real problem. When the network key was asked I didn’t know it must be a hex one and I entered a string one that was magically converted to an incorrect hex key that throws an exception while it’s decoded.

The problem is that the inclusion stage is made in a thread that silently eats any exception.
Can I contribute with a PR that improves error handling at this stage?


(Mark) #2

@chris has always been open to PRs. But, please make sure you read and follow the contribution guidelines.


(Joan Pujol) #3

Ok, made at https://github.com/openhab/org.openhab.binding.zwave/pull/1122