Preparation for 2.5M2

puzzle-star · June 28, 2019, 1:37am

I opened an issue today (Issue #5770), as it seems the cloud service gets blocked when using the mobile app after PR #5631

The openhab cloud connector addon is not working properly to me since that PR, which removes the increase of maximum httpclient connections to a same destination for the instance used by the addon to connect to the local openhab’s rest API.

The change itself makes sense as since PR #5612 the connector is now using the common shared httpclient, so its parameters should not be changed. But this makes it allow only the “default” 2 maximum connections to the local rest api (which is a single destination), and this blocks the cloud connector.

So, as a summary, the cloud addon does not really work with, at least, the android app, which requests a long rest “event” subscription: one client works (slowly) till you start navigating through the sitemap, and at that moment it blocks and fails. Two clients at the same time block the cloud connector directly.

5iver · June 28, 2019, 2:22am

The reason I made the OP a wiki post was so that people could add/edit the things they felt were holding up the release (hint hint ).

puzzle-star · June 28, 2019, 8:26am

Assuming the OP is somewhere I could list this issue in, I will be happy to do it… as soon as I know where / how to do it…

Maybe the answer is obvious, but I looked into the project you created and I cannot see how to add / edit anything there (or maybe it is no there?)

5iver · June 28, 2019, 8:28am

Click the edit button on the first post of this topic.

puzzle-star · June 28, 2019, 1:27pm

Done! So I assume “OP” means “Original Post” ?

bjoernbrings · June 28, 2019, 4:32pm

This discussion seems to me getting far away from a “Monthly” () release but more in the direction of a stable release. Why not do the monthly release when #5503 is solved.

There will be many more bugs but we need to get the features out to the people to get the bugs found to be able to work towards a stable release …

Kai · June 28, 2019, 8:50pm

No worries @bjoernbrings, the openhab-cloud connector issue is already fixed, so it won’t delay any milestone builds .

bjoernbrings · June 28, 2019, 9:36pm

Perfect. And I saw you responding on #5503, so it seems we are getting there

morph166955 · July 1, 2019, 2:30pm

@cweitkamp Thank you for opening the bug directly. I just saw your post on this.

bjoernbrings · July 4, 2019, 5:13pm

So #5503 is solved. Ready for Milestone?

J-N-K · July 4, 2019, 5:54pm

It seems there is still something missing, reports are that the Snapshot doesn‘t work but for me locally build bundles do.

I can check that this weekend.

bjoernbrings · July 4, 2019, 8:50pm

Just updated to snapshot 1630 without any issues

Bruce_Osborne · July 4, 2019, 9:00pm

I updated too because I was on an older snapshot with the broken cloud. It works now.

morph166955 · July 7, 2019, 2:48am

@cweitkamp I do not believe that the issue (897) was fixed. I upgraded to 1633 and now my visibility is completely ignored (where it used to be processed but had to be manually refreshed before). While I don’t get the error, visibility is totally ignored. Everything shows up no matter what is selected.

EDIT: The problem only seems to show itself on the beta version of the app. The non beta app seems to work.

cweitkamp · July 8, 2019, 6:25am

@morph166955 My test setup for Basic UI (see https://github.com/openhab/openhab-core/issues/897) now (build OH 2.5.S1634) is working without any error message. Do you think it could be an issue with the App? AFAIK there was a recent change of the handling for invisible widgets (see https://github.com/openhab/openhab-android/pull/1174#).

Andrew_Rowe · July 10, 2019, 3:12am

So… are we ready to fire up ?
Build system sorted?

marcel_erkel · July 10, 2019, 5:25am

There are 16 items on the list in the opening topic, 7 of which are still open. What do you think?

marcel_erkel · July 10, 2019, 5:30am

Is there any way that a binding can be marked as experimental?

bjoernbrings · July 10, 2019, 6:50am

Hope you read those threads before offending anyone …
Its not the goal to solve all problems before releasing a milestone but those that affect many users. The bugs which have been named during duscussion are all solved.

So the question regarding what is missing to get the milestone out is quite valid.

marcel_erkel · July 10, 2019, 7:37am

I hope you read those threads too

openHAB Milestone builds

So the first step for which we use our new ability is to provide milestone releases from now on. The plan is to have roughly one milestone release per month. They are meant to be a pretty good compromise between the nightly snapshots and the official releases. I know that many of you are using snapshots even for their production system (me included) and you continuously run the risk that you catch a snapshot that completely breaks your system. Waiting for a new release is no option either, if you want to use new features that only recently made it into the code base. With the new milestone builds, we will make sure that those builds work in general and that they should not have any (known) critical issues. They should therefore be a nice option if you want to be on the latest&greatest, but want to avoid the risks that are associated with snapshots builds.

(Bold by me)

Yes, the idea is that milestone builds are released roughly each month and we all know why that process has stalled.
More importantly though, they should not have any (known) critical issues.

(Strike-through by me; these issues have been fixed)

I’m sorry that I value the opinion of those who contribute to the code higher than the opinion of the ones that don’t.

Patience is a virtue.