Problem with Anel HUT in latest snapshot (openHAB 2.4.0 Build #1399)

Add-ons Bindings
21

yeah, a sh!t load :slight_smile: (dns, ntp, dhcp, many other using UDP sockets)

i use a mid-range Laptop to run Debian and everything I need on it

22

what is strange about being a binding problem, is that it started with 1.3 and I did not have it with 1.2

23

I ran it both with sudo and without sudo, same reply

24

you may have another issue also that could affect the binding performance…

I don’t like this:

Low configured threads: (max=8 - required=1)=7

you may be running out of resources (for some reason) and this could cause UDP leak (I am just guessing)

25

check this: "Low configured threads" warning

26

I did not have that warning today.
I’m trying to follow what needs to be done for that.

y

1 Like
27

@paphko do you have any idea what could case this error?
Before I file a bug for this, I prefer to know a little more. Did you ever have this error?

28

I made a change for the threads, yet at 22:55 tonight I had again a

22:55:02.636 [ERROR] [ing.anel.internal.AnelConnectorThread] - Error occurred when sending UDP data to Anel device: 'wer da?'
java.lang.Exception: java.net.SocketException: maximum number of DatagramSockets reached
	at org.openhab.binding.anel.internal.AnelUDPConnector.sendDatagram(AnelUDPConnector.java:140) ~[230:org.openhab.binding.anel:1.13.0.M5]
	at org.openhab.binding.anel.internal.AnelConnectorThread.requestRefresh(AnelConnectorThread.java:208) [230:org.openhab.binding.anel:1.13.0.M5]
	at org.openhab.binding.anel.internal.AnelBinding.refreshAll(AnelBinding.java:149) [230:org.openhab.binding.anel:1.13.0.M5]
	at org.openhab.binding.anel.internal.AnelBinding.execute(AnelBinding.java:140) [230:org.openhab.binding.anel:1.13.0.M5]
	at org.openhab.core.binding.AbstractActiveBinding$BindingActiveService.execute(AbstractActiveBinding.java:144) [195:org.openhab.core.compat1x:2.4.0.M5]
	at org.openhab.core.service.AbstractActiveService$RefreshThread.run(AbstractActiveService.java:166) [195:org.openhab.core.compat1x:2.4.0.M5]
Caused by: java.net.SocketException: maximum number of DatagramSockets reached
	at sun.net.ResourceManager.beforeUdpCreate(ResourceManager.java:73) ~[?:?]
	at java.net.AbstractPlainDatagramSocketImpl.create(AbstractPlainDatagramSocketImpl.java:77) ~[?:?]
	at java.net.DatagramSocket.createImpl(DatagramSocket.java:337) ~[?:?]
	at java.net.DatagramSocket.<init>(DatagramSocket.java:239) ~[?:?]
	at java.net.DatagramSocket.<init>(DatagramSocket.java:196) ~[?:?]
	at org.openhab.binding.anel.internal.AnelUDPConnector.sendDatagram(AnelUDPConnector.java:136) ~[?:?]
	... 5 more
29

how come this shows M5?
I thought that you are on Snapshots
can you try to upgrade to M6?
I don’t think that it will solve your problem but you never know
this smells like a UDP Socket Leak on behalf of the Anel binding

30

Open an Issue, put a bounty on it and ask other developers with experience in UDP Socket handling from other bindings (or general Java) to look into the way the binding creates and tears down UDP Sockets using its connector.

31

yes I’m on M5.

I did not have time to upgrade this weekend. With exams coming up for the kids, I’m not sure I will the next weekends.
Like I said, it started when Openhab swapped the addon’s from 1.2 to 1.3
I did not see any UDP changes in the M6.

32

I doubt that there are any. In my opinion, the root cause is the way that the binding handles UDP connections.
This part of the binding code has not been updated for 3 years now :slight_smile: (of course, if the code was optimized, you wouldn’t need to update it)
there was only a small update to it to remove plain text passwords logging

33

there was only a small update to it to remove plain text passwords logging

I saw that, they did miss some passwords logging, I filed a bug for that today.

The fact that I get a

“wer da?”

worries me, as that sounds like something that the developer had no idea when something happened.

34

Well… we do have to respect that he sat down 4 years ago and build something for the community
It is a pitty that no-one else followed on his foot steps to further develop, maintain and enhance the Anel binding :frowning:

1 Like
35

Sorry that I did not see this issue earlier!
I still use the binding and it works without any issues in my setup (OH 2.3).
My time is currently limited, but @Dim is right: maybe someone can review the socket connection code, I’m not an expert for that part…

The “wer da?”, however, belongs to the API of the Anel devices. It means “who is there?” and lets all Anel devices respond with a brief status message.

1 Like
36

thanks.

I did make a proposal on github some time ago for removing of more password code.
I did that just by browsing the code, not by building it. (I don’t have any java editor on my machine)

I hope someone wants to check these in the future.
As passwords in logging is not secure…

I have +20 anel huts and I’m really happy with the binding.

Patrick did you see the discussions on OH3.0 and possibility of 1.x binding being removed in the future?

37

Please post links to these issues / pull requests, then I can have a look at them.

No, I did not read anything about OH3 plans yet…

38

Password in logs

Error message about wrong password