Problem with new Xiongmaitech / XM Camera binding

Sascha_ · August 15, 2021, 3:02pm

Hi all,

I’ve struggled the last hours to put together a basic binding for use with cheap mass-deployed ip cameras based on XMEye SDK.

The current state is:

supported things are automatically discovered and added to the inbox
upon successful login, device properties (like mac address, firmware etc.) are available to the thing

My problem / need for help:
I’m not a java guy, so the code quality sucks
But that’s up to a review - currently, I’m trying to add a sound playback channel to an IP camera but without success.

My approach is to translate janglapuk’s python code to java:

github.com

janglapuk/xiongmai-cam-api/blob/master/xmcam.py

import sys, time
import xmconst
import json, os, subprocess, socket
from struct import pack, unpack
from pprint import pprint, pformat

if sys.version_info[0] == 2:
    from threading import _Timer as Timer
else:
    from threading import Timer

class RepeatingTimer(Timer):
    def run(self):
        while not self.finished.is_set():
            self.function(*self.args, **self.kwargs)
            self.finished.wait(self.interval)

class XMCam:
    instance = None
    main_socket = None

This file has been truncated. show original

When trying to play back audio, I’m using a known-good pcm file and try to send it. However, chunking it and sending does not work and hangs the java thread. Any clues from the experts on this in which direction I could take a look?

The problematic function is PlaySound:

github.com

cribskip/openhab-addons/blob/e020c1418341f02cd1fb987a465697fef755a3d5/bundles/org.openhab.binding.xmcamera/src/main/java/org/openhab/binding/xmcamera/internal/XMCameraHandler.java#L288

    
      
          
          
    if (heartbeat != null) {
                  logger.debug("Cancelling heartbeat job");
                  heartbeat.cancel(true);
                  this.heartbeat = null;
              } else {
                  logger.debug("Heartbeat was not active");
              }
          }
          
          
private void PlaySound() throws IOException {
              Socket s = null;
          
          
    try {
                  // Open file
                  // pcmdata = open(pcmfile, 'rb').read()
                  Path path = Paths.get("/Users/sascha/doorbell.mp3.pcm");
                  // Path path = Paths.get("/Users/sascha/test");
                  byte[] raw = java.nio.file.Files.readAllBytes(path);
          
          
        // Read chunks

Next pithole will be to delay the disposal of the 2nd socket connection. How to delay a certain action (and access the needed objects there)?

Thanks for any clues and hints - I’m happy if I can give something back to OH when ready

Best,
Sascha