Rule for calculating the cost of electricity

[Vladimir40 (Владимир)]

Here is my rule
rule “PZEM_Energy_WH”
when
Time cron “0/45 * * * * ?” //каждые 45 сек
then
var Number KWh = PZEM_Energy_WH.state as DecimalType
var Number Kal
var Number Dif
var Number Pri

if (PZEM_Energy_WH.state instanceof DecimalType) {
    Kal = PZEM_Energy_WH.minimumSince(now.toDateMidnight.withDayOfMonth(1), "rrd4j").state as DecimalType //на начало месяца
    //Kal = (PZEM_Energy_WH.minimumSince(now.toDateMidnight.withDayOfMonth(1).withMonthOfYear(1), "rrd4j").state as DecimalType) //на начало года  //https://knx-user-forum.de/forum/supportforen/openhab/33557-anf%C3%A4nger
    postUpdate(PZEM_Energy_WH_Kalends, Kal.doubleValue )
   	Dif = KWh - Kal
   	postUpdate(PZEM_Energy_WH_Consumption, Dif.doubleValue )
   	Pri = Dif * 3.16 //3,16 рубля за кВт*ч
   	PZEM_Energy_WH_Consumption_Price.postUpdate(PZEM_Energy_WH_Consumption_Price, Pri.doubleValue )
   }

val CropDigital1 = String::format("%.2f", KWh.doubleValue ) //формат строки для sitemap
val CropDigital2 = String::format("%.2f", Dif.doubleValue ) //формат строки для sitemap	
postUpdate(PZEM_Energy_WH_general, CropDigital1 + " (" + CropDigital2 + " в тек.мес.)" )	   

end
it doesn’t work,what could be wrong with it

[rossko57]

@Vladimir40

it doesn’t work

??
Not even a little clue for us?

@Vladimir40

what could be wrong with it

You could try to find out.
Use logInfo()

Does your rule run at all?
Find out.
Are the values what you expect?
Find out.

Example

rule “PZEM_Energy_WH”
when
   Time cron “0/45 * * * * ?” //каждые 45 сек
then
   logInfo("test", "My rule has started")
   var Number KWh = PZEM_Energy_WH.state as DecimalType
   logInfo("test", "Variable KWh is {}", KWh)

   ... and so on

[Vladimir40 (Владимир)]

The logs are empty,most likely it does not start.

[Vladimir40 (Владимир)]

import org.openhab.core.library.types.*
import org.openhab.core.persistence.*
import org.openhab.model.script.actions.*
import org.joda.time.*

import java.lang.Math
import java.util.Calendar
import java.util.Date
import java.util.TimeZone
import java.text.SimpleDateFormat
import java.util.List //https://github.com/openhab/openhab/wiki/Actions#mail-actions
import java.util.Random

import java.lang.Double.*
import java.lang.String.*
maybe there’s something missing here

[rossko57]

Are you using openHAB version 1? It makes a difference. Most likely you do not want any imports at all.

[Vladimir40 (Владимир)]

openHAB version 3.2

[rossko57]

You do not want any imports at all.

Does your xxx.rules file get loaded? Your openhab.log will tell you at boot time and after each edit.

[Vladimir40 (Владимир)]

What kind of file, I have a lot of them for some reason. with respect

[Vladimir40 (Владимир)]

2021-07-16 16:32:48.198 [INFO ] [el.core.internal.ModelRepositoryImpl] - Loading model ‘Meteo.rules’
2021-07-16 16:32:48.269 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model ‘Meteo.rules’ has errors, therefore ignoring it: [55,45]: no viable alternative at input ‘Watermeter_Total’
[55,91]: mismatched input ‘)’ expecting ‘end’

[Vladimir40 (Владимир)]

2021-07-16 16:32:48.269 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model ‘Meteo.rules’ has errors, therefore ignoring it: [55,45]: no viable alternative at input ‘Watermeter_Total’
[55,91]: mismatched input ‘)’ expecting ‘end’

2021-07-16 16:42:28.587 [INFO ] [el.core.internal.ModelRepositoryImpl] - Loading model ‘PZEM_Energy_WH.rules’
2021-07-16 16:42:28.593 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model ‘PZEM_Energy_WH.rules’ is either empty or cannot be parsed correctly!
2021-07-16 16:42:29.595 [INFO ] [el.core.internal.ModelRepositoryImpl] - Loading model ‘PZEM_Energy_WH.rules’
2021-07-16 16:42:29.599 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model ‘PZEM_Energy_WH.rules’ is either empty or cannot be parsed correctly!
2021-07-16 16:42:53.817 [INFO ] [el.core.internal.ModelRepositoryImpl] - Loading model ‘PZEM_Energy_WH.rules’
2021-07-16 16:43:00.433 [INFO ] [org.openhab.core.model.script.test ] - My rule has started
2021-07-16 16:43:00.438 [INFO ] [org.openhab.core.model.script.test ] - Variable KWh is 440.43
2021-07-16 16:43:00.450 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘PZEM_Energy_WH-1’ failed: ‘toDateMidnight’ is not a member of ‘java.time.ZonedDateTime’; line 13, column 43, length 18 in PZEM_Energy_WH
2021-07-16 16:43:45.052 [INFO ] [org.openhab.core.model.script.test ] - My rule has started
2021-07-16 16:43:45.053 [INFO ] [org.openhab.core.model.script.test ] - Variable KWh is 440.43
2021-07-16 16:43:45.054 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘PZEM_Energy_WH-1’ failed: ‘toDateMidnight’ is not a member of ‘java.time.ZonedDateTime’; line 13, column 43, length 18 in PZEM_Energy_WH

[Vladimir40 (Владимир)]

I removed it tonight,it began to count for the beginning of the month, then
2021-07-16 16:57:00.050 [INFO ] [org.openhab.core.model.script.test ] - My rule has started
2021-07-16 16:57:00.051 [INFO ] [org.openhab.core.model.script.test ] - Variable KWh is 440.49
2021-07-16 16:57:00.052 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘PZEM_Energy_WH-1’ failed: ‘toDateMidnight’ is not a member of ‘java.time.ZonedDateTime’; line 13, column 43, length 18 in PZEM_Energy_WH
2021-07-16 16:57:00.586 [INFO ] [org.openhab.core.model.script.test ] - My rule has started
2021-07-16 16:57:00.587 [INFO ] [org.openhab.core.model.script.test ] - Variable KWh is 440.49

[Vladimir40 (Владимир)]

2021-07-16 17:06:00.359 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘PZEM_Energy_WH-1’ failed: An error occurred during the script execution: Could not invoke method: org.openhab.core.model.script.actions.BusEvent.postUpdate(org.openhab.core.items.Item,java.lang.String) on instance: null in PZEM_Energy_WH

[rossko57]

As you are using OH3, “now” is a zonedDateTime object and you will have to work with different methods to the OH2 rule that you copied.

DateTime Conversion (openHAB 3.x)

Because openHAB 2.x rules use Jodatime instead of Java Time API, there is still the old DateTime Conversion thread for openHAB 2.x. Overview In openHab 3.x there are different ways to handle Date/Time values. DateTimeType A DateTime Item carries a DateTimeType. Java Time By default openHAB 3.x Rules DSL use java.time API to represent date and time. Principle java date-time concepts are LocalDateTime (date and time without any offset or time-zone) and ZonedDateTime (“full” date-time wit…

[Vladimir40 (Владимир)]

is there any way to fix it for version 3?

[rossko57]

Yes. Example

Replacement for now.toDateMidnight in OH3?

After migration to OH3 a rule which used now.toDateMidnight stoped working: val max = TE_AAUS_M3.maximumSince(now.toDateMidnight) Although I searched a lot I could not find an equivalent replacement for this with ZonedDateTime. So far my best running solution is: val max = TE_AAUS_M3.maximumSince(now.minusHours(24)) But this is obviously not the same. Is there any equivalent to get start time of the actual day? Thank you for any help! EDIT: I am using Rules DSL

[Vladimir40 (Владимир)]

Does not count the cost, per hour and per day and in the current month for some reason, can you help solve this problem? Thank you in advance.

[Vladimir40 (Владимир)]

rule “PZEM_Energy_WH”
when
Time cron “0/45 * * * * ?” //каждые 45 сек
then
logInfo(“test”, “My rule has started”)
var Number KWh = PZEM_Energy_WH.state as DecimalType
logInfo(“test”, “Variable KWh is {}”, KWh)
var Number Kal
var Number Dif
var Number Pri

if (PZEM_Energy_WH.state instanceof DecimalType) {
    Kal = PZEM_Energy_WH.minimumSince(now.withDayOfMonth(1), "rrd4j").state as DecimalType //на начало месяца
    //Kal = (PZEM_Energy_WH.minimumSince(now.toDateMidnight.withDayOfMonth(1).withMonthOfYear(1), "rrd4j").state as DecimalType) //на начало года  //https://knx-user-forum.de/forum/supportforen/openhab/33557-anf%C3%A4nger
    postUpdate(PZEM_Energy_WH_Kalends, Kal.doubleValue )
   	Dif = KWh - Kal
   	postUpdate(PZEM_Energy_WH_Consumption, Dif.doubleValue )
   	Pri = Dif * 3.16 //3,16 рубля за кВт*ч
   	PZEM_Energy_WH_Consumption_Price.postUpdate(PZEM_Energy_WH_Consumption_Price, Pri.doubleValue )
   }

val CropDigital1 = String::format("%.2f", KWh.doubleValue ) //формат строки для sitemap
val CropDigital2 = String::format("%.2f", Dif.doubleValue ) //формат строки для sitemap	
postUpdate(PZEM_Energy_WH_general, CropDigital1 + " (" + CropDigital2 + " в тек.мес.)" )	   

end

[Vladimir40 (Владимир)]

2021-07-16 17:39:00.080 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘PZEM_Energy_WH-1’ failed: An error occurred during the script execution: Could not invoke method: org.openhab.core.model.script.actions.BusEvent.postUpdate(org.openhab.core.items.Item,java.lang.String) on instance: null in PZEM_Energy_WH
2021-07-16 17:39:00.330 [INFO ] [org.openhab.core.model.script.test ] - My rule has started

[Vladimir40 (Владимир)]

Thank you for your help,I set everything up,it worked.There is one question left,how can I send it to the mail now?