Rule not working after update to 2.5.6-2

[rlkoshak (Rich Koshak)]

@LordLiverpool

When you say timers, do you mean like cron jobs?

No, openHAB Timers created using createTimer: Actions | openHAB, in Jython see But How Do I…? — openHAB Helper Libraries documentation and for JavaScript you should be able to adapt Experimental Next-Gen Rules Engine Documentation 5 of : Actions (NOTE: that thread was written before there were Helper Libraries and written to show how to create Rules through PaperUI so not everything there may still be accurate).

@LordLiverpool

If there’s a problem with the rule, wouldn’t there be an error in the log?

JavaScript is lazily evaluated. Lots and lots of errors will never appear until the rule actually runs. I would expect to see an error if the trigger where incorrect though.

@LordLiverpool

Even when I execute the rule from PaperUI, I see “rule executed”, but no output. So it’s not just a timer thing.

The big problem when executing the rule from PaperUI is it doesn’t appear to get the scope. Consequently it doesn’t necessarily have access to logInfo, for example. Though you should usually see an error in the logs when that happens.

Maybe you need to enable the logs through. See step 3. at Installation — openHAB Helper Libraries documentation (you might need to click on the JavaScript tab).

@LordLiverpool

Wait a sec… has the required location for rules changed? What’s the path where they need to be placed?

$OH_CONF/automation/jsr223/javascript/personal

It’s in the right spot or else you wouldn’t see the “Loading script” log statement and it wouldn’t appear in your Rules menu in PaperUI.

[LordLiverpool (David Pritchard)]

Actually it isn’t. It’s in automation\jsr223.

[LordLiverpool (David Pritchard)]

I think the subfolders were added with the updated libraries.

[LordLiverpool (David Pritchard)]

You still get the “loading script” statement even if it’s in the parent directory. However, same outcome.

I did see the bit about logging but I assumed that whatever logging was operational by default before would still be. So I take it that’s not the case.

[LordLiverpool (David Pritchard)]

I can’t quite decipher the logging instructions. It talks about the Karaf console, and then about the configuration file, but I can’t see how to translate the Karaf console command into settings in the config file.

Perhaps something like:

log4j2.logger.jsr223.level = DEBUG

?

[LordLiverpool (David Pritchard)]

Yep. Found this post here:

[SOLVED] Jython Logging

Here you go. I also comment out the ‘Common pattern layout for appenders’ section at the top, so that I can see the full name of the loggers. log4j2.logger.RuleEngineImpl.name = org.eclipse.smarthome.model.rule.runtime.internal.engine.RuleEngineImpl log4j2.logger.RuleEngineImpl.level = DEBUG log4j2.logger.RuleEngineImpl.additivity = false log4j2.logger.RuleEngineImpl.appenderRefs = Rules log4j2.logger.RuleEngineImpl.appenderRef.Rules.ref = jsr223 log4j2.logger.jsr223.name = jsr223 log4j2.logg…

[LordLiverpool (David Pritchard)]

Bingo. I now get the logs and the rule is working. Many thanks.

[5iver (Scott Rushworth)]

If you’d put your topic anywhere other than Beginners, I probably would have seen it and could have helped out right away. I only got here after you linked to my post, but I’ve moved it now, as this definitely is not a beginner question!

Many things have been changed and added to the JavaScript helper libraries and I plan to do more to bring the functionality up to the level of the ones for Jython.

@LordLiverpool

I’m not really invested in anything right now, so I could go the Jython route if it’s going to be easier.

Considering just the helper libraries, definitely go with Jython! The JS libraries are better than they were, but are limited by the version of Nashorn supplied in JDK8. Eventually, we will have a newer versioin of JavaScript that is compatible with scripted automation. Considering just the scripting language, definitely go with Jython! JavaScript works well for websites, but it is pretty useless for automation. There is a small number of people who use JavaScript, so I do my best to support it and will continue to build out the JavaScript helper libraries. I am working on an addon for distributing the JavaScript helper libraries, as well as addons for Kotlin, Groovy and jRuby.

[LordLiverpool (David Pritchard)]

Yeah, using JS is swimming against the tide, although it would be the easiest for me right now. OK, so I’ll learn Python. I’ve never really used it except once years ago. Something new.

[5iver (Scott Rushworth)]

In case you have not seen these…

[beta testers wanted!] Jython addon w/ helper libraries (requires OH 2.5.x)

I just submitted a PR that adds a core feature for a JythonScriptEngineFactory and it would be great to have some testers! Basically, this will allow for the installation of Jython including the core and community helper libraries through Paper UI, once the PR is merged. If you’d like to test it, you’ll need to… Have OH 2.5.x (S1778) or newer Shutdown OH Backup OH Download the addon and copy to $OPENHAB_HOME/addons/ (see here for more details). The jar contains the core and community helper l…

https://openhab-scripters.github.io/openhab-helper-libraries/index.html

[LordLiverpool (David Pritchard)]

I’m not quite there yet! Maybe in a few weeks from now.