Rule troubles after OpenHAB update

Setup, Configuration and Use Scripts & Rules
1

I just updated from openhab-3.3.0-SNAPSHOT to openhab-3.4.0.M6 earlier today.

Everything is working fine besides one rule i’ve noticed. I get these warnings, and the updates/commands are not sent.


2022-12-16 00:23:00.466 [WARN ] [b.core.model.script.actions.BusEvent] - Cannot convert '1' to a state type which item 'HolidayLightsActive' accepts: [OnOffType, UnDefType].
2022-12-16 00:23:00.466 [WARN ] [b.core.model.script.actions.BusEvent] - Cannot convert '1' to a command type which item 'gHolidayLightsPower' accepts: [OnOffType, RefreshType].
2022-12-16 00:23:00.466 [WARN ] [b.core.model.script.actions.BusEvent] - Cannot convert '1' to a command type which item 'gChristmasLights' accepts: [OnOffType, RefreshType].
2022-12-16 00:23:00.466 [WARN ] [b.core.model.script.actions.BusEvent] - Cannot convert '1' to a command type which item 'gChristmasTreeLightsPower' accepts: [OnOffType, RefreshType].
2022-12-16 00:23:00.466 [WARN ] [b.core.model.script.actions.BusEvent] - Cannot convert '1' to a command type which item 'KitchenChristmasLights_Power' accepts: [OnOffType, RefreshType].
2022-12-16 00:23:00.466 [INFO ] [.model.script.HolidayLightsOH3.rules] - Turning off Holiday Lights at 1:30/40am.
2022-12-16 00:23:00.466 [INFO ] [.model.script.HolidayLightsOH3.rules] - Turning off Holiday Lights Master Power at 12:00/10am.
2022-12-16 00:30:00.446 [WARN ] [b.core.model.script.actions.BusEvent] - Cannot convert '1' to a state type which item 'HolidayLightsActive' accepts: [OnOffType, UnDefType].

Here are the items:


Switch						HolidayLightsActive					"Holiday Lights Active [%s]"				<led>					(gHolidayLights)			
Group:Switch:OR(ON, OFF)	gHolidayLightsPower					"Holiday Lights Power [%s]"					<led>					(gLEDOnOff)
Group:Switch:OR(ON, OFF)	gChristmasLights					"Christmas Lights [%s]"						<christmastree>			(gLights, gAlexa)						{alexa="Light"}
Color						ChristmasTreeLights_MasterControls	"Christmas Tree Lights Lights"  			<led>					(gChristmasTreeLights, gLEDOnOff, gChristmasTreeLightsPower, gAlexa)		{channel="remoteopenhab:server:192_168_2_37:ChristmasTreeLights_MasterControls", alexa="Light.Color,Light.PowerState,Light.Brightness"}
Group:Switch:OR(ON, OFF)	gChristmasTreeLightsPower			"Christmas Lights Power [%s]"				<led>					(gLEDOnOff, gChristmasLights)
Switch						KitchenChristmasLights_Power 		"Kitchen Christmas Lights [%s]" 			<christmastree> 		(gSonoff_OnOff, gChristmasLights, gAlexa)    {channel="mqtt:topic:MosquittoMqttBroker:KitchenChristmasLights:power", alexa="Switch"}

Here is the rule


rule "Holiday Lights OFF at 12:00/10 am"
when
  	Time cron "0 0,10,23 0 ? * * *"
then
	if (HolidayLightsOverride.state != ON && HolidayLightsOFFOverride.state != ON  && (gHolidayLightsPower.state!=OFF || gChristmasLights.state!=OFF || gChristmasTreeLightsPower.state!=OFF)){ 
		HolidayLightsActive.postUpdate(OFF)
		gHolidayLightsPower.sendCommand(OFF)
		gChristmasLights.sendCommand(OFF)
		gChristmasTreeLightsPower.sendCommand(OFF)
		ChristmasTreeLights_MasterControls.sendCommand(OFF)
		KitchenChristmasLights_Power.sendCommand(OFF)
		logInfo("HolidayLightsOH3.rules", "Turning off Holiday Lights at 1:30/40am.")
		if (HolidayLights_Power.state!=OFF){
			HolidayLights_Power.sendCommand(OFF)
			logInfo("HolidayLightsOH3.rules", "Turning off Holiday Lights Master Power at 12:00/10am.")
		}
	}
	else if (HolidayLightsOverride.state != ON && HolidayLightsOFFOverride.state != ON && HolidayLightsActive.state != OFF){
		HolidayLightsActive.postUpdate(OFF)
	}
end

I am unsure why this just stopped working. It was working fine in the last version. The Types are all switches (besides the ChristmasTreeLights_MasterControls, but that acceps ON and OFF commands to control it)

Any ideas whats going on?

Thanks.

2

Wow… Stupid coding mistake.

I added a Global Variables in the rule for my WLED’s and one was called OFF.

var Number OFF = 1

Don’t do that… I dont know why I did that one.

var Number PowerOFF = 1

Everything works fine how… whoops.