Rules DSL in 5.1 is now unloading rules if it has unreachable expressions?

Lolodomo · February 13, 2026, 4:49am

There was a change. All validation diagnostics were previously considered as warnings.

Now validation diagnostics returned with an ERROR flag are now considered as errors .

Made sense to us when it was changed.

Should we made an exception for rules? To be discussed.

@jimtng for information

github.com/openhab/openhab-core

DSL Items Parser: Fix incorrect parsing of keywords encountered in the wrong context

main ← jimtng:dsl-items-tags-parser

opened 12:32AM - 25 Jul 25 UTC

jimtng

+359 -169

When specifying tag names that match one of the valid item types, e.g. `Switch`,… the parser incorrectly treated it as a new start of an item definition. Fix #4927 ~~Consider backporting to 4.3.x~~ This is a bigger change than I originally thought, it shouldn't be backported Longer explanation: The standard way xtext parser / grammar deals with this is to prefix conflicting literals such as `Switch`, `AND`, `Group`, etc with a caret `^`. So even without this PR, this would work: ``` Switch Test1 [^Switch] ``` This PR makes this possible: ``` Switch Test1 [Switch] ``` See Copilot review for more details. Also "fixed": removed space in the generated DSL item format, from: ``` Group:Switch:OR (ON,OFF) Name ``` to ``` Group:Switch:OR(ON,OFF) Name // remove space before ( ``` Copilot Summary ## Pull Request Overview This PR fixes incorrect parsing of DSL items when keywords matching valid item types (like "Switch", "Group", etc.) are used in other contexts such as tag names. Previously, the parser would incorrectly treat these as new item definitions. * Simplifies the grammar by removing separate `ModelGroupItem` and `ModelNormalItem` types in favor of a unified `ModelItem` approach * Updates validation logic to properly validate item types, group functions, and dimensions with improved error messages * Refactors code generation to remove unnecessary space in group function syntax (e.g., `Group:Switch:OR(ON,OFF)` instead of `Group:Switch:OR (ON,OFF)`) ### Reviewed Changes Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments. Show a summary per file | File | Description | |--------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------| | bundles/org.openhab.core.model.item/src/org/openhab/core/model/Items.xtext | Unified grammar to support flexible item type parsing with up to 4 colon-separated segments | | bundles/org.openhab.core.model.item/src/org/openhab/core/model/item/internal/GenericItemProvider.java | Major refactor to handle unified item creation logic with improved group item parsing | | bundles/org.openhab.core.model.item/src/org/openhab/core/model/validation/ItemsValidator.xtend | Enhanced validation with comprehensive item type, group function, and dimension checking | | bundles/org.openhab.core/src/main/java/org/openhab/core/items/GroupFunction.java | Added constants for valid group functions to centralize function validation | | bundles/org.openhab.core/src/main/java/org/openhab/core/library/CoreItemFactory.java | Exposed valid item types as a public constant for validation use | | itests/org.openhab.core.model.item.tests/src/main/java/org/openhab/core/model/item/internal/GenericItemProviderTest.java | Added comprehensive tests for keyword parsing edge cases and group type syntax |