Hello! At this moment my rollershutters work like this: rule "Schatten Auto Azimuth" when Item Astro_Azimuth changed then val int az_foyer_mitte_up = 168 val int az_gang_mitte_up = 207 val int az_kueche_up = 202 val int az_wz_front_up = 207 val int az_foyer_rechts_…

Yes, please see the DRY DP to help reduce the lines of code a bit. But I have another comment. Avoid the use of primitives unless absolutely necessary. Even on a powerful machine, you can see .rules parsing and loading times in the minutes instead of single digit seconds caused only bu the use of p…

[image] narf27: i’m pretty shure i read something familiar in another topic but i can’t find the topic anymore Just a hint, for topics you may want to reference at a later time, use bookmarks. Click the three dots located in bottom right of post then select the bookmark symbol. Not sure what …

[image] H102: Just a hint, for topics you may want to reference at a later time, use bookmarks. Click the three dots located in bottom right of post then select the bookmark symbol. Not sure what the bookmark max is but I have a bunch and they help tons. Both for personal issues and helping othe…

Start with Design Pattern: How to Structure a Rule

i should probably find something helpful in the 1-2-3 section, right? 1 - i could check if Astro_Azimuth.state is bigger than 168 (smallest trigger value) and maybe check of some of the rs_auto items are “ON”? 2 - i still have to determine for every item what has to be done (don’t i?) 3 - send al…

Check to see if the role needs to run at all. If not return. Determine which items need which commands. Since your if statements to send the commands are all the same with the only difference being the item checked and the item commanded put that at the end just once instead of repeating it…

[image] rlkoshak: Check to see if the role needs to run at all. If not return. if Astro_Azimuth.state < 168 OR all items of group rs_auto = OFF then return ??? all other conditions are checked in the if statements (which i should put at the end) [image] rlkoshak: Determine which items…

i think i found a way to write the if statements to send the commands just once. (will post later, probably way to complex…) but i’d also like to work on this 1-2-3 approach. how can i know if there’s any item in my group that matches the condition “ON”? i tried the RULES DSL and i even got results…

[image] narf27: i couldn’t figure out how to know “if any item of group xx == ON then”… val numON = MyGroup.members.filter[itm | itm.state == ON].size if(size > 0){ // then } If you want to do something for all members of the Group that are ON MyGroup.members.filter[itm | itm.state == O…

openHAB Community

Same rule for different rooms

Setup, Configuration and Use Scripts & Rules

vzorglub (Vincent Regaud) November 1, 2019, 3:35pm 2

That’s a good start: Design Pattern: DRY, How Not to Repeat Yourself in Rules DSL