Say() can not say two or more phrases

thisisIO · November 3, 2019, 5:02pm

Hello,

The problem is if have two or more say() at once, for example

Say(“first phrase”)
Say(“second phrase”)
Say(“third phrase”)

It says only last one(((
There is a gong of first phrase and break, gong of second and break
At least the gong and it says last phrase complete.

What to do, to hear all three phrases completly?

If it means, i use google speak service.

Thanks.

vzorglub · November 3, 2019, 5:19pm

You need to wait for the first phrase to finish to start the next one

thisisIO · November 3, 2019, 5:21pm

U mean use delay? Timer or what is better way?

But if the phrase not the same and genetated dynamically?

vzorglub · November 3, 2019, 5:24pm

Timer is better

Good luck

thisisIO · November 3, 2019, 5:27pm

Hahaha)))
Thanks!

Really no way to make the trigger that first phrase was already said?

By the way - it the problem of google tts or OH global?

vzorglub · November 3, 2019, 5:35pm

Yes really

More OH. It has no way of knowing how long the phrase will last and there is no trigger back from the TTS to say “I am finished”

MDAR · November 3, 2019, 5:40pm

I have seen the same behaviour.

I’ve thought about waiting for the player state (my case a Chromecast Audio) to change back to Stop before issuing the next phrase.

I haven’t tried it yet, as I just compiled the phrases into 1 command (text string) instead.

For example,

Say(“first phrase”+". "+“second phrase"+". "+“third phrase”)

Or as an example

say("The outdoor temperature is "+outdoortemp.state+" degrees C and the wind speed is "+windspeed.state+" miles per hour")

mstehle · November 3, 2019, 5:54pm

Hi,

I have the same problem with say and sending TTS text to chromecast devices. Since I have different “sources” sending TTS text, combining text into one phrase was not an option for me.

I am using the following rule as a “workaround” which works very well for my purposes. I have shortened the rule (I have more in my rule), hopefully I have not introduced any errors…

I have two items:

Item TTSText: Send all Text for Text-to-speech to this item

The rule will introduce the delay based on the length of the text and send it to the second Item:

Item TTSText_Speaker: Item for say command

I had to introduce bQueueSpeakerError as failsafe. Sometimes there seems to be an error in the timer (I do not know why).
bQueueSpeakerError makes sure that the queue will be processed even if there is a timer exception. Probably not the most elegant way to do this but it works for me

Maybe you can try this. Hope this helps.

import java.util.concurrent.ConcurrentLinkedQueue

val ConcurrentLinkedQueue<String> queueSpeaker = new ConcurrentLinkedQueue()
var Timer timerSpeaker = null
var boolean bQueueSpeakerError = false

val int iTTSCharacterDelay = 120  // delay in ms per character
var boolean debug = false

rule "tts"
when
	Item TTSText received command 
then
	queueSpeaker.add(receivedCommand.toString)
	if (debug) {
		logInfo("TTS", "Add to queue: " + receivedCommand.toString)
	}
	// Check if timer exists
	if (timerSpeaker === null || bQueueSpeakerError) {
		if (bQueueSpeakerError) {
			bQueueSpeakerError = false 
			logError("ERROR", "Queue error in rule tts.rules: method entered because bQueueSpeakerError is true")
		}
		if (debug) {
			logInfo("TTS", "No timer existing - create")
		}
		timerSpeaker = createTimer(now, [ |
			try {
				// if queue is not empty
				if (queueSpeaker.peek !== null) {
					var cmd = queueSpeaker.poll
					// get next command from queue
					if (debug) {
						logInfo("TTS", "queue not empty - get command: " + cmd.toString)
					}
					TTSText_Speaker.sendCommand(cmd)

					// If string is too short, put in 10 characters 
					if (cmd.length() < 10) {
						cmd = "1234567890"
					}
					// reschedule timer - time is defined in iTTSCharacterDelay
					if (debug) {
						logInfo("TTS", "Timer reschedule: " + (cmd.length() * iTTSCharacterDelay).toString)
					}
					timerSpeaker.reschedule(now.plusMillis(cmd.length() * iTTSCharacterDelay))
				} else {
					if (debug) {
						logInfo("TTS", "Queue empty - timer end: null")
					}
					timerSpeaker = null
				}
			} catch(Exception e) {
				logError("ERROR", "Queue error in rule tts.rules: " + e.toString)
				bQueueSpeakerError = true 
				if (timerSpeaker !== null) {
					logError("ERROR", "Queue error in rule tts.rules: timerSpeaker.cancel")
					timerSpeaker.cancel
				}
				logError("ERROR", "Queue error in rule tts.rules: timerSpeaker = null")
				timerSpeaker = null
			}
		])
	}
end

rule "tts speaker"
when
	Item TTSText_Speaker received command 
then
	say(receivedCommand.toString, "googletts:nlNLWavenetB", "chromecast:chromecast:<ID>")
end

Best regards,
Matt

thisisIO · November 3, 2019, 7:03pm

Thanks, Matt! Will try it.

But what if to use this trigger of idle state of speaker Screenshot by Lightshot
Has anyone tried?

vzorglub · November 3, 2019, 7:12pm

Have a go and let us know

thisisIO · November 3, 2019, 7:13pm

I would, but not not at home and can not(((

opus · November 4, 2019, 11:34am

Say commands make use of a TTS service, the return of such should be handled asynchronically (IMHO) by the binding that handles the audiosink in question (you never told which ok you use). In order the get any information about when the stream is finished playing that binding would need to raise an event, If it does would be described in the documentation The “idling” channel you showed MIGHT be useable, be we can’t tell!

thisisIO · November 4, 2019, 12:16pm

I use Chromecast.

rlkoshak · November 4, 2019, 4:09pm

Your approach appears to be similar to Design Pattern: Gate Keeper. For those using Scripted Automation, I’ve submitted a version of this DP as a library module in the Helper Library.

I’m very happy to see you are using a ConcurrelyLinkedQueue instead of a ReentrantLock or some other less safe (for Rules DSL) approach.

mstehle · November 5, 2019, 8:49pm

Hi Rich,

it is indeed based on your excellent gate keeper design pattern, thank you very much for that I did re-write pretty much everything to get rid of ReentrantLocks.

thisisIO · November 9, 2019, 7:17pm

Im trying to use this rule, but it is again problems with timers in it.

Please look the rules.
Timer Rule:

import java.util.concurrent.ConcurrentLinkedQueue
val ConcurrentLinkedQueue<String> queueSpeaker = new ConcurrentLinkedQueue()
var Timer timerSpeaker = null
val int iTTSCharacterDelay = 150  // delay in ms per character

rule "TTS Queue TextToSay"

when
	Item TTSTextToSay received command 
then
	queueSpeaker.add(receivedCommand.toString)
	logInfo("TTS", "Add to queue: " + receivedCommand.toString)
	// Check if timer exists
	if (timerSpeaker === null) {
		logInfo("TTS", "No timer existing - create")

		timerSpeaker = createTimer(now, [ |
			// if queue is not empty
			if (queueSpeaker.peek !== null) {
				var cmd = queueSpeaker.poll
				// get next command from queue
				logInfo("TTS", "queue not empty - get command: " + cmd.toString)

				TTSOutputToSpeaker.sendCommand(cmd)

				// If string is too short, put in 10 characters 
				if (cmd.length() < 10) {
					cmd = "1234567890"
				}
				// reschedule timer - time is defined in iTTSCharacterDelay
				logInfo("TTS", "Timer reschedule: " + (cmd.length() * iTTSCharacterDelay).toString)
				timerSpeaker.reschedule(now.plusMillis(cmd.length() * iTTSCharacterDelay))
			} else {
				logInfo("TTS", "Queue empty - timer end: null")
				timerSpeaker = null
				timerSpeaker?.cancel()
			}
		])
	}
end

then Output to speaker

rule "TTS OutputToSpeaker"
when
	Item TTSOutputToSpeaker received command 
then
	say(receivedCommand.toString, "googletts:ruRUStandardB", "chromecast:chromecast:e338f8cdb77fb98a6dc66361aca9cfe7")
	logInfo("TTS", "Am saying now: " + receivedCommand.toString)

end

and last one - commant to send the texts

rule "Send text to say"
when
     Item Test changed
then
    TTSTextToSay.sendCommand("One. Tell the test Text")
    TTSTextToSay.sendCommand("Two. Tell the test Text") 
    TTSTextToSay.sendCommand("Тhree. Tell the test Text")   
	TTSTextToSay.sendCommand("Four. Tell the test Text") 
end

I can not get all 4 textes said correctly. I thing becuase i got one one, but many timers created at once.
Here is the sample of logs

2019-11-09 20:15:29.200 [ome.event.ItemCommandEvent] - Item 'TTSTextToSay' received command One. Tell the test Text

2019-11-09 20:15:29.213 [ome.event.ItemCommandEvent] - Item 'TTSTextToSay' received command Two. Tell the test Text

2019-11-09 20:15:29.217 [vent.ItemStateChangedEvent] - TTSTextToSay changed from Four. Tell the test Text to One. Tell the test Text

2019-11-09 20:15:29.234 [vent.ItemStateChangedEvent] - TTSTextToSay changed from One. Tell the test Text to Two. Tell the test Text

2019-11-09 20:15:29.247 [ome.event.ItemCommandEvent] - Item 'TTSTextToSay' received command Тhree. Tell the test Text

2019-11-09 20:15:29.250 [ome.event.ItemCommandEvent] - Item 'TTSTextToSay' received command Four. Tell the test Text

2019-11-09 20:15:29.270 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Add to queue: One. Tell the test Text

2019-11-09 20:15:29.239 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Add to queue: Two. Tell the test Text

2019-11-09 20:15:29.276 [vent.ItemStateChangedEvent] - TTSTextToSay changed from Two. Tell the test Text to Тhree. Tell the test Text

2019-11-09 20:15:29.291 [vent.ItemStateChangedEvent] - TTSTextToSay changed from Тhree. Tell the test Text to Four. Tell the test Text

2019-11-09 20:15:29.290 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Add to queue: Тhree. Tell the test Text

2019-11-09 20:15:29.287 [INFO ] [g.eclipse.smarthome.model.script.TTS] - No timer existing - create

2019-11-09 20:15:29.302 [INFO ] [g.eclipse.smarthome.model.script.TTS] - No timer existing - create

2019-11-09 20:15:29.307 [INFO ] [g.eclipse.smarthome.model.script.TTS] - No timer existing - create

2019-11-09 20:15:29.316 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Add to queue: Four. Tell the test Text

2019-11-09 20:15:29.316 [INFO ] [g.eclipse.smarthome.model.script.TTS] - queue not empty - get command: Two. Tell the test Text

2019-11-09 20:15:29.324 [INFO ] [g.eclipse.smarthome.model.script.TTS] - queue not empty - get command: One. Tell the test Text

2019-11-09 20:15:29.329 [ome.event.ItemCommandEvent] - Item 'TTSOutputToSpeaker' received command Two. Tell the test Text

2019-11-09 20:15:29.342 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Timer reschedule: 3450

2019-11-09 20:15:29.345 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Timer reschedule: 3450

2019-11-09 20:15:29.351 [vent.ItemStateChangedEvent] - TTSOutputToSpeaker changed from Тhree. Tell the test Text to Two. Tell the test Text

2019-11-09 20:15:29.363 [ome.event.ItemCommandEvent] - Item 'TTSOutputToSpeaker' received command One. Tell the test Text

2019-11-09 20:15:29.387 [vent.ItemStateChangedEvent] - TTSOutputToSpeaker changed from Two. Tell the test Text to One. Tell the test Text

2019-11-09 20:15:32.809 [INFO ] [g.eclipse.smarthome.model.script.TTS] - queue not empty - get command: Тhree. Tell the test Text

2019-11-09 20:15:32.816 [ome.event.ItemCommandEvent] - Item 'TTSOutputToSpeaker' received command Тhree. Tell the test Text

2019-11-09 20:15:32.821 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Timer reschedule: 3750

2019-11-09 20:15:32.835 [vent.ItemStateChangedEvent] - TTSOutputToSpeaker changed from One. Tell the test Text to Тhree. Tell the test Text

2019-11-09 20:15:33.938 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Am saying now: Тhree. Tell the test Text

2019-11-09 20:15:36.584 [INFO ] [g.eclipse.smarthome.model.script.TTS] - queue not empty - get command: Four. Tell the test Text

2019-11-09 20:15:36.610 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Timer reschedule: 3600

2019-11-09 20:15:36.596 [ome.event.ItemCommandEvent] - Item 'TTSOutputToSpeaker' received command Four. Tell the test Text

2019-11-09 20:15:36.618 [vent.ItemStateChangedEvent] - TTSOutputToSpeaker changed from Тhree. Tell the test Text to Four. Tell the test Text

2019-11-09 20:15:37.185 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Am saying now: Four. Tell the test Text

2019-11-09 20:15:40.230 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Queue empty - timer end: null

2019-11-09 20:15:59.433 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Am saying now: One. Tell the test Text

2019-11-09 20:15:59.432 [INFO ] [g.eclipse.smarthome.model.script.TTS] - Am saying now: Two. Tell the test Text

In this case Screenshot by Lightshot
Three timers war created at once and only two phrases was said.

Where is my problem that i am looking for 4 days(((?

wborn · November 9, 2019, 7:31pm

There was an issue where timers wouldn’t be created if they were created within quick succession:

github.com/openhab/openhab-core

[createTimer action] silent failure of multiple schedules for same instant

opened 11:59AM - 26 Jul 19 UTC

closed 07:12PM - 13 Aug 19 UTC

Rossko57

If using createTimer in rules DSL to schedule multiple jobs for the same 'abstra…ct instant', only one gets executed. openHAB 2.4 release Example rule snippet ``` val myInstant = now.withTimeAtStartOfDay.plusMinutes(736) logInfo("Test.rules", "target " + myInstant) var aa = createTimer(myInstant, [| logInfo("Test.rules", "Execute timer A") ]) logInfo("Test.rules", "handle timer A " + aa) var bb = createTimer(myInstant, [| logInfo("Test.rules", "Execute timer B") ]) logInfo("Test.rules", "handle timer B " + bb) ``` (pick a "minutes" value for your convenience) Here, I ran the rule twice to create 4 anonymous Timers. Results in openhab log ``` 2019-07-26 12:15:11.923 [INFO ] [se.smarthome.model.script.Test.rules] - target 2019-07-26T12:16:00.000+01:00 2019-07-26 12:15:11.926 [INFO ] [se.smarthome.model.script.Test.rules] - handle timer A org.eclipse.smarthome.model.script.internal.actions.TimerImpl@14e0fda 2019-07-26 12:15:11.929 [INFO ] [se.smarthome.model.script.Test.rules] - handle timer B org.eclipse.smarthome.model.script.internal.actions.TimerImpl@cb09f9 2019-07-26 12:15:14.862 [INFO ] [se.smarthome.model.script.Test.rules] - target 2019-07-26T12:16:00.000+01:00 2019-07-26 12:15:14.865 [INFO ] [se.smarthome.model.script.Test.rules] - handle timer A org.eclipse.smarthome.model.script.internal.actions.TimerImpl@182d1db 2019-07-26 12:15:14.874 [INFO ] [se.smarthome.model.script.Test.rules] - handle timer B org.eclipse.smarthome.model.script.internal.actions.TimerImpl@145399b 2019-07-26 12:16:00.014 [INFO ] [se.smarthome.model.script.Test.rules] - Execute timer B ``` Unique references seem to be generated for each Timer, but only one executes. Use case shown in forum https://community.openhab.org/t/only-last-created-timer-is-executed/78685 I did find an old issue (OH1) but cannot find the alleged replacement OH2 issue https://github.com/openhab/openhab1-addons/issues/3199 The OH1 issue mentions an error message - even if no fix were practical, reinstating or recreating an error message in OH2 would be a great improvement. Mind you, I suspect it might not be having an invisible error - a handle is returned.

It should be fixed on recent milestones and you can probably workaround it by adding some sleeps.

thisisIO · November 9, 2019, 7:35pm

I tought also this way!

I added a sleep (just to test, because as i know - speel is bad idea for rules), after this line

queueSpeaker.add(receivedCommand.toString)
 Thread::sleep(1000)

but it do not help(((

rlkoshak · November 9, 2019, 8:25pm

Adding the sleep there won’t help. They will still all be created close together, just one second later. You need to add a sleep between your sendCommands to TTSTextToSay.

This rule isn’t really based on my code but @mstehle’s so he might be better able to help debug it. The concept is the same as the Gatekeeper DP but it’s his code.

thisisIO · November 9, 2019, 9:57pm

Rich, it was just test command.
I can not add sleep there, because commands comes from diffenent rules and i do not know when it will come (((