[SOLVED] Combining 3 rules into 1 / Rule optimization

[vzorglub (Vincent Regaud)]

@EvenSteven

Thread::sleep(45000)

@EvenSteven

while(FrontDoorContact.state == OPEN){
    //Continues to check if the door has been closed.
    Thread::sleep(1000) // sleep for 1 second
}

This is very bad practice. Your are locking the thread these rules run in for a very long time
See:

(OH 1.x and OH 2.x Rules DSL only] Why have my Rules stopped running? Why Thread::sleep is a bad idea

EDIT: While the general advice in this article still applies (i.e. it’s always worth while to make short running rules), the problem described in this article only applies to OH 1.x and Rules DSL in OH 2.x. In OH 3 and beyond, this is no longer a problem so if your rules stop running in any version of OH released in the last two years (as of this edit in 1/2023) this is not your problem. By way of explanation, in OH 3 each rule gets it’s own thread. It is no longer possible for a rule to starve…

To put your three rules into one:

var Number pHeat = null // AT TOP OF RULE FILE!!

rule "Front door CLOSED TO OPEN"
when
    Item FrontDoorContact changed from CLOSED to OPEN
then
    if(LocalSun_Position_Elevation.state < 0|°) { //Chekcs if the sun has gone down.
        GangLys.sendCommand(ON)
    }
    createTimer(now.plusSeconds(45), [ |
        if(KlingeTLF_Online.state == OFF && LottesTLF_Online.state == OFF) { //checks if anyones phone is currently online
            sendNotification("my@mail.com", "Hovedøren er blevet åbnet!")  //sends notificatioon that the door has been opend and noone is home
        }
    ])
    createTimer(now.plusSeconds(60) , [ |
        pHeat = GangTermostat_SetpointHeat.state as Number //Stores the current temperature in a variable.
        if(FrontDoorContact.state == OPEN) {
            GangTermostat_SetpointHeat.sendCommand(8) //Sets temperature to 8 degrees
        }
    ])
end

rule "Front Door OPEN TO CLOSED"
when
    Item FrontDoorContact changed from OPEN to CLOSED
then
    if (pHeat !==null) GangTermostat_SetpointHeat.sendCommand(pHeat)
    pHeat = null //Resets pHeat for next time the door is opened
end