Sonos ... Audio Sink ... Say?

Jaghova · October 28, 2016, 2:16pm

Any heads up on the config so we can test it now that is merged?

shorty707 · October 28, 2016, 2:30pm

I think you need @kai to get the relvant information

shorty707 · October 29, 2016, 4:49pm

@kai hey kai any manual somewhere how to use this new sonos audio sink?
thanks

Kai · October 29, 2016, 5:32pm

Not yet, sorry…

shorty707 · November 6, 2016, 6:41pm

anybody out there who got it working and give a mini introduction?
cheers

Kai · November 13, 2016, 11:00pm

Yes, me!
I finally submitted a PR with some infos - hopefully it will soon be merged, then it will be easier to read

Some other parts are already online:
http://docs.openhab.org/concepts/audio.html
http://docs.openhab.org/administration/runtime.html#audio
http://docs.openhab.org/addons/voice.html

As all of this is pretty new, please don’t expect it all to be smooth. Rather see it as an invitation to help improving it (code and documentation likewise!)

Marty56 · November 14, 2016, 4:03am

Great and thank you.

I did not find the description how to change the default audio sink from within a rule or also to select an audio sink within rules.

Likewise to select the different TTS voices.

probably something like:
playsound(sink, filename) sink optional
playstream(sink, url) does this command exist?
say (sink,text)

Kai · November 14, 2016, 7:03am

You can find the rule actions here:

github.com

eclipse/smarthome/blob/master/bundles/model/org.eclipse.smarthome.model.script/src/org/eclipse/smarthome/model/script/actions/Audio.java#L27




import org.eclipse.smarthome.core.audio.AudioException;
import org.eclipse.smarthome.core.library.types.PercentType;
import org.eclipse.smarthome.model.script.engine.action.ActionDoc;
import org.eclipse.smarthome.model.script.engine.action.ParamDoc;
import org.eclipse.smarthome.model.script.internal.engine.action.AudioActionService;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;


/**
* The static methods of this class are made available as functions in the scripts.
* This allows a script to use audio features.
*
* @author Kai Kreuzer
*/
public class Audio {


   private static final Logger logger = LoggerFactory.getLogger(Audio.class);


   @ActionDoc(text = "plays a sound from the sounds folder to the default sink")
   public static void playSound(@ParamDoc(name = "filename", text = "the filename with extension") String filename) {

github.com

eclipse/smarthome/blob/master/bundles/model/org.eclipse.smarthome.model.script/src/org/eclipse/smarthome/model/script/actions/Voice.java#L22


*/
package org.eclipse.smarthome.model.script.actions;


import org.apache.commons.lang.StringUtils;
import org.eclipse.smarthome.core.voice.text.InterpretationException;
import org.eclipse.smarthome.model.script.engine.action.ActionDoc;
import org.eclipse.smarthome.model.script.engine.action.ParamDoc;
import org.eclipse.smarthome.model.script.internal.engine.action.VoiceActionService;


/**
* The static methods of this class are made available as functions in the scripts.
* This allows a script to use voice features.
*
* @author Kai Kreuzer
*/
public class Voice {


   /**
    * Says the given text.
    *
    * This method uses the default voice and the default audio sink to play the audio.

Not all of them are tested yet, though.

Lolodomo · November 14, 2016, 7:09am

The OH 1 wiki defines 3 different calls:

say(String text): Says the given text through Text-to-speech
say(String text, String voice): Text-to-speech with a given voice (depends on the TTS engine or voices installed in the OS)
say(String text, String voice, String device): Text-to-speech with a given voice to the given output device (only supported on Mac OS). Available voices command: say -v ?. Available devices command: say -a ?

Could we use the last one to set a voice and an audio sink using the device parameter ?

Lolodomo · November 14, 2016, 8:02am

Ok i see that it is implemented in the file you pointed. Wonderful. Remains to test it.

Marty56 · November 14, 2016, 1:39pm

Thanks.

Not clear for me
the “interpret” function?

Also not clear for me, if sink is not default, how can the user determine the getMasterVolume() of the not- default sink. TMOH user would need the ability to specify the sink in this command as well.
Or maybe I am lacking the full understanding. Would not exclude this

Marty56 · November 14, 2016, 4:04pm

Meanwhile I have started to test a bit.

in rules i have the following comands

say("dies ist ein Test")
say("dies ist ein Test","marytts","sonos:PLAY1:Schlafzimmer")

I am receiving the error message
16:55:47.025 [ERROR] [se.smarthome.core.voice.VoiceManager] - Error saying ‘dies ist ein Test’: Unable to find a voice for language de

In paper ui I have set
default Source: “empty” I do not know what to put here. Does this parameter makes sense?
default Sink: enhancedjavasound

Default Text-to-Speech: marytts

Also I have marytts installed in voices section

Marty56 · November 14, 2016, 4:21pm

I have tested the sequence

playSound ("sonos:PLAY1:Schlafzimmer","speechout.wav")
playSound ("sonos:PLAY1:Schlafzimmer","speechout.wav") 
playSound ("sonos:PLAY1:Schlafzimmer","speechout.wav")

It is working great!
Even with no sleeps in between the three commands.
What an improvement!!!

Note on syntax.

in playSound, the sink is firstly required,
in say(String text, String voice, String sink)

for the sake of consistence, sink maybe should also be the first. Just a thought not important.

Marty56 · November 14, 2016, 4:30pm

Have tested getMasterVolume() this return 1.0 working. Good!
With setMasterVolume(0,5) user has to use a “,” instead of a “.”.
Should both be the same and I would prefer “.”

Although it seems to accept the volume using “.” I do not see an change in the actual loudness of the speaker.
I have tested it with SONOS.

Lolodomo · November 14, 2016, 11:09pm

I just tested in my rules a call like this one:

say("voici un test","voicerss:frFR","sonos:PLAY5:chambre")

and it works.
Just briant. Thanks.
PS: that is with my updated version of the Voice RSS TTS engine.

Lolodomo · November 14, 2016, 11:40pm

@Kai: for the master volume, we need to define additional actions that would take the audio sink ID as parameter.

I asking myself whether it would not be a really good idea to have a playSound and a say action that would take the desired volume as parameter.

shorty707 · November 15, 2016, 6:40pm

I reinstalled the bundle but it pulled the old. is it already merged for the nighty build?

Lolodomo · November 15, 2016, 7:26pm

Not yet merged.

Kai · November 16, 2016, 12:06pm

Right, I didn’t address the masterVolume commands yet, they are still the old code. They probably do not make much sense anymore, probably rather a setVolume(String sinkID) should be there.

No, I would leave that separate. Usually volume control is independent of the content that is played. And if you have use cases where you need to say something loud, use setVolume and say within a rule.

Marty56 · November 19, 2016, 10:11am

With snapshot 595 running Windows 10, I observed the following bugs and German language.

say command is not working
When defining “marytts” as default language:

say(“Test”)
11:06:31.674 [ERROR] [se.smarthome.core.voice.VoiceManager] - Error saying ‘Test’: Unable to find a voice for language de

say(“dies ist ein Test das ist ein Test ist ein Test”,“marytts:bits1hsmm”,“enhancedjavasound”)
working

say(“dies ist ein Test das ist ein Test ist ein Test”,“marytts:bits3hsmm”,“sonos:PLAY1:Schlafzimmer”)
or also
say(“dies ist ein Test das ist ein Test ist ein Test”,“marytts:bits3hsmm”,“webaudio”)
working but not understandable.
Sounds like Donald Duck but cannot understand words.
Seems to be played much too fast.

Shall I create a issue or too early?