I really find it weird that in all that discussion nobody tries to find a way to help getting code reviews done quicker. But this is actually the whole issue, isnāt it? If there were maintainers that check the code and confirm that it
- respects the license
- does not have any unclear legal conditions
- follows common coding guidelines
- is written in a way that it complies to the architecture, so that it does not break unexpectedly if some internals of the framework are changed
- is written in a way that others have a chance to understand, fix and further maintain the code
- that it comes with documentation for the end user
within a few days, there wouldnāt be any reason for discussion, right? It really makes me wonder, if I am totally insane that I am spending my time doing this job, while nobody else cares about it and only see the frustration of the contributors, but not my frustration about having put so much effort into it in vain?
An no, to be very clear: NOT enforcing above rules, i.e. ending up with code that has no clear license, imposes legal risks, which is unmaintainable and an awful example for others (who will happily pick it up as a starting point for their own developents) IS NO OPTION.
Btw, the complaint that it takes so long is imho only valid for āfullā new binding contributions. Whenever small new functions are added or bugs are fixed, the PRs are imho usually processed very quickly, at least thatās what I am trying to do.
So the really sad thing is that there arenāt any volunteers for openHAB 2 reviews (meaning looking at code from others and not only on his own - btw, ANY good project, be it open or closed source should really have a peer review process in place, this is enormously helpful for the code quality).
It actually works better on openHAB 1 add-ons, so I wouldnāt want to give up for openHAB 2 add-ons yet. In the meantime, I have tried to find other helpful measures to speed up reviews, like automatically checking the āboringā parts, which will be a huge step forward. You are all cordially invited to help reviewing and testing this feature, I am so much looking forward to have it in place.
So having said this (and I hope the plea for more active maintainers has been heard), I also see that openHAB is continuing to grow in popularity and even if we manage to have more maintainers, it will be difficult to keep up with growth.
For this, I have some good news:
Having some form of marketplace would be great but we need to know this is piece of infrastructure which needs to be developed by someone.
I have found āsomeoneā that developed exactly such a piece of infrastructure: The Eclipse Foundation!
I have created this issue for ESH today, which will mean that once it is implemented, openHAB can install content from the Eclipse IoT Marketplace. Everyone is free to upload content to the Marketplace, mark it as alpha, beta, production or whatever and does not even have to make it available as open source - so this is the right place where nobody has to worry about source code quality, yeah
I think this will help a lot to grow the openHAB ecosystem in a way that not everything has to live within the official openHAB repositories. Nonetheless, I very much welcome every contribution to the repos as PRs, since this is really handing over the code/value to the community as a whole - where it can continue to live and grow and change the people maintaining it. It is simple āthere and freeā, while content on the Marketplace can disappear at any time or turned into commercial offerings once enough people from the community have helped to identify and fix bugs.
FYI: The current plan is to have the Eclipse IoT Marketplace as well as the ESH integration ready (meaning also available in openHAB) by end of March.