TKB TZ69 [ID:2,Type:4]

Hello,

Currently using OH1.8.3, and have added a Wenzhou TKB Control System [ID:2,Type:4]. There isn’t a database entry for it. I’ve also tried it in OH2 as I’ve been wanting to trial that, but it isn’t in the beta4 either. How would I go about adding it to the database?

Take a look here. If you add it into the database we can easily export it to OH1 or OH2.

You’ll need to register, and then email me so I can give you edit rights, but the rest should be in the instructions…

Registered

You’re all set - let me know if you have any problems…

Details uploaded. Not exactly sure what the Endpoints is all about or whether anything needs changing…

Looks good from a quick look - thanks. The endpoints should be fine - they autogenerate from the XML data that comes from the device discovery…

I’ll probably update the binding tomorrow now…

Not a problem. If you update the binding tomorrow, does that mean it will be available on Cloudbees the day after?

https://openhab.ci.cloudbees.com/job/openHAB1-Addons/

Thanks for the help

Yep - that’s correct.

Sweet. Hopefully have this Christmas tree turning on and off by itself then

FTR…

Downloaded the addon this morning and chucked it in openhab/addons. Restarted openHab and it now correctly identifies, but for some reason the configuration parameters and association groups contain nothing. Is there anything else to do? Grabbed it from here: https://openhab.ci.cloudbees.com/job/openHAB1-Addons/lastBuild/org.openhab.binding$org.openhab.binding.zwave/

It looks ok, so I’m not sure. I’d check the log to make sure there’s no errors being logged…

Right. Finally had the chance to have a look at this, and it may be a problem with the XML file. Am presented with the following log error:

2016-12-09 22:49:25.711 [ERROR] [.s.container.ContainerResponse] - The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
com.thoughtworks.xstream.converters.ConversionException: : ParseError at [row,col]:[141,11]
Message: XML document structures must start and end within the same entity. : : ParseError at [row,col]:[141,11]
Message: XML document structures must start and end within the same entity.
---- Debugging information ----
message : : ParseError at [row,col]:[141,11]
Message: XML document structures must start and end within the same entity.
cause-exception : com.thoughtworks.xstream.io.StreamException
cause-message : : ParseError at [row,col]:[141,11]
Message: XML document structures must start and end within the same entity.
class : java.lang.String
required-type : java.lang.String
converter-type : com.thoughtworks.xstream.converters.SingleValueConverterWrapper
wrapped-converter : com.thoughtworks.xstream.converters.basic.StringConverter
path : /Product/Configuration/Parameter/Help
line number : 141
class[1] : org.openhab.binding.zwave.internal.config.ZWaveDbLabel
converter-type[1] : com.thoughtworks.xstream.converters.extended.ToAttributedValueConverter
class[2] : org.openhab.binding.zwave.internal.config.ZWaveDbConfigurationParameter
converter-type[2] : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
class[3] : org.openhab.binding.zwave.internal.config.ZWaveDbProductFile$ZWaveDbConfiguration
class[4] : org.openhab.binding.zwave.internal.config.ZWaveDbProductFile
version : 1.4.6

So I decided to have a look at the XML file here: https://github.com/openhab/openhab/blob/master/bundles/binding/org.openhab.binding.zwave/database/tkb/tz69.xml

I ran it through a validator, and the validator isn’t happy. Looks like we are missing > at the end of the CDATA block

So I went ahead and made the changes in github and created a pull request. I think someone just has to approve it now and its added in?

Just downloaded the latest snapshot and all is now well.

Thanks for the help!