Unable to (git) push my binding-extensions

Despite all the examples and explanations, I don’t understand it - and thus I ended up here in the hope of getting help:

on my Ubuntu notebook:
in my {user} account:
in the folder /home/{user}/myopenhab:
I did as follows…:

git clone https://github.com/openhab/openhab-addons.git

Clone to ‘openhab-addons’ …

git status

On branch main
your branch has the same status as ‘origin/main’.
nothing to commit, working path unchanged

git checkout -b {mybranch}

switched to new branch ‘{mybranch}’

git status

On branch {mybranch}
nothing to commit, working path unchanged

mvn clean install -pl org.openhab.addons.bundles:org.openhab.binding.rotel
…I did some modifications in existing OH-binding…
mvn package -pl org.openhab.addons.bundles:org.openhab.binding.rotel
…after successfully tested my OH-binding-extensions…

git commit -a -m “my description…”

git status

On branch {mybranch}
nothing to commit, working path unchanged

git branch

  • {mybranch} (green)
    main (white)

git push -u origin {mybranch}

Username for https://github.com: {mygitusername}
Password for https://tonwi@github.com: {my-personal-git-token}
remote: Permission to openhab/openhab-addons.git denied to {mygitusername}.
fatal: could not access to https://github.com/openhab/openhab-addons.git/ : The requested URL returned error: 403

What I’m doing wrong?

You need to have a fork in your git account where you push your changes.
Direct push to our repo ist not allowed.

thank you for advice; I forked; I pushed…
now I’m struggling with the pull request…

What‘s your issue now ?
When you pushed to your fork, visit it on github page and you should be asked if you want to create a PR…

my PR has ID #12447
I forgot to sign my commits, so I have to correct this issue…

According to the instructions on
Checking out pull requests locally - GitHub Docs
I tried to do

git fetch origin pull/#12447/head:a14-tonwi

and got error:
fatal: could not find remote-referenz pull/#12447/head

???

Why are you trying to fetch the PR ?
You have the changes already in your local repo.

I modified locally my commit using signed-of…
as described in ‘[rotel] Extension of amplifier A14's channel list by tonwi · Pull Request #12447 · openhab/openhab-addons · GitHub’ I did as follows:

git push --force-with-lease origin a14-tonwi

To https://github.com/tonwi/openhab-addons.git
! [rejected] a14-tonwi → a14-tonwi (stale info)
error: Fehler beim Versenden einiger Referenzen nach https://github.com/tonwi/openhab-addons.git

???

While on your feature branch, did you

git rebase HEAD~2 --signoff

What was the output ?

my core problem is: I don’t understand git…
I send now the original messages; I didn’t translate them…

git status
Auf Branch a14-tonwi
Ihr Branch ist auf demselben Stand wie ‘origin/a14-tonwi’.
nichts zu committen, Arbeitsverzeichnis unverändert

git rebase HEAD~2 --signoff
Aktueller Branch a14-tonwi ist auf dem neuesten Stand, Rebase erzwungen.
Zunächst wird der Branch zurückgespult, um Ihre Änderungen darauf neu anzuwenden…
Wende an: A14: new channels: BYPASSx BALANCE SPEAKER-A SPEAKER-B: tested
Wende an: A14: README extended

git status
Auf Branch a14-tonwi
Ihr Branch und ‘origin/a14-tonwi’ sind divergiert,
und haben jeweils 2 und 2 unterschiedliche Commits.
(benutzen Sie “git pull”, um Ihren Branch mit dem Remote-Branch zusammenzuführen)

nichts zu committen, Arbeitsverzeichnis unverändert

???
if “nothing to commit” how I should modify the text in the existing commits?
???
BUT
!!! in the already existing commits there is my sihnation???

git log
commit 5d5a08378159cabcb7d0d06544193c0110d6d77b (HEAD → a14-tonwi)
Author: Wilhelm Tonsern
Date: Tue Mar 8 13:20:38 2022 +0100

A14: README extended

Signed-off-by: Wilhelm Tonsern <wto.wit01@gmx.net>

commit 39de5fd512bd1e7cd361eb6f06e19099525298d7
Author: Wilhelm Tonsern
Date: Tue Mar 8 09:36:22 2022 +0100

A14: new channels: BYPASSx BALANCE SPEAKER-A SPEAKER-B: tested

Signed-off-by: Wilhelm Tonsern <wto.wit01@gmx.net>

commit e3ca3b01bf80d27d4bcc7bba2ea7c61d3d370356 (origin/main, origin/HEAD, main)
Author: lolodomo
Date: Tue Mar 8 00:01:54 2022 +0100

[pulseaudio] Fix exception handling when connecting (#12423)

Fix bridge/thing status update
Also update log levels

Fix #nnnnn
Fix #mmmmm

Signed-off-by: lolodomo <his-mail-address>

commit 20f6b52e71c4cd419c1029dc12a7086e9823c8f2
Author: glassl
Date: Mon Mar 7 17:52:56 2022 -0500

Fix links to SmartThings capabilities reference doc (#12439)

:

please! release me from my chaos; what I should do the next step?

ok, I tried the proposal a second time:

git push --force-with-lease origin a14-tonwi
Objekte aufzählen: 61, fertig.
Zähle Objekte: 100% (61/61), fertig.
Delta-Kompression verwendet bis zu 4 Threads.
Komprimiere Objekte: 100% (24/24), fertig.
Schreibe Objekte: 100% (33/33), 6.13 KiB | 1.02 MiB/s, fertig.
Gesamt 33 (Delta 18), Wiederverwendet 0 (Delta 0)
remote: Resolving deltas: 100% (18/18), completed with 16 local objects.
To https://github.com/tonwi/openhab-addons.git

  • cd0120c7dc…5d5a083781 a14-tonwi → a14-tonwi (forced update)

??? ok ???

Looks good

I need help once again!!!

The package owner requested some modifiacions
I implemeted them
I commited them

git status
on branch a14-tonwi
your branch is 1 Commit before ‘origin/a14-tonwi’.
(use “git push”, in order to publish local Commits)

nothing to commit, working directory unchanged

git branch

  • a14-tonwi
    main

git push
Objekte aufzählen: 51, fertig.
Zähle Objekte: 100% (51/51), fertig.
Delta-Kompression verwendet bis zu 4 Threads.
Komprimiere Objekte: 100% (18/18), fertig.
Schreibe Objekte: 100% (26/26), 2.76 KiB | 942.00 KiB/s, fertig.
Gesamt 26 (Delta 13), Wiederverwendet 0 (Delta 0)
remote: Resolving deltas: 100% (13/13), completed with 13 local objects.
To https://github.com/tonwi/openhab-addons.git 5d5a083781..a8d9100928 a14-tonwi -> a14-tonwi

and now ???

You first need to add the modified files to commit

git add <file to add>

then

git commit -s -m <your commit message>

followed by

git push <origin/upstream> [depending on your config]

You should start reading some git documentation…

I fixed the code-owner’s requests 6 days ago (on 11/03/2022), made my commit, did a push (which was executed on my site without errors).

On the GitHub page of my pull request, the number of commits has increased. I can also see my new changes. The changes were also checked again automatically.

But there is no reaction from the code owner.
Two days later I found a button to request a new code review.
No reaction.

There are at least two possibilities now:

  1. the code owner has no time because he is prevented.
  2. I did something wrong.

do you have any advice for me?

Yes, be patient.
As we are all volunteers (maintainers and contributors), we are all doing this in our spare time.
So don’t expect a code review and merge in just a couple of days. If you check the list of open PR’s, you will notice that some are quite old.

This topic was automatically closed 41 days after the last reply. New replies are no longer allowed.