Use Instant in HistoricItem.getTimestamp instead of ZonedDateTime?

[rlkoshak (Rich Koshak)]

See these relevant issues and PRs:

• [DateTimeType] ZonedDateTime, Instant or neither? · Issue #2898 · openhab/openhab-core · GitHub
• [core] Use `Instant` internally for `DateTimeType` by jlaur · Pull Request #3583 · openhab/openhab-core · GitHub
• [core] Add DateTimeType method for returning `Instant` by jlaur · Pull Request #3287 · openhab/openhab-core · GitHub

@joerg1985

Do you think i should wait for this PR for openhab 5, as this is a change in the API or is it okay to create a PR for 4.4? Another PR will adopt this change in the addons and should be merged at the same time.

If it’s an API or user facing breaking change it’s supposed to wait for OH 5. However, some exceptions are made periodically, most recently with all the changes to persistence to hamonize with the fact that persistence can now store future values too. I’d ask in a in issue and see what the maintainers say.

@joerg1985

Or should i create a new method to make this a none breaking change?

I’m always in favor of this approach over a breaking change when it’s possible. I agree with @jimtng , I’d expect it to be names getInstant.