We need your help on testing!

@Kai, since we’re seeing good success with adding the add/removeBindingProvider methods in 1.x bindings, should I make a single PR that adds these methods to all remaining 1.x bindings, except for the ones with outstanding PRs to do the same? Note this is much bigger list than the subset of bindings that can be installed currently via the Paper UI.

Yes, a bulk PR is absolutely fine!

This has been fixed in ESH and I have published a new stable release last night, so that this is now included in OH2 - glad to hear that it indeed solves the problem!

Will submit late this evening.

2 Likes

This should be fixed, submitted PR [Netatmo] fix for issue #3937 by robnielsen · Pull Request #3943 · openhab/openhab1-addons · GitHub

I can confirm that the bug I previously indentified for the Freebox 2.0 binding is now fixed.
Unfortunately, I discovered 2 new additional bugs. Issues created.

But this 2.0 binding is working.
Missing features, present in 1.x version, have to be added.

the binding RFXCOM 2.0 is apparently working now worst than before for me. I opened 2 new issues.

Even if the weather binding is now working, I still have this line in my logs:

22:29:54.687 [INFO ] [ternal.scheduler.WeatherJobScheduler] - Disabling weather locationId 'home', no binding available

Is it normal ?

PR: OH2 changes to 118 OH 1.x bindings #3948

2 Likes

Wow!!! Great Work :ribbon:
Hopefully you didn’t have to spend the entire night for that :sunglasses:

1 Like

Netatmo binding is still broken in OH snapshot 114.

It still contains the broken version of the Netatmo binding.

PR #3943 was not included in this build ?

Sure don’t look like it to me: https://openhab.ci.cloudbees.com/job/openHAB1-Addons/1147/ has:

Downstream Builds

openHAB-Distribution Success#113 Success#114

And doesn’t contain PR #3943

Updated status with OH2 snapshot #114.

Features OK, considering my personal (and so partial) usage:

  • Astro binding 2.0
  • NTP binding 2.0
  • Freebox binding 1.9
  • MQTT binding 1.9 + MQTT io transport 1.9
  • MiOS binding 1.9
  • Weather binding 1.9
  • HTTP action
  • Logging action
  • MiOS action 1.9

Features KO (not working at all):

  • Netatmo binding 1.9
  • RFXCOM binding 1.9 (combined with feature openhab-transport-serial)

Features working a little but with major bugs:

  • RFXCOM binding 2.0
  • Hue binding 2.0 (not tested with snapshot 114)

Features working mostly with only minor bugs:

  • Freebox binding 2.0 (not tested with snapshot 114)

Reporting from today’s snapshot (Feb 1), my 1.9 bindings are looking fine! Thanks for the great work.

I am having a problem with the logging. The 1.9 persistence addon for logging is throwing this exception:

java.util.concurrent.ExecutionException: java.lang.ClassCastException: org.ops4j.pax.logging.slf4j.Slf4jLoggerFactory cannot be cast to ch.qos.logback.classic.LoggerContext
        at java.util.concurrent.FutureTask.report(FutureTask.java:122)[:1.8.0_60]
        at java.util.concurrent.FutureTask.get(FutureTask.java:206)[:1.8.0_60]
        at org.eclipse.smarthome.core.common.SafeMethodCaller.callAsynchronous(SafeMethodCaller.java:179)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.common.SafeMethodCaller.call(SafeMethodCaller.java:72)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.common.SafeMethodCaller.call(SafeMethodCaller.java:56)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.internal.events.OSGiEventManager.dispatchESHEvent(OSGiEventManager.java:188)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.internal.events.OSGiEventManager.handleEvent(OSGiEventManager.java:163)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.internal.events.OSGiEventManager.handleEvent(OSGiEventManager.java:146)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.apache.felix.eventadmin.impl.handler.EventHandlerProxy.sendEvent(EventHandlerProxy.java:415)[3:org.apache.karaf.services.eventadmin:4.0.3]
        at org.apache.felix.eventadmin.impl.tasks.HandlerTask.run(HandlerTask.java:90)[3:org.apache.karaf.services.eventadmin:4.0.3]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_60]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_60]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]
Caused by: java.lang.ClassCastException: org.ops4j.pax.logging.slf4j.Slf4jLoggerFactory cannot be cast to ch.qos.logback.classic.LoggerContext
        at org.openhab.persistence.logging.internal.LoggingPersistenceService.createNewAppender(LoggingPersistenceService.java:107)[167:org.openhab.persistence.logging:1.9.0.201602012140]
        at org.openhab.persistence.logging.internal.LoggingPersistenceService.store(LoggingPersistenceService.java:94)[167:org.openhab.persistence.logging:1.9.0.201602012140]
        at org.openhab.core.persistence.internal.PersistenceServiceDelegate.store(PersistenceServiceDelegate.java:48)[153:org.openhab.core.compat1x:2.0.0.201601310204]
        at org.eclipse.smarthome.model.persistence.internal.PersistenceManager.handleStateEvent(PersistenceManager.java:229)[110:org.eclipse.smarthome.model.persistence:0.8.0.201601301304]
        at org.eclipse.smarthome.model.persistence.internal.PersistenceManager.stateUpdated(PersistenceManager.java:211)[110:org.eclipse.smarthome.model.persistence:0.8.0.201601301304]
        at org.eclipse.smarthome.core.items.GenericItem.notifyListeners(GenericItem.java:216)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.items.GenericItem.setState(GenericItem.java:195)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.internal.items.ItemUpdater.receiveUpdate(ItemUpdater.java:82)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.items.events.AbstractItemEventSubscriber.receive(AbstractItemEventSubscriber.java:44)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.internal.events.OSGiEventManager$1.call(OSGiEventManager.java:192)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.internal.events.OSGiEventManager$1.call(OSGiEventManager.java:1)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        at org.eclipse.smarthome.core.common.SafeMethodCaller$CallableWrapper.call(SafeMethodCaller.java:170)[88:org.eclipse.smarthome.core:0.8.0.201601301304]
        ... 4 more

@xsnrg: please list your working 1.9 bindongs working well in OH2. It could help to improve the wiki page about the compatibility layer.

This add-on is indeed not working, since OH2 does not use logback anymore. We could try packaging logback within the logging add-on feature, but I am not sure if this might cause hiccups for the normal logging then…

I propose to update the compatibility page and add in front of each 1.x binding either “OK in beta 2” or “To be confirmed in beta 2”.
And I propose to add a comment encouraging the users to report a feedback in this topic.
@Kai: is it ok for you ?

Maybe I should just add a column with the OH 2 version ? I could set “alpha” or “beta 2”. “Alpha” would mean that a positive feedback was reported in alpha version but not yet in beta 2.