What to do with old pull request with 2.5 snapshot

Tags: #<Tag:0x00007f616db58b70>

Hi all,
I have a pull request made during the 2.4 release.
While it passed build checks before I see that now it stays in status that Travis CI failed without any meaningful error. Meanwhile I’ve submitted some fixes.

I just wonder if I need to do anything further to fix this stuff for my branch(maybe rebase on top of 2.5)?

Cheers,
K.

You need to ask this in gitHub

Maybe I had to mention that it is for a new binding which has not been approved yet.
I just don’t know what is the process.
This is my first binding.

If it has been approved, yet. And the process is quite fastidious…
You can still publish your binding in the Market Place

https://marketplace.eclipse.org/taxonomy/term/4988%2C4396/title

Did you try pushing a commit that changes it from 2.4 to 2.5 (in pom.xml and MANIFEST.MF).

1 Like

Not yet Mark.
I’m still at 2.4 milestone build at home and I’m a bit reluctant to go with SNAPSHOT version.

Do you think that’s the reason?
If this is the reason probably I should have to go with SNAPSHOT in order to test that all runs well on 2.5 before pushing the change.

I dunno for sure.

I know that checkstyle.properties looks for 2.5.0 explicitly. But I don’t know if that’s the cause of the failure you’re seeing.