Thanks everyone for the feedback. Yes, the plan is to make a PR once we test this. I know the input selection was a pain due to differences between models. I have added some documentation to the addon README, that will make its way to the PR.
Now, I propose we drop the existing mapping logic coded into the addon, and let the users leverage the introduced thing setting (Input mapping) to cater for their (older) models that work in this weird way (HDMI1 vs HDMI_1). Unfortunately, this might mean breaking functionality for some users, but I believe it would be more clean going forward. @David_Graeff please share your insight here.
To recap, the existing mapping logic is like this:
- Each space to _ AND make upper case:
- Example:
Net Radio=>NET_RADIO - Example:
Hdmi 1=>HDMI_1 - Example:
AUDIO 1=>AUDIO_1
- Example:
-
HDMI X=>HDMI_X -
HDMIX=>HDMI_X
This could be replaced by the proposed thing mapping setting.
What do you think?