Add-on build (3.4.x) fails with IntelliJ on MacOS

Development
,
1

I am trying to build the addons, following strictly the recipe (except that I checked out 3.4 not main, cause I suppose main is 4.0.0).
The build failed with some error which I repaired with spotless:apply
but then fails in the codecheck at hue module:
[INFO] — sat-plugin:0.13.0:report (sat-all) @ org.openhab.binding.hue —
[INFO] Individual report appended to summary report.
[ERROR] Code Analysis Tool has found:
1 error(s)!
1 warning(s)
1 info(s)
[WARNING] org.openhab.binding.hue.internal.discovery.BridgeJsonParameters.java:[25]
Classes/Interfaces/Enums should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.hue.internal.exceptions.EmptyResponseException.java:[2]
Header line doesn’t match pattern ^ * Copyright (c) 2010-2022 Contributors to the openHAB project$

I can’t motivate the build to continue.
Thx for some hints

UPDATE: the copyright in that class contains 2023, so the codecheck is outdated.

2

Indeed. The 3.4.x branch does a code check for 2010-2022 whereas the main branch does it for 2010-2023 …

3

which means this build can’t run unless I change the comment in HUE binding (and whatever error follows),
which raises the question why the branch is inconsistent :-p

4

Next one, after 42 minutes of build:

[INFO] Testing /mypath/openhab-addons/itests/org.openhab.binding.astro.tests/itest.bndrun:
[ERROR] Tests not run because project has errors
[ERROR] Error : org.openhab.binding.astro;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.binding.astro.tests;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.core;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.core.config.core;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.core.config.discovery;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.core.io.console;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.core.storage.json;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]
[ERROR] Error : org.openhab.core.thing;version=[3.4.0,3.4.1) Not found in [bnd-cache [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/org.openhab.core.bom.openhab-core-index r/w=false], self [/mypath/openhab-addons/itests/org.openhab.binding.astro.tests/target/test/tmp/testing/itest/cnf/cache/6.4.0/self r/w=false], openHAB Add-ons :: Integration Tests :: Astro Binding Tests [org.openhab.binding.astro.tests,org.lastnpe.eea:eea-all,org.openhab.binding.astro r/w=false]]

5

The check is applied to all Java files. And if you are building all bindings, this will apply to thousands of files probably.

But I think somewhere in the root of the addons folder is located a file with the check script in it. I can’t remember its name or location. But it contains a line ‘year=2022’ which you can edit to 2023 which should solve your issue…

EDIT: see this…

6

Fixed with Fix header · openhab/openhab-addons@211955c · GitHub.

7

I just commented on this in my other post.
So this one can be closed.

There were several addons concerned, which I solved by simply running spotless on all addons.
In my fork, this is mixed up with adding RFLink integration in ONE single commit, so I’d rather would not want to have this merged, cause it was my blue-eyed approach to openHab :smiley: :stuck_out_tongue:
But feel free to have a look.

8

This topic was automatically closed 41 days after the last reply. New replies are no longer allowed.