Alex_Berg
(Alex Berg)
November 17, 2018, 11:35am
1
I’ve updated the wiki, but the jenkins tests fail. I have no idea why. It seems to be Jenkins build problem.
Does that mean that the change request get rejected?
https://ci.openhab.org/job/PR-openHAB1-Addons/2340/org.openhab.addons$openhab-addons/console
Dim
(Angelos)
November 17, 2018, 11:50am
2
No, don’t worry about it.
Another build run will be executed at a later time and it will pass (it has nothing to do with your PR).
Good job by the way updating the binding documentation!
A recommendation: Use the binding name in the PR title:
[TCP1] Update README.md
and Sign your contribution!
Signed-off-by: First_Name Last_Name <email> github: <username>
Dim
(Angelos)
November 17, 2018, 12:12pm
3
Alex_Berg
(Alex Berg)
November 23, 2018, 3:15pm
4
I know, and maybe someone will add some details that I seem to find missing. Its also OK if they just delete it
It would be even better if it got fixed, but probably its easier to review and update documentation than fix that old bug.
Where would I add the sign-off?
1 Like
Dim
(Angelos)
November 23, 2018, 3:16pm
5
at the bottom of your first comment in the PR (edit the comment and add your “signature”)
1 Like