Binding Documentation Update failed automatic jenkins tests

I’ve updated the wiki, but the jenkins tests fail. I have no idea why. It seems to be Jenkins build problem.

Does that mean that the change request get rejected?$openhab-addons/console

No, don’t worry about it.
Another build run will be executed at a later time and it will pass (it has nothing to do with your PR).

Good job by the way updating the binding documentation!

A recommendation: Use the binding name in the PR title:

[TCP1] Update

and Sign your contribution!

Signed-off-by: First_Name Last_Name <email> github: <username>

by the way, I don’t think that your new section titled ## Currently broken will go down nicely with the reviewers… for sure they will changes to it before it can be included in the TCP Binding documentation :slight_smile:

Please note that it appears the TCP binding is currently broken and has been so for years.

:smiley: :smiley: :smiley:

I know, and maybe someone will add some details that I seem to find missing. Its also OK if they just delete it :slight_smile:

It would be even better if it got fixed, but probably its easier to review and update documentation than fix that old bug.

Where would I add the sign-off?

1 Like

at the bottom of your first comment in the PR (edit the comment and add your “signature”)

1 Like