Caldav Personal Regular Expression

rkrisi · November 2, 2019, 11:33pm

Hi Everyone!

I’m trying to configure a CalDav item to only match a specific RegEx. I confirmed that the actual regex is correct. The doc says:

filter-name:'\<regular expression\>'

How should I enter my Regular Expression?
Just entering filter-name:‘Regular Expression here’ seems to match everything. Entering like filter-name=’\Regular Expression here’ gives an error upon loading.

How should I use regex in the caldav configuration?

Thanks!

rlkoshak · November 3, 2019, 3:04pm

After you sure, because REGEX works differently in OH from standard. Your expression must match the full string, even if it’s multiple lines. Only the first group gets returned.

rkrisi · November 3, 2019, 6:35pm

Events in my calendar are not multiline and I think the first group has the value.

But I will try to be more specific, maybe you can help.

The regex I have:

^Szállás|^szállás|Hotel|hotel

So I want to filter the events which start with ‘szállás’ (or with an uppercase - I know that there are flags also for this, but I don’t know if it works in OH or not) or has the word ‘Hotel’ in the event name.

It gives a ‘Full match’ for me on a regex tester like this:

Or maybe I just need to add braces for this regex like this:

(^Szállás|^szállás|Hotel|hotel)

This is what I haven’t tried yet. This way it also returns the 1st Group in every Regex tester.

rlkoshak · November 4, 2019, 2:59am

Like I said, the regular expression must match the full string. That regular expression will only match one word. I doubt your calendar entry is just one word so you need to have the regular expression match everything after that first word too.

Olti · November 4, 2019, 6:26am

As per my understanding and tests you should try it with the following regex:

^[Ss]zállás.*|.*[Hh]otel.*

Maybe the ^ at the beginning can be removed too. Didn’t test that.

rkrisi · November 4, 2019, 9:09am

Thanks I came up with something similar, I will test!

Thank you!

rkrisi · November 6, 2019, 3:33pm

Tried it like this:

Switch  GoogleVacation          "Google Vacation"                                   (gCal)              { caldavPersonal="calendar:google type:PRESENCE filter-name:'[Ss]zállás.*|.*[Hh]otel.*'" }

However still, all my events are returned here. Tried creating a group, etc… Doesn’t help.

namraccr · November 8, 2019, 12:15am

Have you tried putting the binding into TRACE mode and checking the log output?

That’s the first thing you should’ve done.

rkrisi · November 8, 2019, 11:30am

Totally right, I forgot. I will try and see if that helps anyhow…

5iver · January 27, 2020, 7:32am

@rkrisi, did you ever get this working? I just had a go with some Items and figured out a few… nuances of this binding. The binding is using regex to extract the regex for the filter-name. When you use anything other than what is in the allowed character set, the matching stops. Your filter expression cannot contain anything other than A-Z, a-z, ., *, +, -, |, and spaces. You are using special characters, which will stop the matching. Character sets will also stop the matching due to the [. If the matching stops before the end, nothing will be found. However, if the matching stops at the very beginning, like when ^ is used, then there is effectively no filter and everything is returned. Hopefully some of this makes sense! The documentation definitely needs an update.

I suggest you try this…

filter-name:'Sz.ll.s.*|sz.ll.s.*|.*Hotel.*|.*hotel.*'

github.com

openhab/openhab1-addons/blob/master/bundles/binding/org.openhab.binding.caldav-personal/src/main/java/org/openhab/binding/caldav_personal/internal/CalDavBindingProviderImpl.java#L54


* @author Robert Delbrück
* @since 1.8.0
*/
public class CalDavBindingProviderImpl extends AbstractGenericBindingProvider implements CalDavBindingProvider {
   private static final Logger logger = LoggerFactory.getLogger(CalDavBindingProviderImpl.class);


   private static final String REGEX_CALENDAR = "calendar:'?([A-Za-z-_]+(, ?[A-Za-z-_]+)*)'?";
   private static final String REGEX_TYPE = "type:'?([A-Za-z]+)'?";
   private static final String REGEX_EVENT_NR = "eventNr:'?([0-9]+)'?";
   private static final String REGEX_VALUE = "value:'?([A-Za-z]+)'?";
   private static final String REGEX_FILTER_NAME = "filter-name:'?([A-Za-z\\.\\*\\+\\- \\|]+)'?";
   private static final String REGEX_FILTER_CATEGORY = "filter-category:'?([A-Za-z-_]+(, ?[A-Za-z-_]+)*)'?";
   private static final String REGEX_FILTER_CATEGORY_ANY = "filter-category-any:'?([A-Za-z-_]+(, ?[A-Za-z-_]+)*)'?";


   private boolean categoriesFiltersAny = false;


   /**
    * {@inheritDoc}
    */
   @Override
   public String getBindingType() {

Hopefully, the new binding will make this easier to use (@damihe, @AndrewFG) !

rkrisi · January 27, 2020, 1:58pm

Thanks @5iver!
No I was not able to solve it yet, but I will try with your example!

Thanks!

namraccr · January 28, 2020, 4:34am

That seems like a bug to me. I did a brief scan and couldn’t find a reason why that restriction should exist.

5iver · January 28, 2020, 4:41am

I was hoping you’d take an interest in this one . The binding uses…

private static final String REGEX_FILTER_NAME = "filter-name:'?([A-Za-z\\.\\*\\+\\- \\|]+)'?";

… as its regex, which excludes everything else. As a minimum, I’d add [, ], ?, ^, :, 0-9, and $. I could do a PR, but time is tight. It’s simple though…

private static final String REGEX_FILTER_NAME = "filter-name:'?([!@%&#:0-9A-Za-z\\.\\*\\+\\- \\|\\?\\[\\]\\^\\$]+)'?";

Although, I wonder why characters are being whitelisted instead of blacklisted. Or, why not allow everything?

private static final String REGEX_FILTER_NAME = "filter-name:'(.*)'";

namraccr · January 28, 2020, 5:07am

I agree with allowing all characters.

5iver · January 28, 2020, 5:08am

Here’s the PR…