Error mvn license:format


(Michael Parment) #1

Getting error when running mvn license:format.

C:\Users\micha\Eclipse\openhab2-smhi\git>mvn license:format
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.196 s
[INFO] Finished at: 2019-01-21T16:19:46+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Could not find goal 'format' in plugin org.codehaus.mojo:license-maven-plugin:1.16 among available goals add-third-party, aggregate-add-third-party, aggregate-download-licenses, aggregate-third-party-report, check-file-header, comment-style-list, download-licenses, help, license-list, remove-file-header, third-party-report, update-file-header, update-project-license -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoNotFoundException

(Hilbrand Bouwkamp) #2

Are you in the openhab2-addons directory?

Also run with your binding artifactid to only update your binding:
mvn -pl :<binding artifactId> license:format (Don’t forget the colon before the artifactid!)


(Michael Parment) #3

Have followed our instructions

Note: Currently Eclipse SmartHome and openHAB use different license versions (EPL-2.0 for ESH and EPL-1.0 for OH2). The skeleton templates use the newer EPL-2.0 version. To compile a new openHAB binding without errors, you have to perform the following additional steps:

replace NOTICE with about.html in the build-properties file
run mvn license:format in the root folder of your local Git repository (see coding guidelines A.2)

in https://www.openhab.org/docs/developer/development/bindings.html

/mike


(Hilbrand Bouwkamp) #4

Just to clarify the git directory created by eclipse setup is not the a git repository. The git directory contains 2 or more subdirectories. Each of those subdirectory is a git repository. You need to run this command from within the openhab2-addons directory. (The root of a git repository can be identified by .git directory).

That having said. The documentation is not up to date. guidelines related to the about.html should not be followed. This is related to the license update done very recently. This documentation is in the process to being improved. Help is welcome of course.