In the same Step 7, the link for File Locations seems to be relatively linked, rather than absolutely, so it links to your fork. All other links, except for another in Step 15, are external though, so I over-egged it in my previous post!
I see you’ve added the step into your OP - that’s great, it was the only thing that made me think twice!
Thanks a lot for the quick port to OH3 @CrazyIvan359!
I’ve started from scratch (removed automation folder and use the install steps you’ve described), but I’m still getting the following error:
2021-02-23 21:56:18.463 [INFO ] [ab.core.service.AbstractWatchService] - Loading script '/etc/openhab/automation/jsr223/python/core/000_Startup.py'
2021-02-23 21:56:25.177 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Initialized a custom ScriptEngineFactory for jython (2.7.2): supports python (2.7) with file extensions [py], names [python, jython], and mimetypes [text/python, application/python, text/x-python, application/x-python]
2021-02-23 21:56:25.432 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Added ScriptEngine for language 'py' with identifier: file:/etc/openhab/automation/jsr223/python/core/000_Startup.py
2021-02-23 21:56:25.558 [WARN ] [jython.startup ] -
*******************************************************************************
Jython version: 2.7.2.final
Operating system: Linux
OS Version: 5.10.11-v7l+
Java vendor: Azul Systems, Inc.
Java VM name: OpenJDK Client VM
Java runtime name: OpenJDK Runtime Environment
Java runtime version: 11.0.9+11-LTS
configuration.py installed: False
sys.path: /etc/openhab/automation/lib/python"
/var/lib/openhab/cache/org.eclipse.osgi/258/0/bundleFile/Lib
__classpath__
__pyclasspath__/
*******************************************************************************
2021-02-23 21:56:25.561 [INFO ] [ab.core.service.AbstractWatchService] - Loading script '/etc/openhab/automation/jsr223/python/core/components/100_DirectoryTrigger.py'
2021-02-23 21:56:28.126 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Added ScriptEngine for language 'py' with identifier: file:/etc/openhab/automation/jsr223/python/core/components/100_DirectoryTrigger.py
2021-02-23 21:56:28.174 [ERROR] [ipt.internal.ScriptEngineManagerImpl] - Error during evaluation of script 'file:/etc/openhab/automation/jsr223/python/core/components/100_DirectoryTrigger.py': ImportError: No module named core in <script> at line number 23
2021-02-23 21:56:28.175 [INFO ] [ab.core.service.AbstractWatchService] - Loading script '/etc/openhab/automation/jsr223/python/core/components/100_StartupTrigger.py'
2021-02-23 21:56:29.896 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Added ScriptEngine for language 'py' with identifier: file:/etc/openhab/automation/jsr223/python/core/components/100_StartupTrigger.py
2021-02-23 21:56:29.933 [ERROR] [ipt.internal.ScriptEngineManagerImpl] - Error during evaluation of script 'file:/etc/openhab/automation/jsr223/python/core/components/100_StartupTrigger.py': ImportError: No module named core in <script> at line number 9
It looks like it can’t load the core module, which I’ve correctly placed in /etc/openhab/automation/lib/python/:
╰─$ ll /etc/openhab/automation/lib/python/core
total 128K
-rw-rw-r-- 1 openhab openhab 2.3K Feb 23 21:13 actions.py
-rw-rw-r-- 1 openhab openhab 15K Feb 23 21:13 date.py
-rw-rw-r-- 1 openhab openhab 0 Feb 23 21:13 __init__.py
-rw-rw-r-- 1 openhab openhab 4.8K Feb 23 21:13 items.py
-rw-rw-r-- 1 openhab openhab 2.4K Feb 23 21:13 jsr223.py
-rwxrwxr-x 1 openhab openhab 4.1K Feb 23 21:13 links.py
-rw-rw-r-- 1 openhab openhab 4.0K Feb 23 21:13 log.py
-rw-rw-r-- 1 openhab openhab 13K Feb 23 21:13 metadata.py
drwxrwxr-x 2 openhab openhab 4.0K Feb 23 21:13 osgi
-rw-rw-r-- 1 openhab openhab 5.3K Feb 23 21:13 rules.py
-rw-rw-r-- 1 openhab openhab 2.9K Feb 23 21:13 testing.py
-rwxrwxr-x 1 openhab openhab 40K Feb 23 21:13 triggers.py
-rw-rw-r-- 1 openhab openhab 12K Feb 23 21:13 utils.py
One weird thing though is this line in the startup script’s output: configuration.py installed: False.
I actually have a configuration.py present in /etc/openhab/automation/lib/python/:
╰─$ ll /etc/openhab/automation/lib/python/
total 20K
drwxrwxr-x 3 openhab openhab 4.0K Feb 23 21:40 community
-rw-rw-r-- 1 openhab openhab 2.1K Feb 23 21:21 configuration.py
-rw-rw-r-- 1 openhab openhab 3.8K Feb 23 21:40 configuration.py.example
drwxrwxr-x 3 openhab openhab 4.0K Feb 23 21:13 core
drwxrwxr-x 3 openhab openhab 4.0K Feb 23 21:40 personal
Would there be any cache somewhere with the jython module? (other than the *.$py.class files)
Thanks!
Nevermind, finally found the issue…
I did a manual install of Jython first, so my /etc/default/openhab entry looked like this when I commented it out:
EXTRA_JAVA_OPTS="-Dgnu.io.rxtx.SerialPorts=/dev/ttyZWAVE:/dev/ttyUSB0:/dev/ttyS0:/dev/ttyS2:/dev/ttyACM0:/dev/ttyAMA0" # -Xbootclasspath/a:/etc/openhab/automation/jython/jython-standalone-2.7.0.jar -Dpython.home=/etc/openhab/automation/jython -Dpython.path=/etc/openhab/automation/lib/python"
But apparently the # I used was not taken into account, resulting in the following being used as EXTRA_JAVA_OPTS:
[...snipped...] -Djava.awt.headless=true -Dgnu.io.rxtx.SerialPorts=/dev/ttyZWAVE:/dev/ttyUSB0:/dev/ttyS0:/dev/ttyS2:/dev/ttyACM0:/dev/ttyAMA0# -Xbootclasspath/a:/etc/openhab/automation/jython/jython-standalone-2.7.0.jar -Dpython.home=/etc/openhab/automation/jython -Dpython.path=/etc/openhab/automation/lib/python" --add-reads=java.xml=java.logging [...snipped...]
Notice the commented out part is in the ps output…
First of all thank you very much for picking up the work on Helper Libraries, highly appreciated!
I tried to follow your instructions for Javascript. I set the debug level, took the files from your repo , created the directory structure and tried the HelloWorld.js . However I always get the following error in the logs (last line):
2021-02-24 14:00:47.439 [INFO ] [.core.internal.i18n.I18nProviderImpl] - Time zone set to 'Europe/Berlin'.
2021-02-24 14:00:47.448 [INFO ] [.core.internal.i18n.I18nProviderImpl] - Locale set to 'de_DE'.
2021-02-24 14:00:47.896 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Initialized a generic ScriptEngineFactory for Oracle Nashorn (11.0.2): supports ECMAScript (ECMA - 262 Edition 5.1) with file extensions [js], names [nashorn, Nashorn, js, JS, JavaScript, javascript, ECMAScript, ecmascript], and mimetypes [application/javascript, application/ecmascript, text/javascript, text/ecmascript]
2021-02-24 14:00:47.902 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Initialized a custom ScriptEngineFactory for Oracle Nashorn (11.0.2): supports ECMAScript (ECMA - 262 Edition 5.1) with file extensions [js], names [nashorn, Nashorn, js, JS, JavaScript, javascript, ECMAScript, ecmascript], and mimetypes [application/javascript, application/ecmascript, text/javascript, text/ecmascript]
2021-02-24 14:00:50.877 [WARN ] [org.openhab.core.net.NetUtil ] - Found multiple local interfaces - ignoring 192.168.44.53
2021-02-24 14:01:02.404 [DEBUG] [vider.AbstractResourceBundleProvider] - Parse rules from bundle 'org.openhab.core.automation'
2021-02-24 14:01:02.406 [DEBUG] [vider.AbstractResourceBundleProvider] - Parse rules from bundle 'org.openhab.core.automation.module.script.rulesupport'
2021-02-24 14:01:02.426 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added CoreModuleHandlerFactory
2021-02-24 14:01:02.427 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added TimerModuleHandlerFactory
2021-02-24 14:01:02.428 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added ScriptModuleHandlerFactory
2021-02-24 14:01:02.429 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added ScriptedCustomModuleHandlerFactory
2021-02-24 14:01:02.430 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added ScriptedPrivateModuleHandlerFactory
2021-02-24 14:01:02.431 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added AnnotatedActionModuleTypeProvider
2021-02-24 14:01:02.432 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added AnnotatedThingActionModuleTypeProvider
2021-02-24 14:01:02.433 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added EphemerisModuleHandlerFactory
2021-02-24 14:01:03.907 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Initialized a custom ScriptEngineFactory for null (null): supports Rule DSL (v1) with file extensions null, names null, and mimetypes [application/vnd.openhab.dsl.rule]
2021-02-24 14:01:03.991 [INFO ] [.core.model.lsp.internal.ModelServer] - Started Language Server Protocol (LSP) service on port 5007
2021-02-24 14:01:05.207 [DEBUG] [e.automation.internal.RuleEngineImpl] - ModuleHandlerFactory added MediaModuleHandlerFactory
2021-02-24 14:01:05.383 [INFO ] [org.openhab.ui.internal.UIService ] - Started UI on port 8080
2021-02-24 14:01:07.538 [INFO ] [ab.core.service.AbstractWatchService] - Loading script '/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js'
2021-02-24 14:01:07.575 [INFO ] [e.automation.internal.RuleEngineImpl] - Rule engine started.
2021-02-24 14:01:08.024 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Added ScriptEngine for language 'js' with identifier: file:/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js
2021-02-24 14:01:08.545 [ERROR] [ipt.internal.ScriptEngineManagerImpl] - Error during evaluation of script 'file:/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js': java.lang.ClassNotFoundException: org.eclipse.smarthome.model.script.actions.ScriptExecution cannot be found by org.openhab.core.automation.module.script_3.1.0.202102210257
So apparently there are still some outdated pieces of code that try to access objects in the eclipse.smarthome namespace.
Do you know how I can fix that?
Ok, figured the first problem out by myself, I had to replace eclipse.smarthome with openhab.core
However, now I am facing the next error:
2021-02-24 15:47:56.247 [INFO ] [ab.core.service.AbstractWatchService] - Loading script '/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js'
2021-02-24 15:47:57.070 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Added ScriptEngine for language 'js' with identifier: file:/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js
2021-02-24 15:47:57.821 [ERROR] [ipt.internal.ScriptEngineManagerImpl] - Error during evaluation of script 'file:/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js': java.lang.ClassNotFoundException: org.apache.commons.io.IOUtils cannot be found by org.openhab.core.automation.module.script_3.1.0.202102210257
2021-02-24 15:48:01.276 [INFO ] [e.automation.internal.RuleEngineImpl] - Rule engine started.
So basically org.apache.commons.io.IOUtils cannot be found. This is referenced in utils.js. But in what way do I have to change the code?
Ok, i now replaced all core files with the files from “js-rewrite”-branch. Now my rule at least stops throwing errors:
2021-02-24 16:48:11.678 [INFO ] [org.openhab.ui.internal.UIService ] - Started UI on port 8080
2021-02-24 16:48:12.046 [INFO ] [ab.ui.habpanel.internal.HABPanelTile] - Started HABPanel at /habpanel
2021-02-24 16:48:12.902 [INFO ] [ab.core.service.AbstractWatchService] - Loading script '/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js'
2021-02-24 16:48:13.515 [DEBUG] [ipt.internal.ScriptEngineManagerImpl] - Added ScriptEngine for language 'js' with identifier: file:/C:/OH310_~1/conf/automation/jsr223/javascript/personal/HelloWorld.js
2021-02-24 16:48:17.947 [INFO ] [e.automation.internal.RuleEngineImpl] - Rule engine started.
So far, so good. However the rule is not working, there are no log entries produced by the rule. Here is my modified rule source code:
'use strict';
var OPENHAB_CONF = Java.type("java.lang.System").getenv("OPENHAB_CONF");
load(OPENHAB_CONF+'/automation/lib/javascript/core/rules.js');
load(OPENHAB_CONF+'/automation/lib/javascript/core/triggers.js');
load(OPENHAB_CONF+'/automation/lib/javascript/core/log.js');
var me = "HelloWorld.js";
rule({
name: "Javascript Hello World (GenericCronTrigger raw API with JS helper libraries)",
description: "This is an example Jython cron rule using the raw API",
triggers: [
CronTrigger("0/10 * * * * ?")
],
execute: function( module, inputs){
logInfo("Hello World!");
}
});
Thank you for any help or guidance!
@openhabbe glad you got it sorted, I wasn’t sure what to suggest. Thank you for the detailed information in your initial request and for explaining what the fix was. I guess inline comments don’t work, only full line ones.
@vossivossi as you correctly determined you need to use the js-rewrite branch, which the link in my paragraph about JS should link to (does it not?)
That branch is a work in progress and contains several breaking changes. For anyone with current JS rules they will not work as the old rule function has been replaced with one that mimics the Python decorator.
I believe I put an example in the rule and when decorators. The syntax is similar to the Python functions but because there is no concept of a decorator in ES5 you have to call the functions on your rule function. I will post examples when I am in front of a computer.
Unfortunately the link points to the “ivans-updates” branch, which still includes the old libs.
Ok, that explains it 
That would be highly appreciated. Thank you very much for this contribution!
Had to fix some code in idealarm as well to make it work (mainly jodatime refs).
I’ll take the time to make a PR to your repo 
@openhabbe a PR is welcome, I have not touched any examples or community libraries yet. Please make sure to keep changes backwards compatible with OH2. If you aren’t sure how to do that, submit your PR that works on OH3 and I will take a look and tell you what to do to make it work on both.
Thanks, I will fix that. I added some additional links to the instructions and didn’t think to change the links for JS.
@vossivossi I have updated the first post to include a complete example rule file using the new syntax.
Just looking at implementing this version of the Python/Jython OH Helper libraries on a dev machine and I’ve noticed that the RuleSimple.pyi file has been truncated in GitHub.
Thank you very much, that was really helpful. I have my first Javascript Rule up and running
Great Work!
@nick_wootton turns out it was just a missing ), all fixed now. Thanks again for spotting that.
Just one additional question: I noticed that the file based JS rules are not displayed correctly in the OH Main UI. Only the trigger is displayed correctly, but not the source code:
Contrary to this, all my old file based Rules DSL rules are recognized by their type (vnd.openhab.dsl.rule) and show the source code:
The same problem exists when I access the rules via the REST API (which of course is the same what the Main UI does). The info for source code (actionscript) and rule type (actiontype) are not filled. Is there a chance to improve this? For JS rules that are defined via Main UI this information is displayed correctly, the problem exists only with file based JS rules with the helper libraries.
Just to clarify: The rules run perfectly, they are just not accessible through the UI or the REST API.
@vossivossi that is going to require some digging… Could you open an issue on github for this, I will take a closer look when I have time.
Thank you for the work on this - I did a PR to update the documentation from referring to openhab2 in the directory structure.
It seems that the directory watcher for .py files only watches under the automation directory vs the lib directory.
Mike
