Max min temp issues after updating to 3.0

[paulmann (Brian Paulmann)]

I get this eurro also

2021-01-25 13:24:18.661 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘tempcarp-1’ failed: ‘toDateMidnight’ is not a member of ‘java.time.ZonedDateTime’; line 22, column 65, length 18 in tempcarp

[paulmann (Brian Paulmann)]

do you know how do set this up as when it worked in OH2 with rrd4j, there was no jbdc.cgf file to set up in OH2

[rossko57]

The jdbc.cfg file seems to missing the mandatorry url= parameter, just as it said.

If you do not want to use jdbc persistence, uninstall it.

If you want to use rrd4j persistence install that. It should be installed by default in OH3, but clearly something has been messed about with here.

These are different services that you choose.

[rossko57]

@paulmann

get this eurro also

You have not used the suggestion already given

Max min temp issues after updating to 3.0

Yes, you need to replace now.toDateMidnight with now.with(LocalTime.MIN)

[paulmann (Brian Paulmann)]

now the rrd4j is saving new data (se picture) but my sitemap does not display the data

Sitemap

Text label=“Temperatur” icon=“temperature” {
Text item=Date icon=“calendar”
Text item=Temperatur_Udebygninger_Carportnord label=“Temperatur Udvendig [%.1f °C]”
Text item=Temperatur_Udebygninger_Carport label=“Temperatur Carport [%.1f °C]”
Text item=Temperature_Terrasse label=“Terrasse temperature [%.2f °C]” icon=“temperature”
Text item=Humidity_Terrasse label=“Terrasse Humidity [%.1f %%]” icon=“humidity”
Text item=Temperatur_Udebygninger_Carportnord_Min label=“Min temperatur Udvendig [%s]”
Text item=Temperatur_Udebygninger_Carportnord_Max label=“Max temperatur Udvendig [%s]”
Text item=Temperatur_Udebygninger_Carport_Min label=“Min temperatur carport [%s]”
Text item=Temperatur_Udebygninger_Carport_Max label=“Max temperatur carport [%s]”
Text item=Temperature_Terrasse_Min label=“Min temperatur Terrasse [%s]”
Text item=Temperature_Terrasse_Max label=“Max temperatur Terrasse [%s]”
}

items

Number Temperature_Vaerksted “Temperatur værksted [%.2f °C]” { channel=“mqtt:topic:mybroker:mything:Temperature_VaerkstedChannel” }
Number Humidity_Vaerksted “Humidity [%.1f %%]” { channel=“mqtt:topic:mybroker:mything:Humidity_VaerkstedChannel” }
Number Temperature_Terrasse “Temperatur Terrasse [%.2f °C]” (gHistory) { channel=“mqtt:topic:mybroker:mything2:Temperature_TerasseChannel” }
String Temperature_Terrasse_Min “- Min. Temp [%.1f °C]”
String Temperature_Terrasse_Max “- Max. Temp [%.1f °C]”
Number Humidity_Terrasse “Humidity [%.1f %%]” (gHistory) { channel=“mqtt:topic:mybroker:mything2:Humidity_TerasseChannel” }

[rossko57]

What does your sitemap show?
Have you checked in your events.log that an Item is getting updated with data that you expect?

[paulmann (Brian Paulmann)]

2021-01-25 14:34:50.043 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.43 to 0.5
2021-01-25 14:37:59.059 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.5 to 0.56
2021-01-25 14:41:29.058 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carport’ changed from 1.43 to 1.5
2021-01-25 14:41:29.078 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.56 to 0.62
2021-01-25 14:44:59.077 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carport’ changed from 1.5 to 1.43
2021-01-25 14:44:59.095 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.62 to 0.56
2021-01-25 14:48:08.111 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.56 to 0.5
2021-01-25 14:51:38.128 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.5 to 0.43
2021-01-25 15:04:56.183 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carport’ changed from 1.43 to 1.5
2021-01-25 15:04:56.202 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.43 to 0.5
2021-01-25 15:08:26.219 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.5 to 0.56
2021-01-25 15:11:35.236 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.56 to 0.62
2021-01-25 15:15:05.238 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carport’ changed from 1.5 to 1.43
2021-01-25 15:15:05.255 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.62 to 0.56
2021-01-25 15:18:14.271 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carportnord’ changed from 0.56 to 0.5

[rossko57]

So, your device linked Items work fine, but the ones that should be calculated by rule do not?
Sounds like your rule is not working.
Have you fixed the rule error?

[paulmann (Brian Paulmann)]

I dont know but the rule is here

import java.text.SimpleDateFormat
import java.time.format.DateTimeFormatter
import org.eclipse.smarthome.core.library.types.DecimalType
import org.joda.datetime.DateTime.*
rule “Temperatur Min-og Max values Carportnord”
when
Time cron “0/60 * * * * ?”
then
var Number Min
var Number Max
var String tmp
var SimpleDateFormat df = new SimpleDateFormat( “HH:mm” )
if (Temperatur_Udebygninger_Carportnord.state instanceof DecimalType) {
Min = (Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN), “rrd4j”).state as DecimalType)
tmp = (Math::round(Min.floatValue10.0)/10.0) + " °C (" + df.format(Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN, “rrd4j”).timestamp) + " )"
postUpdate(Temperatur_Udebygninger_Carportnord_Min, tmp)
Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType
df = new SimpleDateFormat( “HH:mm” )
tmp = (Math::round(Max.floatValue10.0)/10.0) + " °C (" + df.format(Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX), “rrd4j”).timestamp) + “)”
postUpdate(Temperatur_Udebygninger_Carportnord_Max, tmp)
}
end

[paulmann (Brian Paulmann)]

when i check the rrd4j file i get this

[rossko57]

@paulmann

I dont know but the rule is here

Okay, let us know when you’ve added some logInfo() to see progress through the rule and some values, as previously advised.

I see the unwanted imports are back again.

[paulmann (Brian Paulmann)]

i get this now in the log

2021-01-25 20:58:16.358 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model ‘tempudv.rules’ has errors, therefore ignoring it: [21,13]: missing ‘)’ at ‘postUpdate’

[24,13]: missing ‘)’ at ‘df’

rule is now

import java.text.SimpleDateFormat
import java.time.format.DateTimeFormatter
//import org.eclipse.smarthome.core.library.types.DecimalType
//import org.joda.datetime.DateTime.*
rule “Temperatur Min-og Max values Carportnord”
when
Item Temperatur_Udebygninger_Carportnord received update
then
var Number Min
var Number Max
var String tmp
var SimpleDateFormat df = new SimpleDateFormat( “HH:mm” )
if (Temperatur_Udebygninger_Carportnord.state instanceof DecimalType) {
logInfo(“test”, "TempUC " + Temperatur_Udebygninger_Carportnord.state.toString)
Min = (Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN), “rrd4j”).state as DecimalType)
logInfo(“test”, “Min " + Min.toString)
tmp = (Math::round(Min.floatValue10.0)/10.0) + " °C (" + df.format(Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN, “rrd4j”).timestamp) + " )"
postUpdate(Temperatur_Udebygninger_Carportnord_Min, tmp)
Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType
df = new SimpleDateFormat( “HH:mm” )
tmp = (Math::round(Max.floatValue10.0)/10.0) + " °C (” + df.format(Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX), “rrd4j”).timestamp) + “)”
postUpdate(Temperatur_Udebygninger_Carportnord_Max, tmp)
}
end

[rossko57]

@paulmann

missing ‘)’ at ‘postUpdate’

Okay, it is telling you it bumped into postUpdate when it expected to find a ) bracket.

@paulmann

df.format(Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN, “rrd4j”).timestamp) + " )"
postUpdate(Temperatur_Udebygninger_Carportnord_Min, tmp)

In the line before the postUpdate, there are three opening brackets ((( but only two closing brackets )).
The bracket hidden inside a string “)” does not count for this.

[paulmann (Brian Paulmann)]

I hove now change to this (see rule)

but i stil have no data in my sitemap but i get this in the log

==> /var/log/openhab/events.log <==
2021-01-26 06:43:01.023 [INFO ] [openhab.event.ItemStateChangedEvent ] - Item ‘Temperatur_Udebygninger_Carport’ changed from -1.37 to -1.43
==> /var/log/openhab/openhab.log <==
2021-01-26 06:43:01.597 [INFO ] [org.openhab.core.model.script.test ] - TempUC -2.81
2021-01-26 06:43:01.602 [INFO ] [org.openhab.core.model.script.test ] - Min -5.0
2021-01-26 06:43:01.603 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘tempudv-1’ failed: An error occurred during the script execution: Could not invoke method: java.time.ZonedDateTime.with(java.time.temporal.TemporalField,long) on instance: 2021-01-26T06:43:01.603275+01:00[Europe/Copenhagen] in tempudv

Rule

import java.text.SimpleDateFormat
rule “Temperatur Min-og Max values Carportnord”
when
Item Temperatur_Udebygninger_Carportnord received update
then
var Number Min
var Number Max
var String tmp
var SimpleDateFormat df = new SimpleDateFormat( “HH:mm” )
if (Temperatur_Udebygninger_Carportnord.state instanceof DecimalType) {
logInfo(“test”, "TempUC " + Temperatur_Udebygninger_Carportnord.state.toString)
Min = (Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN), “rrd4j”).state as DecimalType)
logInfo(“test”, “Min " + Min.toString)
tmp = (Math::round(Min.floatValue10.0)/10.0) + " °C (" + df.format(Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN, “rrd4j”).timestamp) + “)”)
postUpdate(Temperatur_Udebygninger_Carportnord_Min, tmp)
Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType )
df = new SimpleDateFormat( “HH:mm” )
tmp = (Math::round(Max.floatValue10.0)/10.0) + " °C (” + df.format(Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).timestamp) + “)”)
postUpdate(Temperatur_Udebygninger_Carportnord_Max, tmp)
}
end

[rossko57]

Some more logInfo() would have been useful to establish progress and sensible value being returned, you can see how to do this, but let’s go with what we’ve got.

@paulmann

Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType )
df = new SimpleDateFormat( “HH:mm” )
tmp = (Math::round(Max.floatValue10.0)/10.0) + " °C (” + df.format(Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).timestamp) + “)”)

Let’s have a tidy up here, you only need to do the maximumSince once.

Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType )
df = new SimpleDateFormat( “HH:mm” )
tmp = (Math::round(Max.floatValue</em> 10.0)/10.0) + " °C (” + df.format(Max.timestamp) + “)”)

Now it’s bit clearer to see what is going on in this part.

First thing I see is wrong quotemark types. That may be an artefact of copy-pasting, I can’t tell because you have not used code fences, but let’s fix it.

Next thing is the df=, you already did that at the beginning of the rule and it has not changed, so no need to do it again just leave it out.

Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType )
tmp = (Math::round(Max.floatValue</em> 10.0)/10.0) + " °C (" + df.format(Max.timestamp) + ")")

Next thing is this

tmp = (Math::round(Max.floatValue10.0)/10.0) ...

What’s the floatValue10.0? Is that a copy-paste error? Is this really where the previous brackets error came from?
Let’s guess it’s supposed to be

tmp = (Math::round(Max.floatValue/10.0) + " °C (" + df.format(Max.timestamp) + ")")

Alright, so something going wrong to do with DateTime

@paulmann

An error occurred during the script execution: Could not invoke method: java.time.ZonedDateTime.with(java.time.temporal.TemporalField,long)

so that has to be failing in
df.format(Max.timestamp)

The log also shows us the string that we get from persistence timestamp
2021-01-26T06:43:01.603275+01:00[Europe/Copenhagen]

That looks like a zonedDateTime to me, and I think you’ll need a different formatter to get your “HH:MM”. I really don’t know.
Change of times was one of the OH3 changes, due to Java 11 changes.

[paulmann (Brian Paulmann)]

I have change to this

import java.text.SimpleDateFormat

rule "Temperatur Min-og Max values Carportnord"

when

        Item Temperatur_Udebygninger_Carportnord received update

then

        var Number Min

        var Number Max

        var String tmp

        var SimpleDateFormat df = new SimpleDateFormat( "HH:MM" ) 

        if (Temperatur_Udebygninger_Carportnord.state instanceof DecimalType) {

                logInfo("test", "TempUC " + Temperatur_Udebygninger_Carportnord.state.toString)

            Min = (Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN), "rrd4j").state as DecimalType)

            logInfo("test", "Min " + Min.toString)

            tmp = (Math::round(Min.floatValue*10.0)/10.0) + " °C (" + df.format(Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN, "rrd4j").timestamp) + ")")

            postUpdate(Temperatur_Udebygninger_Carportnord_Min, tmp)

                Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, “rrd4j”).state as DecimalType )

                tmp = (Math::round(Max.floatValue/10.0) + " °C (" + df.format(Max.timestamp) + ")")

                postUpdate(Temperatur_Udebygninger_Carportnord_Max, tmp)

        }

end

and now i get this in the log

2021-01-27 05:48:26.982 [INFO ] [el.core.internal.ModelRepositoryImpl] - Loading model ‘tempudv.rules’
2021-01-27 05:48:27.004 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model ‘tempudv.rules’ has errors, therefore ignoring it: [21,96]: no viable alternative at input ‘“’
[21,97]: mismatched input ‘rrd4j’ expecting ‘)’
[21,126]: mismatched input ‘)’ expecting ‘end’

[paulmann (Brian Paulmann)]

the " was not rigtht at the “rrd4j”
so now i have this error in the log

2021-01-27 07:30:39.023 [ERROR] [internal.handler.ScriptActionHandler] - Script execution of rule with UID ‘tempudv-1’ failed: An error occurred during the script execution: Could not invoke method: java.time.ZonedDateTime.with(java.time.temporal.TemporalField,long) on instance: 2021-01-27T07:30:39.023015+01:00[Europe/Copenhagen] in tempudv

the rule code is now

import java.text.SimpleDateFormat

rule "Temperatur Min-og Max values Carportnord"

when

        Item Temperatur_Udebygninger_Carportnord received update

then

        var Number Min

        var Number Max

        var String tmp

        var SimpleDateFormat df = new SimpleDateFormat( "HH:MM" ) 

        if (Temperatur_Udebygninger_Carportnord.state instanceof DecimalType) {

                logInfo("test", "TempUC " + Temperatur_Udebygninger_Carportnord.state.toString)

            Min = (Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN), "rrd4j").state as DecimalType)

            logInfo("test", "Min " + Min.toString)

            tmp = (Math::round(Min.floatValue*10.0)/10.0) + " °C (" + df.format(Temperatur_Udebygninger_Carportnord.minimumSince(now.with(LocalTime.MIN, "rrd4j").timestamp) + ")")

            postUpdate(Temperatur_Udebygninger_Carportnord_Min, tmp)

                Max = Temperatur_Udebygninger_Carportnord.maximumSince(now.with(LocalTime.MAX, "rrd4j").state as DecimalType )

                tmp = (Math::round(Max.floatValue/10.0) + " °C (" + df.format(Max.timestamp) + ")")

                postUpdate(Temperatur_Udebygninger_Carportnord_Max, tmp)

        }

end

[rossko57]

Yes, you need to find out how to format a zonedDateTime type object (the .timestamp from your persistence) into the “HH:MM” that you want. I don’t know that.

[paulmann (Brian Paulmann)]

@rossko57

zonedDateTime

Ok, I’ll try to see if I can find something about how I do it

[rossko57]

I think you can do something like this

DateTime Conversion (openHAB 3.x)

Would someone be able to tell me what I’m doing wrong. Have been stuck on this for ages. I’m trying to parse an almost ISO format string into a DateTime item but get the error Text ‘2021-01-16 20:05:10 +0000’ could not be parsed at index 20 in … var String str = "2021-01-16 20:05:10 +0000" var formatter = java.time.format.DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss z"); postUpdate( ApcDate, ZonedDateTime.parse( str, formatter ) ) Thanks

using DateTimeFormatter but I don’t know how to use it.

Guessing:

val hmformat = java.time.format.DateTimeFormatter.ofPattern("HH:mm");
...  .timestamp.format(hmformat) + ...