[Merged] Contributing without github account? Add new sources for Denon DRA-100

Can I kindly ask to include the attached patch for openhab-addons? I don’t want to login to my deactivated github account for reasons that I can gladly discuss, but not here.

0001-Extend-denonmarantz-binding-to-include-Denon-DRA-100.patch.txt (3.5 KB)

txt added to allow upload to the forum. I hope that the patch is good enough quality, but please point out all errors - I’m new to openHAB development.

The patch extends list of available sources (Optical 1 & 2, Bluetooth, etc) for Denon DRA-100.

Gentle bump?

Sorry, but the community is not the right place for such a request.
You could find the codeowner of the binding in codeowners file and see if he/she is listed as a user here. Then you could ask to include your patch.

If you ask why, it simply does not fit into our review process. We need properly signed pull requests.

1 Like

Thank you for the explanation! I’ll do as you suggested.

@Kai and @MrRimmer @Confectrician @wborn

Can I kindy ask you for help? It would be great if you could review my patch. Please strip my signature from the patch if required or replace with Author field if that’s used by the community.

@PrzemoF I have created [denonmarantz] Extend denonmarantz binding to include Denon DRA-100 sources by kaikreuzer · Pull Request #15539 · openhab/openhab-addons · GitHub for you.

1 Like

Thank you very much! I use my modified code for the last 2 months, so I guess it’s safe to include.

Thanks for the help! Patch merged :slight_smile: