New Netatmo binding (starting OH 3.3 M5)

AndyMt · February 29, 2024, 9:21pm

Found a comment here:

github.com/openhab/openhab-addons

[shelly] Log "spam" after upgrade to openHAB 3.4 from 3.3

opened 08:12PM - 21 Dec 22 UTC

closed 12:24PM - 30 Jan 23 UTC

unf

bug

## Expected Behavior No warning messages. ## Current Behavior After upgradi…ng openHAB & addon packages from version 3.3 onto 3.4 my log files are "spamed" with thoses messages: ``` ... 2022-12-21 19:51:50.188 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler ShellyRelayHandler tried updating the thing status although the handler was already disposed. 2022-12-21 19:51:50.191 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler ShellyRelayHandler tried updating the thing status although the handler was already disposed. ... ``` No comparable messages in previous version 3.3, not even before of that in 3.2. ## Steps to Reproduce (for Bugs) 1. Stop openhab instance and restart it without Shelly binding, none of those warning in log. 2. Stop openhab instance again, restart with Shelly binding, the messages are again flooding log files. ## Context It is impossible to live read log files, on CLI or on WebIF PaperUI due to message flooding and depended things, more IO to SD-Card, size of log files, more log file switches, outrunning history etc. ## Your Environment openHABian (64-bit) 1.7.x, Raspberry Pi 4 with EnOcean Pi. ``` binding = astro,avmfritz,enocean,hpprinter,network,ntp,openweathermap,shelly,vdr,yamahareceiver misc = homekit persistence = mapdb transformation = scale ui = basic,habpanel ```

I take a quick look to the code and I can see that initialize in class ShellyBaseHandler is scheduling a thread 2 seconds later but this thread is not cancelled later, in particular in case dispose is called for any reason by the thing manager. In that case, the thread will run while the thing handler was already disposed !
I think the reason of this issue is there and it was easy to find.

I also noticed that initialize is not setting any thing status before returning, while it should. Edit: it is set at the very beginning of the init job, so it should be not so bad.