Hello,
I have updated my binding’s marketplace page to offer the latest version
Unfortunately, that update does not come up inside my openHab instance nor in my user’s ones either, as reported here
Is there something else that I should do besides updating the marketplace topic?
Can you try with four digit version numbers?
Would you have an example for this?
I’m using semver here which calls for x.y.z for release versions and x.y.z-tag for others and I don’t see how I could add a fourth number, let alone why it worked in the past and not anymore today.
Ah, I see.
How often are changes taken into account? I’m not seeing any change in my openHab instance.
Also, when was this change announced?
Only a small minority of the marketplace bundles are using the x.y.z.t format so I suppose many are not aware of that new requirement.
My understanding is that four digit version numbers have been supported since support for version ranges in the titles of the posts were added in the first place. It’s not necessarily required to use four digit version numbers but I’ve found that when using ) in particular they become necessary. Maybe there is a bug or something that no one has looked into.
But I’ve had to use four digits for my rule templates since 4.0. IIRC it wasn’t really announced anywahre that I saw and I don’t think it was caused by any changes made to OH code. Maybe it changed somewhere upstream?
I think the browser caches the web pages. If you force a reload it should show up. Because changing the title also changes the URL, the browser probably doesn’t know the page changed.
Sadly, forcing reload(s) did not change a single thing.
The URL is using the topic ID which doesn’t change with an edit (154355 in my case) so there is no change to be detected just with the URL.
The more I work on this, the more it seems updates to a marketplace binding are never pushed to an already installed plugin instance. Not sure why nor how, but that’s what I observe from here with my two bindings.
Indeed, the process is to remove then readd. An update does not get installed automatically. You have to remove and readd.
For me usually when I remove the add-on and refresh MainUI the changes will show up. The changes do not show up until I remove the add-on though.
This is really counter intuitive and I feel it would be much better if a notification would show up informing about an update for marketplace bindings.
Right now, at best users do not see the update, at worst, they complain about it not being available.
Add that to the perceived risk of loosing elements by removing a binding, and people will never actually update…
All I can say is I’m sure a PR would be accepted to change how this works. For now, this is how it has always worked and will continue to work until someone submits a change.
However, keep in mind that automatiaclly updating may not be the best choice across all the marketplace categories. Users of a widget, rule tempalte, block library, or hopefully soon transformations may not want it to be updated, and unlike with bindings, these are not necessarily tied as closely to the OH version as add-ons are.
I don’t even know where to look at, whether the issue stems from the forum parser or the marketplace code inside openHAB itself.
That’s definitely not what I’m suggesting, all I want is a notification telling me that an update is available.
I would imagine there’s need to be changes in OH core to look for these changes, creation of a new API endpoint to report the changes, and changes to MainUI to pop up a message, toast or other somesuch when a change is detected.
Without the MainUI stuff, maybe just some changes in core to add a log statement when a change is detected. You’ll have to figure out when to check for changes and stuff like that too.