Hi All
Not sure who to address this to now - but the Builds are failing again - My previous thread is closed so could not just tag in on to the end.
Thanks
Mark
In logs:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project org.openhab.binding.zigbee: Compilation failure: Compilation failure:
[ERROR] /var/jenkins_home/workspace/sandbox-openhab5-release/org.openhab.binding.zigbee/org.openhab.binding.zigbee/src/main/java/org/openhab/binding/zigbee/discovery/ZigBeeNodePropertyDiscoverer.java:[141,25] Null type mismatch: required 'com.zsmartsystems.zigbee.zcl.@NonNull ZclCluster' but the provided value is null
[ERROR] /var/jenkins_home/workspace/sandbox-openhab5-release/org.openhab.binding.zigbee/org.openhab.binding.zigbee/src/main/java/org/openhab/binding/zigbee/discovery/ZigBeeNodePropertyDiscoverer.java:[246,25] Null type mismatch: required 'com.zsmartsystems.zigbee.zcl.@NonNull ZclCluster' but the provided value is null
Started failing 27.01.2025, but I don’t see anything merged in the Zigbee binding repository for the last two weeks, so something else must have triggered it.
I’m not sure, why I think it might be related to:
https://github.com/openhab/openhab-core/pull/4406
The reason is that in:
https://github.com/openhab/openhab-addons/pull/17515
There are changes like this:
if (measures != null) {
List<@Nullable Measure> nullableMeasuresWithoutNulls = measures.stream().filter(Objects::nonNull).toList();
List<Measure> measuresWithoutNulls = new ArrayList<>(nullableMeasuresWithoutNulls.size());
for (@Nullable
Measure m : nullableMeasuresWithoutNulls) {
if (m != null) {
measuresWithoutNulls.add(m);
}
}
return measuresWithoutNulls;
}
being changed to:
return measures.stream().filter(Objects::nonNull).toList();
The lines failing in the Zigbee repository are similar:
and:
@laursen Fix proposed here:
https://github.com/openhab/org.openhab.binding.zigbee/pull/900
Thanks for staying vigilant!
I have passed it on here: