Mark_VG
January 30, 2025, 11:24am
1
Hi All
Not sure who to address this to now - but the Builds are failing again - My previous thread is closed so could not just tag in on to the end.
Thanks
laursen
January 30, 2025, 4:04pm
2
In logs :
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project org.openhab.binding.zigbee: Compilation failure: Compilation failure:
[ERROR] /var/jenkins_home/workspace/sandbox-openhab5-release/org.openhab.binding.zigbee/org.openhab.binding.zigbee/src/main/java/org/openhab/binding/zigbee/discovery/ZigBeeNodePropertyDiscoverer.java:[141,25] Null type mismatch: required 'com.zsmartsystems.zigbee.zcl.@NonNull ZclCluster' but the provided value is null
[ERROR] /var/jenkins_home/workspace/sandbox-openhab5-release/org.openhab.binding.zigbee/org.openhab.binding.zigbee/src/main/java/org/openhab/binding/zigbee/discovery/ZigBeeNodePropertyDiscoverer.java:[246,25] Null type mismatch: required 'com.zsmartsystems.zigbee.zcl.@NonNull ZclCluster' but the provided value is null
Started failing 27.01.2025, but I don’t see anything merged in the Zigbee binding repository for the last two weeks, so something else must have triggered it.
I’m not sure, why I think it might be related to:
openhab:main ← holgerfriedrich:k447
opened 11:23PM - 05 Oct 24 UTC
This PR upgrades to the recently released Karaf version 4.4.7 🎉 and lifts Xtext/… Xtend to 2.37.0.
Additionally, it removes workaround #4526 which should no longer be necessary.
This consists of 3 commits, PLEASE DO NOT SQUASH during merge.
Fixes #4283
Fixes various CVEs in BouncyCastle 1.77, Jetty, etc.
Upgrade Karaf from 4.4.6 to 4.4.7
* Sync runtime dependencies with Karaf 4.4.7, most notably:
* PaxWeb 8.0.30
* Jetty 9.4.56.v20240826
* BouncyCastle 1.78.1
* CXF 3.6.4
* Jackson 2.18.2
* JNA 5.16.0
* JAXB 2.3.9
* commons-io 2.17.0
* commons-lang3 3.17.0
* XBean 4.26
* ASM 9.7.1
* PaxLogging 2.2.8
* Resolve itest runbundles
Upgrade Xtext/Xtend to 2.37.0
* Upgrade Xtext/Xtend from 2.36.0 to 2.37.0, see release notes:
https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2024/11/19/version-2-37-0
https://eclipse.dev/Xtext/xtend/releasenotes.html#/releasenotes/2024/11/19/version-2-37-0
* Upgrade dependencies
* ecj from 3.36.0 to 3.39.0
* gson from 2.10.1 to 2.11.0
* classgraph to 4.8.176
* guava from 3.33.0 to 3.33.1
<!--
Thanks for contributing to the openHAB project!
Please describe the goal and effect of your PR here.
Pay attention to the below notes and to *the guidelines* for this repository.
Feel free to delete any comment sections in the template (starting with "<!--").
ATTENTION: Don't use "git merge" when working with your pull request branch!
This can clutter your Git history and make your PR unusable.
Use "git rebase" instead. See this forum post for further details:
https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358
All PRs should be created using the "main" branch as base.
Important bugfixes are cherry-picked by maintainers to the patch release branch after a PR has been merged.
If your PR's code is not backward compatible with previous releases (which
should be avoided), add a message to the release notes by filing another PR:
https://github.com/openhab/openhab-distro/blob/main/distributions/openhab/src/main/resources/bin/update.lst
# Title
Provide a short summary in the *Title* above. It will show up in the release notes.
For example:
- Introduce metadata for all add-ons
- Fix memory leak in ScriptedRuleProvider
# Description
Please give a few sentences describing the overall goals of the pull request.
Give enough details to make the improvement and changes of the PR understandable
to both developers and tech-savy users.
Please keep the following in mind:
- What is the classification of the PR, e.g. Bugfix, Improvement, Novel Addition, ... ?
- Did you describe the PRs motivation and goal?
- Did you provide a link to any prior discussion, e.g. an issue or community forum thread?
- Did you describe new features for the end user?
- Did you describe any noteworthy changes in usage for the end user?
- Was the documentation updated accordingly, e.g. the Core README?
- Does your contribution follow the coding guidelines:
https://www.openhab.org/docs/developer/guidelines.html
- Did you check for any (relevant) issues from the static code analysis?
- Did you sign-off your work:
https://www.openhab.org/docs/developer/contributing.html#sign-your-work
If your pull request contains a new contribution, it will likely take some time
before it is reviewed and processed by maintainers.
-->
The reason is that in:
openhab:main ← holgerfriedrich:k447
opened 10:36AM - 06 Oct 24 UTC
Depends on Karaf 4.4.7 upgrade of core, openhab/openhab-core#4406.
I updated a … few commons libs in the addons as well to keep it in sync with core. Hope this does not break something.
* Sync runtime dependencies with Karaf 4.4.7, most notably:
* PaxWeb 8.0.30
* Jetty 9.4.57.v20241219
* BouncyCastle 1.78.1
* CXF 3.6.4
* Jackson 2.18.2
* JNA 5.16.0
* JAXB 2.3.9
* commons-io 2.17.0
* commons-lang3 3.17.0
* commons-logging 1.3.4
* ASM 9.7.1
* PaxLogging 2.2.8
* Resolve itest runbundles
* Adapt to core change, xtext dependencies
* gson 2.11.0
* guava 3.33.1
* ecj 3.39.0
* Fix newly introduced compilation and test issues in bindings
<!--
Thanks for contributing to the openHAB project!
Please describe the goal and effect of your PR here.
Pay attention to the below notes and to *the guidelines* for this repository.
Feel free to delete any comment sections in the template (starting with "<!--").
ATTENTION: Don't use "git merge" when working with your pull request branch!
This can clutter your Git history and make your PR unusable.
Use "git rebase" instead. See this forum post for further details:
https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358
All PRs should be created using the "main" branch as base.
Important bugfixes are cherry-picked by maintainers to the patch release branch after a PR has been merged.
Add one or more appropriate labels to make your PR show up in the release notes.
E.g. enhancement, bug, documentation, new binding
This can only be done by yourself if you already contributed to this repo.
If your PR's code is not backward compatible with previous releases (which
should be avoided), add a message to the release notes by filing another PR:
https://github.com/openhab/openhab-distro/blob/main/distributions/openhab/src/main/resources/bin/update.lst
# Title
Provide a short summary in the *Title* above. It will show up in the release notes.
For example:
- [homematic] Improve communication with weak signal devices
- [timemachine][WIP] Initial contribution
# Description
Please give a few sentences describing the overall goals of the pull request.
Give enough details to make the improvement and changes of the PR understandable
to both developers and tech-savy users.
Please keep the following in mind:
- What is the classification of the PR, e.g. Bugfix, Improvement, Novel Addition, ... ?
- Did you describe the PRs motivation and goal?
- Did you provide a link to any prior discussion, e.g. an issue or community forum thread?
- Did you describe new features for the end user?
- Did you describe any noteworthy changes in usage for the end user?
- Was the documentation updated accordingly, e.g. the add-on README?
- Does your contribution follow the coding guidelines:
https://www.openhab.org/docs/developer/guidelines.html
- Did you check for any (relevant) issues from the static code analysis:
https://www.openhab.org/docs/developer/bindings/#include-the-binding-in-the-build
- Did you sign-off your work:
https://www.openhab.org/docs/developer/contributing.html#sign-your-work
# Testing
Your pull request will automatically be built and available under the following folder:
https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/
It is a good practice to add a URL to your built JAR in this pull request description,
so it is easier for the community to test your Add-on.
If your pull request contains a new binding, it will likely take some time
before it is reviewed and processed by maintainers.
That said, consider submitting your Add-on in the Marketplace:
https://community.openhab.org/c/marketplace/69
Don't forget to submit a thread about your Add-on in the openHAB community:
https://community.openhab.org/c/add-ons
-->
There are changes like this:
if (measures != null) {
List<@Nullable Measure> nullableMeasuresWithoutNulls = measures.stream().filter(Objects::nonNull).toList();
List<Measure> measuresWithoutNulls = new ArrayList<>(nullableMeasuresWithoutNulls.size());
for (@Nullable
Measure m : nullableMeasuresWithoutNulls) {
if (m != null) {
measuresWithoutNulls.add(m);
}
}
return measuresWithoutNulls;
}
being changed to:
return measures.stream().filter(Objects::nonNull).toList();
The lines failing in the Zigbee repository are similar:
and:
FYI @holgerf , @chris
1 Like
holgerf
January 31, 2025, 6:32pm
3
@laursen Fix proposed here:
openhab:main ← holgerfriedrich:pr-nullable
opened 06:30PM - 31 Jan 25 UTC
As reported [here](https://community.openhab.org/t/oh-5-0-snapshot-builds-failin… g/162137), our OH5 sandbox builds currently fail when building the zigbee addon.
On the local machine it builds against 4.3 and succeeds.
When I change `pom.xml` to use `5.0-SNAPSHOT`, I can reproduce the issue seen in the [Jenkins builds](https://ci.openhab.org/view/Sandbox/job/sandbox-openhab5-release/).
The proposed fix is probably not the most elegant way to do it.
However, compilation passes with OH5 and 4.3.
2 Likes
Mark_VG
February 25, 2025, 8:53am
4
Just a heads up that this is happening again:
laursen
February 25, 2025, 5:01pm
5
Thanks for staying vigilant!
main ← wborn:use-spotless-sortpom-plugin
@wborn - also not sure if related, but maybe something also has to be adapted in… the zwave binding repo? See for example https://ci.openhab.org/view/Sandbox/job/sandbox-openhab5-release/1562/console
```
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.38.0:check (codestyle_check) on project org.openhab.binding.zwave: Unable to parse configuration of mojo com.diffplug.spotless:spotless-maven-plugin:2.38.0:check for parameter indentAttribute: Cannot find 'indentAttribute' in class com.diffplug.spotless.maven.pom.SortPom -> [Help 1]
```
1 Like
I have passed it on here: