OH3: date format without local bits

Max_G · December 11, 2022, 9:58pm

opennHABian 3.3.0 rPi4 with 4GB

I used to have this date format (lines 1 and 2) in log files created by rules in OH2.
After migrating the format changed as seen in line 3 and 4.

2022-11-19T11:31:28.034+10:00 MEGA_MODBUS_ERROR_Invalid CRC at 8059
2022-11-19T11:51:15.686+10:00 MEGA_MODBUS_ERROR_Invalid CRC at 8059
2022-11-19T13:18:48.865143+10:00[Australia/Brisbane] MEGA_MODBUS_ERROR_Invalid CRC at 8051
2022-11-19T13:39:07.000743+10:00[Australia/Brisbane] MEGA_MODBUS_ERROR_Response Timed Out at 8000

OH2: val startOfDay = now.withTimeAtStartOfDay
OH3: val START_OF_DAY = ZonedDateTime.now().with(LocalTime.MIDNIGHT)

Is there a format on OH3 that matches lines 1 and 2?

Any hints appreciated.

rossko57 · December 12, 2022, 2:01pm

The question seems to be “how to format a Java zonedDateTime for pretty printing”?
example

rlkoshak · December 12, 2022, 5:04pm

You’re talking about the timestamps on log entries, right?

All logging stuff is controlled by $OH_USERDATA/etc/log4j2.xml. But the default pattern layouts there shouldn’t be showing the timezone at all, in neither OH 2.5 nor OH 3. Also, those examples are missing a bunch of stuff that is normally there like the logging level and where the log statement came from.

So have you ever edited this file? Do the contents of this file differ from the official one?

github.com

openhab/openhab-distro/blob/65c74418e458a66a05429a8cfc3f63fdc35f1305/distributions/openhab/src/main/resources/userdata/etc/log4j2.xml

<?xml version="1.0" encoding="UTF-8" standalone="no"?><Configuration monitorInterval="10">

	<Appenders>
		<!-- Console appender not used by default (see Root logger AppenderRefs) -->
		<Console name="STDOUT">
			<PatternLayout pattern="%d{HH:mm:ss.SSS} [%-5.5p] [%-36.36c] - %m%n"/>
		</Console>

		<!-- Rolling file appender -->
		<RollingFile fileName="${sys:openhab.logdir}/openhab.log" filePattern="${sys:openhab.logdir}/openhab.log.%i" name="LOGFILE">
			<PatternLayout pattern="%d{yyyy-MM-dd HH:mm:ss.SSS} [%-5.5p] [%-36.36c] - %m%n"/>
			<Policies>
				<OnStartupTriggeringPolicy/>
				<SizeBasedTriggeringPolicy size="16 MB"/>
			</Policies>
		</RollingFile>

		<!-- Event log appender -->
		<RollingRandomAccessFile fileName="${sys:openhab.logdir}/events.log" filePattern="${sys:openhab.logdir}/events.log.%i" name="EVENT">
			<PatternLayout pattern="%d{yyyy-MM-dd HH:mm:ss.SSS} [%-5.5p] [%-36.36c] - %m%n"/>

This file has been truncated. show original

Is this one of your “other” logs that you create using echo instead of the built in logging features?

Max_G · December 13, 2022, 8:16am

My apologies to all for putting a half-*rse case forward…

The logging I am referring to is done via a rule writing to item-specific files. Like so:

        if (spm_Message.state.toString == "MEGA_MODBUS|INFO|has rebooted")
        {
            logInfo(LOG_PREFIX + "01.01", "--> MEGA_MODBUS has rebooted :(")
            spm_LastReboot.postUpdate(new DateTimeType())

            // logging controller reboots
            val String ERROR_MESSAGE = ZonedDateTime.now().toString + " " + spm_Message.state.toString.replace('|', '_')
            val String CLI_RETURN_CODE = executeCommandLine(Duration.ofSeconds(3), "/bin/sh", "-c", "echo " + ERROR_MESSAGE + " >> /etc/openhab/html/Modbus.txt; echo -n $?")
            logInfo(LOG_PREFIX + "01.02","Modbus message logged to file")

            if (Integer::parseInt(CLI_RETURN_CODE) != 0)
            {
                logInfo(LOG_PREFIX + "01.03","Return code: {}", CLI_RETURN_CODE)
            }
        }

I am talking about date formats coming from now()…

Max_G · December 13, 2022, 9:24am

Good article!

Changing to LocalDateTime resulted in the 2nd line…

2022-12-13T18:25:33.244697+10:00[Australia/Brisbane] MEGA_MODBUS_ERROR_Invalid CRC at 8059
2022-12-13T19:17:12.899308 MEGA_MODBUS_ERROR_Invalid CRC at 8100

… close enough.