Running openhabian on snapshot #136 but problem was also on #131 (maybe earlier too)
I figured a problem with the OWM binding yesterday…I was wondering why I dont get updated data for the owm items… so I checked and noticed that i’ve got a error in my logs…
2020-06-01 10:57:36.150 [DEBUG] [nWeatherMapWeatherAndForecastHandler] - Update weather and forecast data of thing 'openweathermap:weather-and-forecast:f163c326:local'.
2020-06-01 10:57:36.159 [hingStatusInfoChangedEvent] - 'openweathermap:weather-and-forecast:f163c326:local' changed from OFFLINE (BRIDGE_OFFLINE) to OFFLINE (CONFIGURATION_ERROR): Der Parameter Ort muss konfiguriert werden.
“the parameter location must be configured”
This is my .things file:
Bridge openweathermap:weather-api:api "OpenWeatherMap Konto" @ "Accounts" [apikey ="APIKEY", refreshInterval =10, language ="de"] {
Thing weather-and-forecast xx "OpenWeatherMap - Wetter xX" @ "Wetter" [location ="LAT.14Digits,LONG.15Digits,ALT", forecastHours =24, forecastDays =0]
}
This was working fine for quite a while… but dont know when exactly it stopped working and what have been changed in the last couple of days/weeks.
I also delete the things/items files… uninstalled the binding… cleaned cache and did a new install of the binding and thing config via PaperUI… Also no success…
Does anyone else have this problem too… do you have a clue what happend here @cweitkamp
The OWM binding uses a PointType for storing the user-defined location. I am not sure if it can handle latitude / longitude with such a number of digits. While looking into the code I realized that the binding swallows silently IAEs thrown by the PointType constructor. I will add a TRACE log for such cases.
To check if your location is the problem I suggest to create a PointType manually (e.g. in a Rule) passing the same location as String and eventually you will see the exception. If that will work nicely we have to dig deeper.
The Weather & Forecast Thing is only initialized with the location when the bridge is online. The bridge is only online when a thing is using it (I’m not sure about that, but it looks like that to me).
Looks like a chicken / egg problem to me
Oups, this is what is done.
So the problem is probably only the bad value of the location setting. Please try with the expected format and tell us if the problem is solved.
I don’t think that’s the problem (although I haven’t seen the representation of the location from @kugelsicha yet).
My Location looks like e.g. 48.8588017508614,2.3990725335516894. I have also tried it with less decimal places and with/without altitude.
The problem is that the bridge status depends on the “child” things (from OpenWeatherMapAPIHandler.java):
private void determineBridgeStatus() {
ThingStatus status = ThingStatus.OFFLINE;
for (Thing thing : getThing().getThings()) {
if (ThingStatus.ONLINE.equals(thing.getStatus())) {
status = ThingStatus.ONLINE;
break;
}
}
updateStatus(status);
}
For the Weather & Forecast thing to read the location from the config, the bridge must be online (see Code Snippet above), and the bridge only goes online when Weather & Forecast thing is online. Which only goes online when the bridge is online… and so on
I implemented it that way back in the days because I wanted to have a feedback from OWM API about valid apikey and / or location, etc… The binding itself only checks if parameters are set correctly and are compliant with openHAB standard. The rest has to be done by the OWM API. I guess there is a better way to set / determine the bridge status like my approach. I can have have a look too - if you like.
@cweitkamp : my PR was clearly pushed too fast, I did not see the unusual status management done on the bridge handler. My changes are not relevant considering the code in the bridge handler. I propose to simply undo my PR.
