Pushover image support

lfs_alp5 · January 24, 2018, 4:18pm

Hi,

Just read that Pushover now supports images, anyone skillfull enough to create a PR with this support?

cweitkamp · January 25, 2018, 10:20am

Hi,

I have a personal interest in that feature too. If I find time, I will look into it.

// EDIT: I filed an issue for the new feature.

ThomDietrich · January 25, 2018, 10:37am

@cweitkamp May I be the “Trittbrettfahrer” here
If you feel the interest, I’d also like to see the feature to cancel a message. Additionally it might be useful to retrieve the acknowledged callback data. https://pushover.net/api#receipt
Thanks!

cweitkamp · January 25, 2018, 11:51am

@ThomDietrich Of course. Sounds interesting. I will put it onto my TODO list.

The cancellation of a message should be possible but we have to introduce it as an APIBreaking change. Currently all pushover actions return a boolean value to indicate if the delivery of a message was successful or not. This return value has to be changed to String for those actions capable of sending emergency-priority notifications to return the receipt which is a unique identifier for the message. This is needed to cancel a specific message.

The acknowledged data will be quite challenging. We have to poll the Pushover API to access it. Correct me if I’m wrong but this is currently not possible with the ESH/OH actions API. Only when implementing bindings. And again we need the receipt idea for it.

ThomDietrich · January 25, 2018, 12:08pm

I had the same API breaking change problem in mind…

You could define a new function (like sendPushoverMsg()) alongside pushover() and deprecate pushover() over time (I never really liked the ambiguity of the name). That would be a fair solution for all users…
On the other side it might be a bit short-sighted to exchange boolean for String now, which could be a limiting factor next time a new idea comes around. So the solution might anyhow be as easy as defining sendPushoverEmergencyMsg()

Wdyt?

Regarding acknowledged: I was not yet sure what to use it for… so don’t sweat it.

cweitkamp · January 25, 2018, 12:32pm

I second your suggestion. New actions named sendPushoverEmergencyMsg() - skips the priority parameter and returns the receipt as String - and cancelPushoverEmergencyMsg(). I’m going to write down our thoughts in the issue.

// EDIT:

github.com/openhab/openhab1-addons

[Pushover] Feature request: Cancel emergency-priority notifications

opened 12:41PM - 25 Jan 18 UTC

closed 03:51AM - 02 Apr 18 UTC

cweitkamp

See https://pushover.net/api#receipt Some thoughts: - to avoid APIBreaking c…hanges introduce a `sendPushoverEmergency()` action which returns the `receipt` as `String` instead of `boolean` - `sendPushoverEmergency()` skips the `priority` parameter and sets it to `2` by default - introduce a `cancelPushoverEmergency()` action - to keep consistency other methods could be renamed to `sendPushover()`; `pushover()` should be marked as deprecated Link to the community thread https://community.openhab.org/t/pushover-image-support/39201

I’m going to write down our thoughts in the issue.

Done.

ThomDietrich · January 25, 2018, 1:31pm

While at it, maybe add other sendPushover...Msg() functions to be in sync with the new approach? Also I wonder if “Msg” should be exchanged by “Noti” or similar.

cweitkamp · January 25, 2018, 1:50pm

Other action bundles use sendMail(), sendTelegram() and so on. Maybe only sendPushover() and sendPushoverEmergency()?

ThomDietrich · January 25, 2018, 1:51pm

Excellent point. I’m a sucker for consistency

cweitkamp · January 25, 2018, 2:37pm

For me it’s the opposite: I try to keep consistency and stringency all along the way.

wars · January 25, 2018, 11:48pm

Nice to hear that someone will implement the attachment feature. Now I’ll be able to view my ipcam snapshot directly when someone is at the door

https://pushover.net/api#attachments

omatzyo · February 4, 2018, 7:46pm

I would also love to see the glances API implemented. It would be best to have a snippet on my Apple Watch…

https://pushover.net/api/glances

wars · February 26, 2018, 8:29pm

Is there already any progress regarding the ‘push images’ feature?

cweitkamp · February 26, 2018, 9:24pm

Sry, not yet. Too busy in the last couple of weeks. But my points on the TODO list reaches this one.

wars · February 26, 2018, 10:38pm

Nice to hear! thanks

waspie · March 7, 2018, 8:50pm

this would be great for door open = snapshot on phone. looking forward to this!

n1gh7shift · March 27, 2018, 8:56am

Hey!
Just wanted to throw the hat in the ring and say that I am super keen for this feature to be implemented into the Binding.
So happy you are working on it. Looking forward to it!
Thanks
Muzz

andre77 · March 27, 2018, 9:04am

there is already a PR for it: https://github.com/openhab/openhab1-addons/pull/5527

n1gh7shift · March 27, 2018, 11:38am

Thanks,
As it looks like the documentation hasn’t been updated yet… can you help me out with quick example code…?
EDIT-> Ok, just learned what a GitHub Pull Request was…

Let me know how you go!
Cheers

EDIT2->
Can I download your GitHub PR files and test them in my openhab? @andre77

wars · March 28, 2018, 1:32pm

Nice! thanks!

If we need to test the new binding, I’m willing to try. Just provide me the jar file