Pushover image support

waspie · March 7, 2018, 8:50pm

this would be great for door open = snapshot on phone. looking forward to this!

n1gh7shift · March 27, 2018, 8:56am

Hey!
Just wanted to throw the hat in the ring and say that I am super keen for this feature to be implemented into the Binding.
So happy you are working on it. Looking forward to it!
Thanks
Muzz

andre77 · March 27, 2018, 9:04am

there is already a PR for it: https://github.com/openhab/openhab1-addons/pull/5527

n1gh7shift · March 27, 2018, 11:38am

Thanks,
As it looks like the documentation hasn’t been updated yet… can you help me out with quick example code…?
EDIT-> Ok, just learned what a GitHub Pull Request was…

Let me know how you go!
Cheers

EDIT2->
Can I download your GitHub PR files and test them in my openhab? @andre77

wars · March 28, 2018, 1:32pm

Nice! thanks!

If we need to test the new binding, I’m willing to try. Just provide me the jar file

andre77 · March 28, 2018, 1:57pm

sure, you can test it
download pushover action as jar

use it like this:
sendPushoverImage(“Hello, this is a message with attached image.”, “/path/to/image.jpeg”);

feedback is very appreciated

wars · March 28, 2018, 6:40pm

thanks for sharing

I have 2 errors:

Rule:

var FrontDoorCam = "FrontDoor.jpg"
var LocationSS = "/tmp/"
var ImgFile = "file://" + LocationSS + FrontDoorCam
pushoverImage("Pushover test attachment", ImgFile)

Error:

2018-03-28 20:31:53.799 [ERROR] [ntime.internal.engine.RuleEngineImpl] - Rule 'TEST pushover': The name 'pushoverImage' cannot be resolved to an item or type; line 33, column 9, length 50

When I use my normal pushover command, which worked previously, I receive the message on my phone, but I also see an amount of errors in the logs:

pushover(null, null, "test message", null, "Push test", null, null, 0, "spacealarm")

Error

2018-03-28 20:39:35.650 [INFO ] [org.openhab.action.pushover         ] - FrameworkEvent INFO - org.openhab.action.pushover
java.io.IOException: Exception in opening zip file: /var/lib/openhab2/cache/org.eclipse.osgi/213/0/bundleFile
	at org.eclipse.osgi.framework.util.SecureAction.getZipFile(SecureAction.java:321) ~[?:?]
	at org.eclipse.osgi.storage.bundlefile.ZipBundleFile.basicOpen(ZipBundleFile.java:93) ~[?:?]
	at org.eclipse.osgi.storage.bundlefile.ZipBundleFile.getZipFile(ZipBundleFile.java:106) ~[?:?]
	at org.eclipse.osgi.storage.bundlefile.ZipBundleFile.checkedOpen(ZipBundleFile.java:65) ~[?:?]
	at org.eclipse.osgi.storage.bundlefile.ZipBundleFile.getEntry(ZipBundleFile.java:240) ~[?:?]
	at org.eclipse.osgi.storage.bundlefile.BundleFile.getResourceURL(BundleFile.java:136) ~[?:?]
	at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findResourceImpl(ClasspathManager.java:418) ~[?:?]
	at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalResources(ClasspathManager.java:395) ~[?:?]
	at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalResources(ModuleClassLoader.java:321) ~[?:?]
	at org.eclipse.osgi.internal.loader.BundleLoader.findLocalResources(BundleLoader.java:837) ~[?:?]
	at org.eclipse.osgi.internal.loader.BundleLoader.findResources(BundleLoader.java:693) ~[?:?]
	at org.eclipse.osgi.internal.loader.ModuleClassLoader.getResources(ModuleClassLoader.java:231) ~[?:?]
	at org.eclipse.osgi.internal.framework.ContextFinder.getResources(ContextFinder.java:165) ~[?:?]
	at java.util.ServiceLoader$LazyIterator.hasNextService(ServiceLoader.java:348) ~[?:?]
	at java.util.ServiceLoader$LazyIterator.hasNext(ServiceLoader.java:393) ~[?:?]
	at java.util.ServiceLoader$1.hasNext(ServiceLoader.java:474) ~[?:?]
	at javax.xml.parsers.FactoryFinder$1.run(FactoryFinder.java:293) ~[?:?]
	at java.security.AccessController.doPrivileged(Native Method) ~[?:?]
	at javax.xml.parsers.FactoryFinder.findServiceProvider(FactoryFinder.java:289) ~[?:?]
	at javax.xml.parsers.FactoryFinder.find(FactoryFinder.java:267) ~[?:?]
	at javax.xml.parsers.DocumentBuilderFactory.newInstance(DocumentBuilderFactory.java:120) ~[?:?]
	at org.openhab.action.pushover.internal.Pushover.parseResponse(Pushover.java:370) ~[?:?]
	at org.openhab.action.pushover.internal.Pushover.pushover(Pushover.java:350) ~[?:?]
	at org.openhab.action.pushover.internal.Pushover.pushover(Pushover.java:101) ~[?:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.invokeOperation(XbaseInterpreter.java:1085) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.invokeOperation(XbaseInterpreter.java:1060) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter._invokeFeature(XbaseInterpreter.java:1046) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.invokeFeature(XbaseInterpreter.java:991) ~[?:?]
	at org.eclipse.smarthome.model.script.interpreter.ScriptInterpreter.invokeFeature(ScriptInterpreter.java:141) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter._doEvaluate(XbaseInterpreter.java:901) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter._doEvaluate(XbaseInterpreter.java:864) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.doEvaluate(XbaseInterpreter.java:223) ~[?:?]
	at org.eclipse.smarthome.model.script.interpreter.ScriptInterpreter.doEvaluate(ScriptInterpreter.java:215) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.internalEvaluate(XbaseInterpreter.java:203) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter._doEvaluate(XbaseInterpreter.java:446) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.doEvaluate(XbaseInterpreter.java:227) ~[?:?]
	at org.eclipse.smarthome.model.script.interpreter.ScriptInterpreter.doEvaluate(ScriptInterpreter.java:215) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.internalEvaluate(XbaseInterpreter.java:203) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter._doEvaluate(XbaseInterpreter.java:459) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.doEvaluate(XbaseInterpreter.java:243) ~[?:?]
	at org.eclipse.smarthome.model.script.interpreter.ScriptInterpreter.doEvaluate(ScriptInterpreter.java:215) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.internalEvaluate(XbaseInterpreter.java:203) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter._doEvaluate(XbaseInterpreter.java:446) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.doEvaluate(XbaseInterpreter.java:227) ~[?:?]
	at org.eclipse.smarthome.model.script.interpreter.ScriptInterpreter.doEvaluate(ScriptInterpreter.java:215) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.internalEvaluate(XbaseInterpreter.java:203) ~[?:?]
	at org.eclipse.xtext.xbase.interpreter.impl.XbaseInterpreter.evaluate(XbaseInterpreter.java:189) ~[?:?]
	at org.eclipse.smarthome.model.script.runtime.internal.engine.ScriptImpl.execute(ScriptImpl.java:82) ~[?:?]
	at org.eclipse.smarthome.model.rule.runtime.internal.engine.RuleEngineImpl.lambda$2(RuleEngineImpl.java:343) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
	at java.lang.Thread.run(Thread.java:748) [?:?]
Caused by: java.io.FileNotFoundException: /var/lib/openhab2/cache/org.eclipse.osgi/213/0/bundleFile (No such file or directory)
	at java.util.zip.ZipFile.open(Native Method) ~[?:?]
	at java.util.zip.ZipFile.<init>(ZipFile.java:225) ~[?:?]
	at java.util.zip.ZipFile.<init>(ZipFile.java:155) ~[?:?]
	at java.util.zip.ZipFile.<init>(ZipFile.java:169) ~[?:?]
	at org.eclipse.osgi.framework.util.SecureAction.getZipFile(SecureAction.java:304) ~[?:?]
	... 59 more

cweitkamp · March 29, 2018, 8:28am

We rename this action to sendPushoverImage(). Didn’t we?

@wars Had you uninstalled the original Pushover action before you put the new one into your addons folder?

kintrupf · March 29, 2018, 8:50am

Works perfectly

I put the snapshot jar in my addons folder, uninstalled the original Pushover binding, restarted openHAB.
Then I wrote the following in a rule which could be fired by a switch:

    sendPushoverImage("Test", "/volume1/SmartHome/openHAB/conf/icons/basic/washer.png")

And after clicking on the switch Pushover on my Android displayed the image!
No exceptions in my log, and the original “pushover” still works, too.

Thanks a lot!

andre77 · March 29, 2018, 9:05am

ups sorry guys, sure, the method name is “sendPushoverImage” and not “pushoverImage” !
so the code should look like this:

sendPushoverImage(“Hello, this is a message with attached image.”, “/path/to/image.jpeg”);

wars · March 29, 2018, 9:31am

It’s working with sendPushoverImage and after a restart of OpenHAB
Thanks for the effort !

Although I see one warning message (I used a .jpg file of 216KB):

2018-03-29 11:24:44.185 [WARN ] [he.commons.httpclient.HttpMethodBase] - Going to buffer response body of large or unknown size. Using getResponseBodyAsStream instead is recommended.

Is also possible to give extra parameters such as device, priority, sound… ? Or is the Pushover API not supporting this?

andre77 · March 29, 2018, 9:43am

glad, its working for you
here is the code of the SNAPSHOT version, you are using

you can use the method

pushover(String apiKey, String user, String message, String device, String title, String url, String urlTitle, int priority, String sound, String attachment)

some kind of a builder pattern would be a better approach there, feel free to implement

wars · March 29, 2018, 10:01am

Thanks

I’m already using this kind of method for my other Pushover messages, but didn’t knew that the attachment can be added now.
So there is no difference between pushover and sendPushoverImage ? Except that the 2nd only accepts title, message & attachment?

andre77 · March 29, 2018, 10:14am

correct
the old “pushover” method accepts additionally an optional “String attachment” parameter at the end of the list
“sendPushoverImage” accepts two parameters: message and path to the file, no title

andre77 · March 29, 2018, 6:12pm

just changed the code to avoid this warning

[WARN ] [he.commons.httpclient.HttpMethodBase] - Going to buffer response body of large or unknown size. Using getResponseBodyAsStream instead is recommended.

the warning is gone, i updated the snapshot jar file on my server, feel free to use it

rogerrem · April 1, 2018, 10:00am

Works! Two things i am missing tough:

Support for special characters, earlier my pushover would show æøå letters, this does not work now (replaced with “?”)
Possibility to add priority to the sendPushoverImage

Thnx for awesome work

andre77 · April 1, 2018, 10:14am

good catch, will have a look at it later today

edit:
just fixed the encoding, special characters should be fine now, the jar file is updated
i later will add another method to set the priority

edit2:
@rogerrem
just added the method

sendPushoverImage(String message, int priority, String attachment)

feel free to test it, do not forget to renew the jar file

edit3:

sorry @rogerrem
the correct method is: sendPushoverImage(String message, String attachment, int priority)

rogerrem · April 2, 2018, 5:10pm

Tested it now, but now it seems it doesnt work at all, downloaded the jar file from your previous post again.

2018-04-02 19:09:42.064 [ERROR] [o.o.c.s.ScriptExecutionThread ] - Error during
the execution of rule 'Ringeklokke': The name 'sendPushoverImage(<XStringLiteral
Impl>,<XNumberLiteralImpl>,<XStringLiteralImpl>)' cannot be resolved to an item
or type.

rogerrem · April 2, 2018, 5:45pm

Strange, the jar does not seem to work at all, the normal pushover(xxx) does not work anymore either.

sihui · April 2, 2018, 5:48pm

Cannot confirm, the “normal” pushover functions do work as before.
Note that you cannot have both bindings installed: you need to uninstall the “old” pushover binding and drop the new one into your addons folder.