QuantityType Channel

Kennet · November 9, 2022, 9:59pm

Hi everybody

I am creating a smartmeter binding, but I have some issues getting the QuantityType and UoM working.
First issue is that when I add a channel, the UI does not show the measurement units by default.
For instance the energy (Fwd_active_energy) is available as Wh and I guess that when I write “%d %unit%” in the thing-types.xml and the channel is added to the UI then this should show “<current value> Wh”.
My guess is that I did something wrong in the thing-types.xml.

So I am hoping that someone can help me out and tell me what I am doing wrong.
Here is a link to the file. openhab-addons/thing-types.xml at smartmeterosgp · kennetn/openhab-addons · GitHub

Thanks.

laursen · November 10, 2022, 12:01pm

Problem is here:

github.com

kennetn/openhab-addons/blob/c24a81a2f13d4d2d7feb09198ae79194662019e0/bundles/org.openhab.binding.smartmeterosgp/src/main/java/org/openhab/binding/smartmeterosgp/internal/SmartMeterOSGPHandler.java#L477


      
                      tableLength, byteOrder, charFormat, timeFormat, dataAccessMethod, identificationFormatBCD, manufacturer,
                      nameplateType, defaultSetUsed, procedureParameterLength, responseDataLength, standardVersion,
                      standardRevision);
          
          
    return true;
          }
          
          
public boolean handleTable23Reply(ByteBuffer tableData) {
              int tableLength = tableData.getShort();
              tableData.order(byteOrder);
              updateState(CHANNEL_Fwd_active_energy, new DecimalType(tableData.getInt()));
              updateState(CHANNEL_Rev_active_energy, new DecimalType(tableData.getInt()));
              tableData.position(3);
              logger.debug("Fwd Active {} Wh Rev Active {} Wh", tableData.getInt(), tableData.getInt());
              return true;
          }
          
          
public boolean handleTable28Reply(ByteBuffer tableData) {
              if (tableData.limit() != 44) {
                  logger.warn("Table28 has unexpected length {}", tableData.limit());
                  return false;

You need to create it as a QuantityType with unit provided:
updateState(CHANNEL_Fwd_active_energy, new QuantityType<>(tableData.getInt(), Units.WATT_HOUR));