[SOLVED] OH 2.4 S1434 & ZWave Error

Dim · November 21, 2018, 1:38pm

just upgraded my OH 2.4 from M6 to S1434 (with 2.4.0.201811202338 org.openhab.binding.zwave) and I am getting the following error in openhab.log:

2018-11-21 15:32:42.582 [ERROR] [ig.xml.osgi.XmlDocumentBundleTracker] - Could not send adding finished event for the module 'org.openhab.binding.zwave'!
java.lang.IllegalArgumentException: The label must neither be null nor empty.
	at org.eclipse.smarthome.core.thing.type.ThingTypeBuilder.build(ThingTypeBuilder.java:120) ~[?:?]
	at org.eclipse.smarthome.core.thing.xml.internal.ThingTypeXmlResult.toThingType(ThingTypeXmlResult.java:153) ~[?:?]
	at org.eclipse.smarthome.core.thing.xml.internal.ThingTypeXmlProvider.addingFinished(ThingTypeXmlProvider.java:148) ~[?:?]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.addingFinished(XmlDocumentBundleTracker.java:217) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.parseDocuments(XmlDocumentBundleTracker.java:359) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.processBundle(XmlDocumentBundleTracker.java:337) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.access$4(XmlDocumentBundleTracker.java:332) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker$2.run(XmlDocumentBundleTracker.java:307) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
	at java.lang.Thread.run(Thread.java:748) [?:?]

similar case to OH2.2 S1133 & ZWave Error

@chris

mhilbush · November 21, 2018, 2:24pm

When does this occur? At startup?

Dim · November 21, 2018, 2:25pm

yes. only on startup
functionality is not affected
all Z-Wave nodes are operating normally
i think that some info in the xml db are wrong… not a big problem

chris · November 21, 2018, 2:28pm

Maybe there’s been a change to ESH to add more checking and make certain things “illegal” - this happens periodically.

I think if you enable trace, or even debug logging, it should show the list of files being read so we can find out what the device is that has the problem. Once I know this a) I can fix it, and b) I will add a check to the database so that these are listed so people can fix them before they are released

Dim · November 21, 2018, 3:27pm

not much in TRACE log…

2018-11-21 17:22:49.688 [DEBUG] [org.openhab.binding.zwave           ] - BundleEvent [unknown:512] - org.openhab.binding.zwave
2018-11-21 17:22:49.712 [DEBUG] [org.openhab.binding.zwave           ] - ServiceEvent REGISTERED - {org.eclipse.smarthome.config.discovery.usbserial.UsbSerialDiscoveryParticipant}={service.id=121, service.bundleid=240, service.scope=bundle, component.name=org.openhab.binding.zwave.discovery.ZWaveUsbSerialDiscoveryParticipant, component.id=21} - org.openhab.binding.zwave
2018-11-21 17:22:49.721 [DEBUG] [org.openhab.binding.zwave           ] - ServiceEvent REGISTERED - {org.eclipse.smarthome.core.thing.binding.ThingHandlerFactory}={service.id=122, service.bundleid=240, service.scope=bundle, component.name=org.openhab.binding.zwave.internal.ZWaveHandlerFactory, component.id=25} - org.openhab.binding.zwave
2018-11-21 17:22:49.722 [DEBUG] [org.openhab.binding.zwave           ] - BundleEvent STARTING - org.openhab.binding.zwave
2018-11-21 17:22:49.724 [DEBUG] [inding.zwave.internal.ZWaveActivator] - Z-Wave binding started. Version 2.4.0.201811202338
2018-11-21 17:22:49.725 [DEBUG] [org.openhab.binding.zwave           ] - BundleEvent STARTED - org.openhab.binding.zwave
2018-11-21 17:22:52.528 [DEBUG] [org.openhab.binding.zwave           ] - ServiceEvent REGISTERED - {org.eclipse.smarthome.core.events.EventFactory}={service.id=182, service.bundleid=240, service.scope=bundle, component.name=org.openhab.binding.zwave.event.BindingEventFactory, component.id=22} - org.openhab.binding.zwave
2018-11-21 17:22:53.422 [DEBUG] [org.openhab.binding.zwave           ] - ServiceEvent REGISTERED - {org.eclipse.smarthome.config.core.ConfigDescriptionProvider, org.eclipse.smarthome.config.core.ConfigOptionProvider}={service.id=236, service.bundleid=240, service.scope=bundle, component.name=org.openhab.binding.zwave.internal.ZWaveConfigProvider, component.id=23} - org.openhab.binding.zwave
2018-11-21 17:22:55.994 [ERROR] [ig.xml.osgi.XmlDocumentBundleTracker] - Could not send adding finished event for the module 'org.openhab.binding.zwave'!
java.lang.IllegalArgumentException: The label must neither be null nor empty.
	at org.eclipse.smarthome.core.thing.type.ThingTypeBuilder.build(ThingTypeBuilder.java:120) ~[?:?]
	at org.eclipse.smarthome.core.thing.xml.internal.ThingTypeXmlResult.toThingType(ThingTypeXmlResult.java:153) ~[?:?]
	at org.eclipse.smarthome.core.thing.xml.internal.ThingTypeXmlProvider.addingFinished(ThingTypeXmlProvider.java:148) ~[?:?]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.addingFinished(XmlDocumentBundleTracker.java:217) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.parseDocuments(XmlDocumentBundleTracker.java:359) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.processBundle(XmlDocumentBundleTracker.java:337) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker.access$4(XmlDocumentBundleTracker.java:332) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker$2.run(XmlDocumentBundleTracker.java:307) [100:org.eclipse.smarthome.config.xml:0.10.0.201811171951]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:?]
	at java.lang.Thread.run(Thread.java:748) [?:?]

(from startup to error)
It happens at the very beginning of OH2 (6 secs after startup)

Dim · November 21, 2018, 3:31pm

ooops… TRACE on the wrong bundle org.eclipse.smarthome.config.xml.osgi.XmlDocumentBundleTracker is the correct one

restarting now

Dim · November 21, 2018, 3:43pm

@chris here is the trace… I can’t identify the offending xml
openhab.log (536.1 KB)

chris · November 21, 2018, 6:57pm

I think I’ve found the issue. I’ll do a database update shortly…

Dim · November 22, 2018, 6:35am

confirming issue fix on openHAB 2.4.0 Build #1436

thanx @chris !

chris · November 22, 2018, 8:46am

Thanks.