Subclass or extensions not classified correctly in OH 3.0 location tab UI

garthy · December 29, 2020, 3:00pm

So I’ve been having fun defining the semantic model moving from OH2->3. I’ve defined a bunch of door with the semantic class Door and These show up in the location tab of the main home page when open as Icons bedroom-location-open-door

But if I redefine the inner doors as the semantic class InnerDoor they do not show up even though they extend the equipment door. Is this a bug or am I doing something wrong?

(BTW do we need a new topic under Setup and Configuration for the Sematic model?)

garthy · December 29, 2020, 3:03pm

OK So I think there needs to be a lookup for InnerDoors (and all the other doors) here

github.com

openhab/openhab-webui/blob/master/bundles/org.openhab.ui/web/src/components/cards/glance/location/status-badge.vue#L76


  return findPoints(allEquipmentPoints(this.element.equipment), 'Point_Control', true, 'Property_Light')
case 'windows':
  equipment = findEquipment(this.element.equipment, 'Equipment_Window', false)
  if (!equipment.length) return []
  allPoints = allEquipmentPoints(equipment)
  points = findPoints(allPoints, 'Point_Status_OpenState', false)
  if (points.length) return points
  return equipment.filter((e) => e.points.length === 0).map((e) => e.item)
case 'doors':
  equipment =  [
    ...findEquipment(this.element.equipment, 'Equipment_Door', false),
    ...findEquipment(this.element.equipment, 'Equipment_Door_FrontDoor', false)
  ]
  if (!equipment.length) return []
  allPoints = allEquipmentPoints(equipment)
  points = findPoints(allPoints, 'Point_Status_OpenState', false)
  if (points.length) return points
  return equipment.filter((e) => e.points.length === 0).map((e) => e.item)
case 'garagedoors':
  equipment = findEquipment(this.element.equipment, 'Equipment_Door_GarageDoor', false)
  if (!equipment.length) return []

ysc · December 29, 2020, 3:08pm

There’s a parameter (“partial”) to include subclasses but for doors I wanted to treat garage doors separately, maybe it could be made better.

github.com

openhab/openhab-webui/blob/master/bundles/org.openhab.ui/web/src/components/cards/glance/glance-helpers.js

/**
 * Retrieves equipment based on their semantic class
 * @param {Array} arr the array of equipment items & points to search
 * @param {String} value the semantic class (value) to find
 * @param {Boolean} partial match subclasses
 */
export function findEquipment (arr, value, partial) {
  return arr.filter((e) => (partial) ? e.item.metadata.semantics.value.indexOf(value) === 0 : e.item.metadata.semantics.value === value)
}

/**
 * Retrieve the flatten list of points from the provided equipment collection
 * @param {Array} equipment the equipment collection
 */
export function allEquipmentPoints (equipment) {
  return equipment.map((e) => e.points || []).flat()
}

/**
 * Retrieves points based on their semantic class and eventual related property

This file has been truncated. show original

garthy · December 29, 2020, 3:15pm

OK Thanks. I think I’d include garage doors as a door just the location would not be in my home but outside and I’d want to know if any are open but this is where opinion comes in. I have no problems with defining them all as doors.

Having looked at the code I can see why my TVs are not showing up as the power item is defined as a point and not as a status. It the requirements of these badges defined anywhere? If they are just Documented that would be fine.

Bruce_Osborne · December 29, 2020, 3:28pm

Here some are attached as part of the home and some are a separate building. I have one neighbour that has one attached and one external.

garthy · December 29, 2020, 3:43pm

But that is what the model can express. They are doors wherever you put them on your model.

garthy · December 29, 2020, 3:44pm

Here is quick PR for Just the Doors