Ubiquiti Unifi Binding Feature Discussion

mhilbush · July 24, 2018, 6:21pm

Several times I’ve seen this in my logs.

2018-07-24 13:48:12.671 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler UniFiControllerThingHandler tried updating the thing status although the handler was already disposed.
2018-07-24 13:48:23.672 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler UniFiControllerThingHandler tried updating the thing status although the handler was already disposed.
2018-07-24 13:48:34.672 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler UniFiControllerThingHandler tried updating the thing status although the handler was already disposed.
2018-07-24 13:48:45.673 [WARN ] [.core.thing.binding.BaseThingHandler] - Handler UniFiControllerThingHandler tried updating the thing status although the handler was already disposed.

These messages begin whan openHAB is started, and continue every Refresh Interval even after stopping the binding. The only way I’ve found to resolve this is to restart openHAB.

I’m running this version of the binding, which admittedly is not the most current version. Let me know if you think this might be resolved in a more recent version.

2.3.0.201804210948

Edit: It’s coming from here in BaseThingHandler.

github.com

eclipse/smarthome/blob/936287de21b7a6baabcf969899b9b62d2faac0bf/bundles/core/org.eclipse.smarthome.core.thing/src/main/java/org/eclipse/smarthome/core/thing/binding/BaseThingHandler.java#L444


 * @param statusDetail the detail of the status
 * @param description the description of the status
 */
protected void updateStatus(ThingStatus status, ThingStatusDetail statusDetail, @Nullable String description) {
    synchronized (this) {
        if (this.callback != null) {
            ThingStatusInfoBuilder statusBuilder = ThingStatusInfoBuilder.create(status, statusDetail);
            ThingStatusInfo statusInfo = statusBuilder.withDescription(description).build();
            this.callback.statusUpdated(this.thing, statusInfo);
        } else {
            logger.warn("Handler {} tried updating the thing status although the handler was already disposed.",
                    this.getClass().getSimpleName());
        }
    }
}


/**
 * Updates the status of the thing.
 *
 * @param status the status
 * @param statusDetail the detail of the status